From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk0-f49.google.com (mail-vk0-f49.google.com [209.85.213.49]) by dpdk.org (Postfix) with ESMTP id CC8BE558E for ; Mon, 29 Feb 2016 19:22:03 +0100 (CET) Received: by mail-vk0-f49.google.com with SMTP id k196so143762797vka.0 for ; Mon, 29 Feb 2016 10:22:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=9aqWSFVFxe3hsGSXdNb0R1bYa4WqNyt3WBe34b4LznM=; b=gyHNd6GajV7sMUziivjerz6N1IVaV+TnGvkucb4NF0rERkNSFPpU5t9SgRvWU6G69B IZxklbMK38wX+4hheks5ef4vjQhrAgpNzKinOLNYuYHulmsbfU8UPfpPVTPGEwBUJmFs vSytbrssdgIYlWAUbfuXKVDpI2mNFblDOBDC48onHfnBAMlPCdyyquY3qXO5s0wCx8zX ZKL2Dr/L8yvePV2YlpH4COyNOZ6bfVYrHlUYx7DSvMUfy/ykQ1+sSOCe/Lhy1KA8avt9 Hhf5dCiy5EDkxTNWR8YO0oC7DqI4NkJ2iy1AptX7+AE4G8OhC73+FeuUB6pjIk3Iw2WT XEsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=9aqWSFVFxe3hsGSXdNb0R1bYa4WqNyt3WBe34b4LznM=; b=HDUxzvGRI65kJl9RLFjcZTGcxAcutXfoc8GLdhj1WmjemfhX7FLiZ2GN+9WMb6ay+5 nRM2y6gYIZu7FY4uYqSmTihUZAOT+8SlIb31dL59gIrp9TRsikbGXaINvL5dJFz3WWlK cq5jPJCn7S2b5+ub1tq/leub7oWzRYVBuZ+TG/mOpsASen2nCq89Fy7GgZbVPlqEKmap aLo75HwBNGL0YqgMJ3U/qm8Q/xRCV3XgNtuZ2BiYX0Kz/ESf8zAoMIOxO0qSf2VNlFDX wR5tTVDFQOtIWZ1b3EEk+5IHG4vL23jFNVS4rejLj58jKqR/npoBF/8QfjkKh0d1ojh4 J0xg== X-Gm-Message-State: AD7BkJKrvRgcBiTqCgyMaJX8Q4VV+NHM7u9OGfY4SnRsZ7zYVF83zT8MuKt/72Juhpz2WNxjwC6/D1Q0SkVzRw== MIME-Version: 1.0 X-Received: by 10.31.159.136 with SMTP id i130mr12675373vke.144.1456770123267; Mon, 29 Feb 2016 10:22:03 -0800 (PST) Received: by 10.159.37.73 with HTTP; Mon, 29 Feb 2016 10:22:03 -0800 (PST) In-Reply-To: <8CEF83825BEC744B83065625E567D7C219FB4223@IRSMSX108.ger.corp.intel.com> References: <1455208630-21710-1-git-send-email-woz@semihalf.com> <8CEF83825BEC744B83065625E567D7C219FB4223@IRSMSX108.ger.corp.intel.com> Date: Mon, 29 Feb 2016 19:22:03 +0100 Message-ID: From: =?UTF-8?Q?Wojciech_=C5=BBmuda?= To: "Iremonger, Bernard" Content-Type: text/plain; charset=UTF-8 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v3] af_packet: make the device detachable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Feb 2016 18:22:04 -0000 Hi Bernard, > Does making rte_pmd_af_packet_devinit local result in an ABI breakage? If someone uses it in their app, they'll be forced to change it. However, as this function is not intentionally public and there is API to create devices that finally calls rte_pmd_af_packet_devinit(), I'm not sure if any special caution is needed here. > Should the DPDK_2.0 structure be kept and a DPDK_2.3 structure added? Should it be just `DPDK_2.3 { local: *} DPDK_2.0`? Doesn't inheritance of DPDK_2.0 make the symbol also global in 2.3? > A deprecation notice may need to be added to the doc/guides/rel_notes/deprecation.rst file. As far as I understand, deprecation.rst is used to announce something will be removed in the future release. Changes already done should be moved from deprecation.rst to the release's .rst file. At least, this is what I see in commit logs. If this change should be announced in deprecation.rst, does this mean there should be another patch in the future (after 2.3 release?) making this function static? And that future patch will add DPDK_2.3 structure in the map file? Thank you for your time, Wojtek