From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua0-f176.google.com (mail-ua0-f176.google.com [209.85.217.176]) by dpdk.org (Postfix) with ESMTP id EB9261E2F for ; Wed, 2 May 2018 00:15:32 +0200 (CEST) Received: by mail-ua0-f176.google.com with SMTP id w12so3428uaj.6 for ; Tue, 01 May 2018 15:15:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=JEttVGZiopdClxSAPanbHt/9eiyIBaKqg6g64y6y7dg=; b=M44xHB6zNDFxLGZEW4YcPA9zGMLXZqrSPHdoKYJjBjrbJJ/ggSPN3Ig4aJBEG6JWKx w9CM6rRNGvgabl2O8xvdI2w1i+aygYYCoGvjpNe/9gnQW99TLFWwzar+HAdKC/sSEvWR sTM8bpvCMgoiGRwGWQA9YJpW90VTXm82UBf9IjeSlNGowihQIBqJROh2HWjMLUhQz2aY 5KDxRGeDQYSLXuMs9eeKcP6jlEHnmbrKT0AaSClyV5isgBaKvrPYU8ufBfbwd1LwGAJ9 W+sVEepLJKx33uXpzjf51lhTtruzdB/itBg4Cb5csvFakn5PFagNzFGUxTElbuDfSLQj AiaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=JEttVGZiopdClxSAPanbHt/9eiyIBaKqg6g64y6y7dg=; b=ulm8Nq2RstHiKHYGU9im+iFPc1O/8mmWOPr7Noojqn7adewdGoi5FVSsCFUsJSdZfa dvqHDJh8Rp00DCkCJm9VPgJe2mYFwXLmSA6hKxwdPMkHFF7JjwYrHxFYjjcIevG4K47j 4X99+ing87CiexvsvNlk1tcF6zh0LqCLtbJuQ6PE29LnbXC2YVR3BZ2Gc4aUpIfYUuR+ Q6H7JpBSkuOCec35iJdyXrtvTsWgxe1qyg7CJbKR58lZadwlSCoT90FVuiqMqSkUXNkW CwpRFKgjASTzGM9GGkHZo2uAwTHcuTmLWYZ3eYCa3B/arcZJOPnPmnRmZ+l8We9kSZ4C cg9A== X-Gm-Message-State: ALQs6tCJ9Rm0AMkoQQ5ukAT7ctc+5u64AEtUfWWtA6SlBlHC3mUuS44e SWaldGB3v3/J5M1UJDy3tvlL8i9oDMq6pI1b/CA= X-Google-Smtp-Source: AB8JxZq9UgbZ9qUoCNXs5wCtdk49NsLPj6weYkzs4W8Xry5CFEQ0dvMuTlfNa6+q+1t20DO5xPl8S8Rsbk0t8Y6L0iw= X-Received: by 10.176.74.135 with SMTP id s7mr8700292uae.116.1525212932344; Tue, 01 May 2018 15:15:32 -0700 (PDT) MIME-Version: 1.0 Received: by 10.176.67.4 with HTTP; Tue, 1 May 2018 15:15:31 -0700 (PDT) In-Reply-To: <8866e4a2-3c21-9f94-37d9-947fe0b93cac@intel.com> References: <20180223115913.19266-1-shweta.choudaha@gmail.com> <20180223115913.19266-2-shweta.choudaha@gmail.com> <6A0DE07E22DDAD4C9103DF62FEBC09093B76070A@shsmsx102.ccr.corp.intel.com> <58259bea-6f5b-3bb9-0a82-f3e2b9dd428f@intel.com> <20180404104042.GA17064@bricha3-MOBL.ger.corp.intel.com> <8866e4a2-3c21-9f94-37d9-947fe0b93cac@intel.com> From: Shweta Choudaha Date: Tue, 1 May 2018 23:15:31 +0100 Message-ID: To: Ferruh Yigit Cc: Bruce Richardson , "Lu, Wenzhuo" , "dev@dpdk.org" , "shweta.choudaha@att.com" , "Zhang, Helin" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 1/1] net/ixgbe: Add API to update SBP bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2018 22:15:33 -0000 Hi Helin, Qi, Wenzhuo, Any update for this patch. Anything else needed or can this be merged ? Thanks, Shweta On Thu, Apr 26, 2018 at 11:56 AM, Ferruh Yigit wrote: > On 4/26/2018 11:20 AM, Shweta Choudaha wrote: > > Hi Ferruh/ Helin, > > > > Anything else needed for this patch > > > > http://dpdk.org/dev/patchwork/patch/37802/ > > Or can this be now acked - Have addressed all comments so far. > > Hi Helin, Qi, Wenzhuo, > > Any more comment on patch? > Please let me know if you prefer me getting this directly to next-net? > > > > > Thanks, > > Shweta > > > > On Tue, Apr 10, 2018 at 4:58 PM, Shweta Choudaha < > shweta.choudaha@gmail.com > > > wrote: > > > > Thanks for the review. > > I have sent an updated patch and will send patch to remove > experimental from > > API for next release > > > > Thanks, > > Shweta > > > > On Wed, Apr 4, 2018 at 11:40 AM, Bruce Richardson > > > > wrote: > > > > On Wed, Apr 04, 2018 at 11:14:35AM +0100, Ferruh Yigit wrote: > > > On 4/4/2018 3:25 AM, Lu, Wenzhuo wrote: > > > > Hi Shweta, > > > > > > > > > > > >> -----Original Message----- > > > >> From: dev [mailto:dev-bounces@dpdk.org > > ] On Behalf Of Shweta Choudaha > > > >> Sent: Friday, February 23, 2018 7:59 PM > > > >> To: dev@dpdk.org > > > >> Cc: shweta.choudaha@att.com > > > > >> Subject: [dpdk-dev] [PATCH 1/1] net/ixgbe: Add API to > update SBP bit > > > >> > > > >> From: Shweta Choudaha > > > > > >> > > > >> Add ixgbe API to enable SBP bit in FCTRL register to allow > > receiving packets > > > >> that may otherwise be considered length errors by ixgbe and > dropped > > > >> > > > >> Signed-off-by: Shweta Choudaha > > > > > >> Reviewed-by: Chas Williams chas3@att.com>> > > > >> Reviewed-by: Luca Boccassi bluca@debian.org>> > > > >> --- > > > > > > > > > > > >> --- a/drivers/net/ixgbe/rte_pmd_ixgbe_version.map > > > >> +++ b/drivers/net/ixgbe/rte_pmd_ixgbe_version.map > > > >> @@ -52,3 +52,9 @@ DPDK_17.08 { > > > >> rte_pmd_ixgbe_bypass_wd_timeout_show; > > > >> rte_pmd_ixgbe_bypass_wd_timeout_store; > > > >> } DPDK_17.05; > > > >> + > > > >> +EXPERIMENTAL { > > > >> + global: > > > >> + > > > >> + rte_pmd_ixgbe_upd_fctrl_sbp; > > > >> +} DPDK_17.08; > > > > The patch is fine except we should use 18.05 here. > > > > > > We have a rule to have an API as experimental for one release. > > > > > > Not sure about this rule covering the PMD specific APIs but by > default > > it is, we > > > can discuss to have an exception for PMD APIs or not. > > > > > > After one release developer should send patch to remove > experimental > > from API > > > > > +1 for following the process. > > I don't see why pmd-specific APIs should be a general exception. > Any > > exceptions should be on an individual case-by-case basis IMHO > > > > > > > >