From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua0-f196.google.com (mail-ua0-f196.google.com [209.85.217.196]) by dpdk.org (Postfix) with ESMTP id 091B11B65E for ; Tue, 10 Apr 2018 17:58:41 +0200 (CEST) Received: by mail-ua0-f196.google.com with SMTP id g10so7659003ual.6 for ; Tue, 10 Apr 2018 08:58:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=w8VoD5U4zvLsZ8/yEE0jw+et/YmtcRVj+vTqSt6gns0=; b=YX6JAYwHETsOfuFEJ9jO8FNejplGxKD6QxyUQydKy9nyRKJhqclEQwmuW1xxsnS+N8 Sb9gk389Yqog/fW2FybRrXENHdRM5IEOPOTEd8ikCTyDvHM2mhBuB2en7BhZya8nOf5t xM7M5118/UtYTpmyhkuNd75OQnRXBIICDtau3/BB8+Xwbl2XsFfj13jw/lUIeuTbrQLr FVyYbrBZ6LHuTmSxaVeEvtrunS5c1/udepRojRG7lBQBxomlUurOaxHyxcSp/crZ6Cen NzthlLWe6wb81lLQsPXxlpmXBE1EhkMX/cAO27pyRXaqeo3FAnAQGHwjfz8ZKTlwRjbW TEVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=w8VoD5U4zvLsZ8/yEE0jw+et/YmtcRVj+vTqSt6gns0=; b=F449Mei5j93efGCs6PdxaFZWZzZhQ+0VMecxTnB+YXq1K8Gy/fe8RkowUU4xpfbQMY rIrC49t3ZbfRMGntn9fgAWqAadBeFf3onA89KvllJSKUXWqsoelv6kecletSrP1SPXFU mWoHT1ko3t/rh8Mdlu/se03LN3P+VlxEPbAPfCEnJcTd2sO1hYmX1AzEOdlz3CcE9Ljs 8DN4omA5x7gTXS2Q6m69lpwbsp2ZC7EMKBCsW3bI49Hsu3IAj28jdrwwLSL3AM3+oaQS 2PRqWLS1TRwLRU5yGwxchuMcT5rZ0atW2J8vhGr0kGHl14wDmtIvojssbzWlJzG+AdaL vI6Q== X-Gm-Message-State: ALQs6tAjzMjqJIHCDJuJAfTIS9n2yEGlwVINTGRoyvAdX07Y4YbuKloC OT1JsJdsK2v/qpkOGYTaI+ezGbJg23lglvhqfuY= X-Google-Smtp-Source: AIpwx4/dDD9FEXXhmBzqWgXwoaXQ7bXtk9rvuzeazzqH7Gx1kDfGgC9Lv4O5+wgkusWx6vQAi1YHMEb74tYhLi4PF7w= X-Received: by 10.176.30.138 with SMTP id o10mr792764uak.184.1523375920441; Tue, 10 Apr 2018 08:58:40 -0700 (PDT) MIME-Version: 1.0 Received: by 10.176.1.179 with HTTP; Tue, 10 Apr 2018 08:58:39 -0700 (PDT) In-Reply-To: <20180404104042.GA17064@bricha3-MOBL.ger.corp.intel.com> References: <20180223115913.19266-1-shweta.choudaha@gmail.com> <20180223115913.19266-2-shweta.choudaha@gmail.com> <6A0DE07E22DDAD4C9103DF62FEBC09093B76070A@shsmsx102.ccr.corp.intel.com> <58259bea-6f5b-3bb9-0a82-f3e2b9dd428f@intel.com> <20180404104042.GA17064@bricha3-MOBL.ger.corp.intel.com> From: Shweta Choudaha Date: Tue, 10 Apr 2018 16:58:39 +0100 Message-ID: To: Bruce Richardson Cc: Ferruh Yigit , "Lu, Wenzhuo" , "dev@dpdk.org" , "shweta.choudaha@att.com" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 1/1] net/ixgbe: Add API to update SBP bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Apr 2018 15:58:41 -0000 Thanks for the review. I have sent an updated patch and will send patch to remove experimental from API for next release Thanks, Shweta On Wed, Apr 4, 2018 at 11:40 AM, Bruce Richardson < bruce.richardson@intel.com> wrote: > On Wed, Apr 04, 2018 at 11:14:35AM +0100, Ferruh Yigit wrote: > > On 4/4/2018 3:25 AM, Lu, Wenzhuo wrote: > > > Hi Shweta, > > > > > > > > >> -----Original Message----- > > >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Shweta Choudaha > > >> Sent: Friday, February 23, 2018 7:59 PM > > >> To: dev@dpdk.org > > >> Cc: shweta.choudaha@att.com > > >> Subject: [dpdk-dev] [PATCH 1/1] net/ixgbe: Add API to update SBP bit > > >> > > >> From: Shweta Choudaha > > >> > > >> Add ixgbe API to enable SBP bit in FCTRL register to allow receiving > packets > > >> that may otherwise be considered length errors by ixgbe and dropped > > >> > > >> Signed-off-by: Shweta Choudaha > > >> Reviewed-by: Chas Williams > > >> Reviewed-by: Luca Boccassi > > >> --- > > > > > > > > >> --- a/drivers/net/ixgbe/rte_pmd_ixgbe_version.map > > >> +++ b/drivers/net/ixgbe/rte_pmd_ixgbe_version.map > > >> @@ -52,3 +52,9 @@ DPDK_17.08 { > > >> rte_pmd_ixgbe_bypass_wd_timeout_show; > > >> rte_pmd_ixgbe_bypass_wd_timeout_store; > > >> } DPDK_17.05; > > >> + > > >> +EXPERIMENTAL { > > >> + global: > > >> + > > >> + rte_pmd_ixgbe_upd_fctrl_sbp; > > >> +} DPDK_17.08; > > > The patch is fine except we should use 18.05 here. > > > > We have a rule to have an API as experimental for one release. > > > > Not sure about this rule covering the PMD specific APIs but by default > it is, we > > can discuss to have an exception for PMD APIs or not. > > > > After one release developer should send patch to remove experimental > from API > > > +1 for following the process. > I don't see why pmd-specific APIs should be a general exception. Any > exceptions should be on an individual case-by-case basis IMHO >