From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk0-f66.google.com (mail-vk0-f66.google.com [209.85.213.66]) by dpdk.org (Postfix) with ESMTP id 1CD621B1E0 for ; Fri, 13 Apr 2018 18:41:14 +0200 (CEST) Received: by mail-vk0-f66.google.com with SMTP id i75so936187vke.8 for ; Fri, 13 Apr 2018 09:41:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=INb5JPzrjBc9nxib2gYqLEY7MxjxfHD6iBSZOoT3yaI=; b=UPHXAOVZ/kPsnmQUkgMCAzDh1GSTNFC0NQDF6UyLuSEEysN6i6VG5lY5et4rfpkcw7 NQX84ZyM7QGMjAJ5n0YYTEeSfIUSAFuaQ8m7ekDdrHC6Xqzp5GtINvrtl/BjaN3Ntq/8 wlkXDXThQ+JZJkW1qKZ5hc6ulMgRhOKLe6at3DWoAsnbyYCtcza8PO9ZPFIQoY355tXX GpNd6wdhMZLWxhm5cT1UxInDNxlgOdqpmtbibTyAIA2b6rgmtnxv8w6CSvP2w/COt3rD s439n0s5XtNRo4+zjRvA1bfSkMUIonCZcq0tReLcRqbmNzIW8VCVIHsU4CLoU7DjOAad I/2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=INb5JPzrjBc9nxib2gYqLEY7MxjxfHD6iBSZOoT3yaI=; b=RpbAbCvDvmZMLCOwFfXSDwxnotJuP74V+YR1p5v7//+efMOEFRv6ng6wMz1rba8Usv OhYJgiurul0xgY6Dbn2zsdYIrRF+C+xG+5sNEtpAzR8dt9mFt4vgjphANy/KxxcHlx1w mkSaoMrNsVxyHn3Vid7qndA3vIKYSNt37vAZ2ttX0wsK3KH5o6YH0h0+cTILz6vO5u1l UrL2ybKk60RvbywqDSc2WSuHHeOP9Arm8VewyDKMIBeiwgN97JDk5zJVV1YBu+ZlGzKb YGrr1QfPG5hqYxQ6dYzSuVgqcYwFqbIdBIv+fxvrqJImzWcrgLYA19rYxzxjIjlCddSk 9Lwg== X-Gm-Message-State: ALQs6tD6DLt1QZ3JggDxqAqSjFSkZbZZGdIba3UYZK6ZXc0rWhWAcort kT6UfpD524XcoeXi75rO8ZpfmDe951viJSi69R0= X-Google-Smtp-Source: AIpwx49bizytTf2F9JIAvlBSxTv8HvpXLx/OLRbclO7FkwE+KdxaXMaZPLUU+O3+C/mSClGJIzkxWM+FZnp3UyWZreI= X-Received: by 10.31.178.1 with SMTP id b1mr4380594vkf.133.1523637674447; Fri, 13 Apr 2018 09:41:14 -0700 (PDT) MIME-Version: 1.0 Received: by 10.176.1.179 with HTTP; Fri, 13 Apr 2018 09:41:14 -0700 (PDT) In-Reply-To: <039ED4275CED7440929022BC67E70611531909EA@SHSMSX103.ccr.corp.intel.com> References: <20180321173618.74200-2-shweta.choudaha@gmail.com> <20180411135935.61232-1-shweta.choudaha@gmail.com> <039ED4275CED7440929022BC67E70611531909EA@SHSMSX103.ccr.corp.intel.com> From: Shweta Choudaha Date: Fri, 13 Apr 2018 17:41:14 +0100 Message-ID: To: "Zhang, Qi Z" Cc: "dev@dpdk.org" , "Lu, Wenzhuo" , "Ananyev, Konstantin" , "Zhang, Helin" , "Yigit, Ferruh" , "shweta.choudaha@att.com" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v3] net/ixgbe: Add access and locking APIs for MDIO X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Apr 2018 16:41:17 -0000 Hi Qi, I have addressed your comments and sent a v4 patchset. Thanks, Shweta On Fri, Apr 13, 2018 at 3:37 AM, Zhang, Qi Z wrote: > Hi Choudaha: > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Shweta Choudaha > > Sent: Wednesday, April 11, 2018 10:00 PM > > To: dev@dpdk.org > > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > > ; Zhang, Helin ; > Yigit, > > Ferruh ; shweta.choudaha@att.com > > Subject: [dpdk-dev] [PATCH v3] net/ixgbe: Add access and locking APIs for > > MDIO > > Nitpick: title should not start with uppercase. > > > + > > +EXPERIMENTAL { > > + global: > > + > > + rte_pmd_ixgbe_lock_mdio; > > + rte_pmd_ixgbe_unlock_mdio; > > Can we rename to rte_pmd_ixgbe_mdio_lock and rte_pmd_ixgbe_mdio_unlock, so > all mdio functions can be list closely when follow the alphabet sequence? > > > > + rte_pmd_ixgbe_mdio_read_unlocked; > > + rte_pmd_ixgbe_mdio_write_unlocked; > > And this could be rte_pmd_ixgbe_mdio_unlocked_read/write to follow the > same pattern that action after object > > Regards > Qi > > > +} DPDK_18.05; > > -- > > 2.11.0 > >