From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <smarkovic@prolexic.com>
Received: from mail-ig0-f181.google.com (mail-ig0-f181.google.com
 [209.85.213.181]) by dpdk.org (Postfix) with ESMTP id 26851B5DA
 for <dev@dpdk.org>; Mon, 16 Feb 2015 16:37:39 +0100 (CET)
Received: by mail-ig0-f181.google.com with SMTP id hn18so24256820igb.2
 for <dev@dpdk.org>; Mon, 16 Feb 2015 07:37:38 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:date
 :message-id:subject:from:to:cc:content-type;
 bh=0oT4l2xLVOk1mbi59RE7QeDzxxS4VrpWsO+/mTVpz3Q=;
 b=li+ZNqOF43qAGEbpc4Z57GXQPlkEVszUQIUvWAx1L1m0Za1ZAZGtyem8q/vgYPEpll
 2PMrjemUqdIpN5Pa8Y4OqPEu9PE4XpRuIvyDfcC1FUWpOCRykSXJWl3WFDrEgPDIz6SS
 IO9J9D4MQ8pybi4pzjdEqsm3hkF1q+UuTqoVkw1micOnfyvXsKeyhjX23UCSqso4vexV
 S/vF9O2YWrpDOYIoMdJr0mQiG5FUyY3HJpUMoTZerDyuo6zomvuEg6GwsfgHKVVbELgv
 2XVZgNXMR4RfDBeLHE12TlqpVWNFswLxKJY/gvKNBy0gC8xlc8PNaS4taYgJKcI+/282
 T0kg==
X-Gm-Message-State: ALoCoQl0UhWQobFh18cCQF55WtV+3iI+j3PPtDEPwVd1k8ncN8le0oyfar9AYRf7U4l92WI+zWZm
MIME-Version: 1.0
X-Received: by 10.107.26.136 with SMTP id a130mr30847658ioa.2.1424101058433;
 Mon, 16 Feb 2015 07:37:38 -0800 (PST)
Received: by 10.107.173.162 with HTTP; Mon, 16 Feb 2015 07:37:38 -0800 (PST)
In-Reply-To: <2601191342CEEE43887BDE71AB977258213EC8FE@irsmsx105.ger.corp.intel.com>
References: <SNT153-W3649AE126111F4B4AF4290F8210@phx.gbl>
 <2601191342CEEE43887BDE71AB977258213EC8FE@irsmsx105.ger.corp.intel.com>
Date: Mon, 16 Feb 2015 10:37:38 -0500
Message-ID: <CAAmzY8i5nzsMmOef2rqfti9DQvC_1dGoTMukmEXqhiBnOnEpxA@mail.gmail.com>
From: Stevan Markovic <smarkovic@prolexic.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Cc: "dev@dpdk.org" <dev@dpdk.org>,
 "yuzhichang_scl@hotmail.com" <yuzhichang_scl@hotmail.com>
Subject: Re: [dpdk-dev] ACL lookup doesn't work for some schemes
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Feb 2015 15:37:39 -0000

Hi,

On Mon, Feb 16, 2015 at 4:56 AM, Ananyev, Konstantin <
konstantin.ananyev@intel.com> wrote:

> Yes, right now, libtre_acl to work correctly first field has to be 1B long
> and all subsequent grouped into sets of 4 consecutive bytes.
> I thought we have it documented into our PG, ACL section:
> http://dpdk.org/doc/guides/prog_guide/packet_classif_access_ctrl.html
> Though re-reading it again:
> "For performance reasons, the inner loop of the search function is
> unrolled to process four input bytes at a time. This requires the input to
> be grouped into sets of 4 consecutive bytes. The loop processes the first
> input byte as part of the setup and then subsequent bytes must be in groups
> of 4 consecutive bytes."
> It probably not very clear and need to be explained in more details.
> Will update the doc.
>
> Konstantin
>
>
While improving API documentation would be great, enforcing these
constraints on user defined fields in rte_acl_build(?) also (return an
error if constraints are not met) would be even better.

Stevan