From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-f65.google.com (mail-ot1-f65.google.com [209.85.210.65]) by dpdk.org (Postfix) with ESMTP id 642B64D3A for ; Thu, 7 Mar 2019 15:14:51 +0100 (CET) Received: by mail-ot1-f65.google.com with SMTP id n71so14175088ota.10 for ; Thu, 07 Mar 2019 06:14:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netcope.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UnLnsyDwrzmBJInh0ASA+IH2jKNPaQBeXZHfsVAXd+g=; b=kCAGKi1/r9y8sRorldXEdPtjsrk8R6e+qxStYXNXhhJUSRuE/tlu4ksX0F+jx1qSaj tyoTKRb91m72QLKv0wNVZv40ki5ppOwMsGasYxzxrd6tIWSFXHm1IgVeewq6YS6wHLXy K95/GkRtaRrt6bvNt4e5TxxNg7OQp0oPGDj/7eQny0mCrHGURAfIO1xA5tkkLyupPGWq CXWMqAwkkEjTCGowb9MvhhlD7+kBRAQFqPRf6McSTL11AXCZapZ56tx6ALSPrLpABqEi e/0j9AfCvRHmjmx99PEdtJmz9YlmMNvcjQg7tRTVzen68fbtN51Yl0uEzNu7lGkpr5hM 6lFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UnLnsyDwrzmBJInh0ASA+IH2jKNPaQBeXZHfsVAXd+g=; b=VeloiRB2xi6TAv9Ad0XGdk1/09GkWYxEQgRH6Hf9EOSFFepM31S5rimO33GkIBqnF8 Yj6NfnUG2YLw+DCXD3PqIzWZCSh6BzRHan49RuAmb2HeWhjPwvTz/mH8NisZVeaj0b/R VEVJ/Tn1ZAZ/rIuBzz5TFMlb64iXNrcNeDk2io+/ys6wjJ4FgmAnTu/N5ggGRd9vHWxt +Qhwpu6rdjhslKwR5zHw4YbDDPsws8pt6uvD+9hJCOJpn1c7BQvCmkBDjSoqRK29cyWc i+ZHyOQ7I4zIt+TsqhJwzBylnvQ/X8TWfdf90SomDFJgtdwLDVzatL1h8eK9ykZ+017G ByNQ== X-Gm-Message-State: APjAAAXqArT5rNwTCJ4SJZRXf5YflOnSysVINj4L+EsAczlOa6nHAB/8 LT642GX0b1VS+4SGGPcQGareEUcGMV+I3D05m6O+Ww== X-Google-Smtp-Source: APXvYqwnbh1WKK9Wq7YEYTnfC1+U4KTCAn8Xg2pLqLFct2Z++oDK7f05+DeI3Nlhrm03wkkEPvTU2wMufoRz7I5aAW4= X-Received: by 2002:a9d:5f16:: with SMTP id f22mr8515684oti.289.1551968090497; Thu, 07 Mar 2019 06:14:50 -0800 (PST) MIME-Version: 1.0 References: <1551185824-5501-2-git-send-email-cernay@netcope.com> <1551965093-273264-1-git-send-email-cernay@netcope.com> In-Reply-To: From: =?UTF-8?Q?Jan_Reme=C5=A1?= Date: Thu, 7 Mar 2019 15:14:39 +0100 Message-ID: To: Luca Boccassi Cc: Rastislav Cernay , dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4] net/nfb: new netcope driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Mar 2019 14:14:51 -0000 Hi, > I see netcope-common provides a pkg-config file, that's great. > However it's a bit broken at the moment: > > Name: netcope-common > Version: 6.3.0 > Description: Common software package for NetCOPE platform > Libs: -L${libdir} > Cflags: -I${includedir} > > There is no linker flag, and Libs.private is missing. It should have: > > Libs: -L${libdir} -lnfb > Libs.private: -lfdt > > Could you please get it fixed? We are preparing a release of netcope-common, which will include fixed pkg-config file. > > This will not work - the pkg-config filename is netcope-common.pc, not > libnfb.pc. The convention would be to rename the pkg-config file to > libnfb.pc, but if you want to keep the current name then all pkg-config > calls in this patch need to be updated. The first proposal on this issue, which this patch version is based upon, was to add a new "libnfb.pc" pkg-config file to netcope-common. This might be finalized either as a fix in netcope-common.pc or a separate libnfb.pc being shipped. Once this decision is made, we will address it appropriately in the patch. Best regards, Jan Remes