From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4BBF1A00E6 for ; Fri, 9 Aug 2019 17:02:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DEC31231E; Fri, 9 Aug 2019 17:02:03 +0200 (CEST) Received: from mail-ot1-f65.google.com (mail-ot1-f65.google.com [209.85.210.65]) by dpdk.org (Postfix) with ESMTP id 448E02082 for ; Fri, 9 Aug 2019 17:02:02 +0200 (CEST) Received: by mail-ot1-f65.google.com with SMTP id d17so133842339oth.5 for ; Fri, 09 Aug 2019 08:02:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netcope.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+VzxYCDGMofhFyLjw0buA6QePi0Wfg0IT+bU+esGWMI=; b=khAxsnU3GtfV/Z8bJ6y0+voGZXvP8F/gJ6+kGNk8vh3tbuDs+c/lOW7R/pWWHm7kIa EPUeYlMn9l7aSlrQNJDZRQWq92uvDJ6EcykLYN3Obbg8zWJP1sTxTFqSIeeHrNdmZm7S LKKHwfeSE8Wup8dfyYwwoLsiuOwCbJW+H+mFAQMgmc3P0BX+ZNmZFLd09k97T/SbGIcs eThdR2gcM0fgT6lEcJDAq4ZoCDdrfmKLJUJvmx03VQr6oSQ5KzRaVye4OQ9kFoUFbXKX o8k2iN0Zj+z2nUSufTPSuus4MC1MoY8n8mPvLHNZH2pXrru2NCtyp4dms25PlWTNrTpf GK7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+VzxYCDGMofhFyLjw0buA6QePi0Wfg0IT+bU+esGWMI=; b=ZqZJLdi6s3Ob4ytn0KXqIlBm+9kj/YXKRU5eBkT+eyWmFlEuE2W3gtUIvA4AcIbHl8 RHJnzglQds1aTHcLb3OrwgAKyUOUza9lg95BCQTOYB4BhE2jfZ6iDo+YHfJLUJdxBI3g v+2cJ5J/7fVNLfaV9n13TwPtBAR3kdYlb5+fYMj9ckX8owSk40HjmMjGJuDef0czkEZa CmdKp25HRadGcm3YgAGNKi/JXiZIWy20nygVw84n7ImfCh/9l9RpbnL9H30RxKDAUxpr yYjSSGxlQzXTPjB00UjuL+y+PiTece685is1pRh68YdqYEBsSukh+GGpaCBd5oanIowq zYlA== X-Gm-Message-State: APjAAAXAM7XiVRAH6DFSAcAff3diVst2B/U/ebcYo/7Si3cnFy+fW/OC n/BrQFVJ1C5McNQD0YkwZMG/3oFNfOeSMNfoU6HnsFJy X-Google-Smtp-Source: APXvYqyf0HWgtiEYgDaXgwoXQSMUdwIgvUEIWVMSGzxRtcjmxc6HXIS1Naem6+mTMes31dOLifNaQQVRWri8ed6BmnE= X-Received: by 2002:a9d:6742:: with SMTP id w2mr18800443otm.371.1565362921508; Fri, 09 Aug 2019 08:02:01 -0700 (PDT) MIME-Version: 1.0 References: <1565362745-152027-1-git-send-email-cernay@netcope.com> In-Reply-To: <1565362745-152027-1-git-send-email-cernay@netcope.com> From: =?UTF-8?Q?Jan_Reme=C5=A1?= Date: Fri, 9 Aug 2019 17:01:50 +0200 Message-ID: To: Rastislav Cernay Cc: dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] net/nfb: remove resources when dev is closed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Acked-by: Jan Remes On Fri, Aug 9, 2019 at 4:59 PM Rastislav Cernay wrote: > > From: Rastislav Cernay > > The rte_eth_dev_close() function now handles freeing resources for > devices (e.g., mac_addrs). To conform with the new close() behaviour we > are asserting the RTE_ETH_DEV_CLOSE_REMOVE flag so that > rte_eth_dev_close() releases all device level dynamic memory. > > Signed-off-by: Rastislav Cernay > --- > drivers/net/nfb/nfb_ethdev.c | 18 ++++++++++++------ > 1 file changed, 12 insertions(+), 6 deletions(-) > > diff --git a/drivers/net/nfb/nfb_ethdev.c b/drivers/net/nfb/nfb_ethdev.c > index c3119a0..4a19979 100644 > --- a/drivers/net/nfb/nfb_ethdev.c > +++ b/drivers/net/nfb/nfb_ethdev.c > @@ -210,12 +210,17 @@ > static void > nfb_eth_dev_close(struct rte_eth_dev *dev) > { > + struct pmd_internals *internals = (struct pmd_internals *) > + dev->data->dev_private; > uint16_t i; > uint16_t nb_rx = dev->data->nb_rx_queues; > uint16_t nb_tx = dev->data->nb_tx_queues; > > nfb_eth_dev_stop(dev); > > + nfb_nc_rxmac_deinit(internals->rxmac, internals->max_rxmac); > + nfb_nc_txmac_deinit(internals->txmac, internals->max_txmac); > + > for (i = 0; i < nb_rx; i++) { > nfb_eth_rx_queue_release(dev->data->rx_queues[i]); > dev->data->rx_queues[i] = NULL; > @@ -226,6 +231,9 @@ > dev->data->tx_queues[i] = NULL; > } > dev->data->nb_tx_queues = 0; > + > + rte_free(dev->data->mac_addrs); > + dev->data->mac_addrs = NULL; > } > > /** > @@ -446,6 +454,9 @@ > rte_kvargs_free(kvlist); > } > > + /* Let rte_eth_dev_close() release the port resources */ > + dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE; > + > /* > * Get number of available DMA RX and TX queues, which is maximum > * number of queues that can be created and store it in private device > @@ -520,15 +531,10 @@ > static int > nfb_eth_dev_uninit(struct rte_eth_dev *dev) > { > - struct rte_eth_dev_data *data = dev->data; > - struct pmd_internals *internals = (struct pmd_internals *) > - data->dev_private; > - > struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev); > struct rte_pci_addr *pci_addr = &pci_dev->addr; > > - nfb_nc_rxmac_deinit(internals->rxmac, internals->max_rxmac); > - nfb_nc_txmac_deinit(internals->txmac, internals->max_txmac); > + nfb_eth_dev_close(dev); > > RTE_LOG(INFO, PMD, "NFB device (" > PCI_PRI_FMT ") successfully uninitialized\n", > -- > 1.8.3.1 >