From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2D7ADA04B5; Thu, 10 Sep 2020 20:50:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 32C3C1C13B; Thu, 10 Sep 2020 20:49:23 +0200 (CEST) Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) by dpdk.org (Postfix) with ESMTP id E8A491C13B for ; Thu, 10 Sep 2020 20:49:21 +0200 (CEST) Received: by mail-lf1-f65.google.com with SMTP id z19so4170024lfr.4 for ; Thu, 10 Sep 2020 11:49:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4GGJwPjDB+sSrsXaiRNQWNeBRGKphjp58UMEsluZUi8=; b=g1q0w0q1jbnbQZFNvCAh0fpNEJpxD2LHgvx8Rygeo4Ic6zj+8drdsdfLLzPhMjh4gc s5nuuG5MXuVrf47MPWL407N1mEvd1UmYqJrlsRR+9spvpBrmzfXnwXWb7tg034g0btV5 fCWmD8zZ4AtQVzcIrhP777rZ7fVb7nkIt6b1M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4GGJwPjDB+sSrsXaiRNQWNeBRGKphjp58UMEsluZUi8=; b=aPbzwAJul/neCC+1IPONK6pLboPxS3jMERel87Y1cTwt75UdmUjnR1a3uYDiG56mLP 5INjy/XYLMoHbHbYpgYBLjOLUNKR+odw6TXR8VlGL1ti4P+z2u+HUxtWikTs8R5KFtgB rE+8H13vzc+x3EAQvFwuXeZDXZv2ATcHF4U519JIJYx7Myv0EafgLHOF2lc7JsDVbPPP ov+k8E791kLZ7DY1kLegnWV0WfZSRFSx+JvBKh78scW8m7ZKCC0fAz8I9SfKLyMuxnj6 xUcGDE8+02Z5nJF2JTkXttExi/+t76tiScmV4sLlBAFMOPfWkoRvl+2Tl49GvHZpEnjt m5Jg== X-Gm-Message-State: AOAM5300oDhBIkEv+YNkgz5zNQ6G45hXlC0XHOLOJh9EvncMl1YLpbvk h9ayZbDP0+3LiZofBevGN9AbHavKSeUqEZmOsi+zWw== X-Google-Smtp-Source: ABdhPJy5F0JtnwTi6iUsgl2TIwuqmWnZSPZxaUyNLFNgmzMYtpQpMECSf31MX7prGJO49q8OggJzNh4Og+vZZJkmOUI= X-Received: by 2002:a05:6512:3702:: with SMTP id z2mr4888615lfr.35.1599763760604; Thu, 10 Sep 2020 11:49:20 -0700 (PDT) MIME-Version: 1.0 References: <20200910060025.23838-1-dliu@iol.unh.edu> In-Reply-To: From: David Liu Date: Thu, 10 Sep 2020 14:48:44 -0400 Message-ID: To: Ferruh Yigit Cc: dpdk-dev , Lincoln Lavoie , Thomas Monjalon Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH V1] testpmd: add eeprom/module eeprom display X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Sep 10, 2020 at 7:47 AM Ferruh Yigit wrote: > On 9/10/2020 7:00 AM, David Liu wrote: > > Add module EEPROM/EEPROM dump command > > "show port (module_eeprom|eeprom)" > > Commands will dump the content of the > > EEPROM/module EEPROM for the selected port. > > > Hi David, > > When sending a new version, can you please increase the verstion tag in the > title, V1 -> V2 -> ... -> vN > > Also sending new patch as reply to previos one keep all versions in same > email > thread and helps reviewers also people who later checks from archives for > a feature. > > For both above you can find more details in the contribution guide, please > check > https://doc.dpdk.org/guides/contributing/patches.html#sending-patches > > > And there are a few errors below that this patch shouldn't be compiling > successfully, you can verify the build error from lab reports :) > Thank you so much, I will change to that format. > <...> > > > /* *** SHOW QUEUE INFO *** */ > > struct cmd_showqueue_result { > > cmdline_fixed_string_t show; > > @@ -19325,6 +19373,8 @@ cmdline_parse_ctx_t main_ctx[] = { > > (cmdline_parse_inst_t *)&cmd_load_from_file, > > (cmdline_parse_inst_t *)&cmd_showport, > > (cmdline_parse_inst_t *)&cmd_showqueue, > > + (cmdline_parse_inst_t *)&cmd_showeeprom, > > + (cmdline_parse_inst_t *)&cmd_showmoduleeeprom, > > This shouldn't compile because 'cmd_showmoduleeeprom' no more exists ... > > <...> > > > + > > +void > > +port_module_eeprom_displao(portid_t port_id) > > +{ > > There is a typo in the function name. > > > + struct rte_eth_dev_module_info minfo; > > + struct rte_dev_eeprom_info einfo; > > + int ret; > > + > > + if (port_id_is_invalid(port_id, ENABLED_WARN)) { > > + print_valid_ports(); > > + return; > > + } > > + > > + > > + ret = rte_eth_dev_get_module_info(port_id, &minfo); > > + if (ret != 0) { > > + switch (ret) { > > + case -ENODEV: > > + printf("port index %d invalid\n", port_id); > > + break; > > + case -ENOTSUP: > > + printf("operation not supported by device\n"); > > + break; > > + case -EIO: > > + printf("device is removed\n"); > > + break; > > + default: > > + printf("Unable to get module EEPROM: %d\n", > len_eeprom); > > I guess this is copy/paste error 'len_eeprom' is not defined in this > function. > There is one more occurance below. > > I will send out a new patch with all the fixes and that can be compiled hopefully. <...> >