From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f54.google.com (mail-pa0-f54.google.com [209.85.220.54]) by dpdk.org (Postfix) with ESMTP id 664E08E90 for ; Sat, 16 Jan 2016 09:06:25 +0100 (CET) Received: by mail-pa0-f54.google.com with SMTP id cy9so406655189pac.0 for ; Sat, 16 Jan 2016 00:06:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mvista-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=buKPjZ79ASMazsj/9+3Yqi0sQ5X8l7giEVmV+WQx3II=; b=UG23WWDhYirgbIHEp5ZskWKhdDge3HPXoNLHkpRf+7Qg9WmH7u79RUKKRGMYS3V7Fk SdX+cswK0XvS66EV7xsA/vuASxNhpR0tENvjffB7qm2mE55aE15A4D1435JGScabuamk H31RP/mrcilKpDklfMXtoPDDjKngWPeVbhzjKGK73Iu2d5Gw1WRqbIOEcGO1Tit4x9Eb wTX2OrlYkcim0phN1ZwiF1AfCVn5J68aGP8Oto3kPv24LrosAGuePFbxI8KNUKDKtfZq 3Naec1DGyo5iFeh7F4pNha/nQdt1/JiHvofWykwWq5TZmM6ksRICWBNJ28cohn3XESs+ 0skg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=buKPjZ79ASMazsj/9+3Yqi0sQ5X8l7giEVmV+WQx3II=; b=HieqErcWTOADehgO2MQKvrl0Kb/XKOC4ykHlD+UYUShMbWFwGlBO1kS8/t4LRo/rdh 3gmB8Od/9hYgP89h/OCBueZUxWo6h+yJ6Hx6xsH/HaxeJs8XFL1ndCFyQTd6gmaTX+Zn ziV2O2/IvzFX6FUz27vBwEB3e3wooAuMlekRKYfg07r0YIU0hKCdzm1J6EmPD/1Rh4Cr U52alGr/zf9J0DuK17SspBla466N3dGmI3fC/rd8lwb+7Y6M2M/KjH9q+TxjOhrAturq 0TlJVZdZVwXwYchu2cin4GasQlckjI9q8HZS7asuINXI7a3EcQnWB+d6JQ3DQaAUHi3X x6HA== X-Gm-Message-State: ALoCoQlFFuKXk/nBxWp4eLnrWWvsf29X+zBwdC9/Y73CxQ+aHB1JOgT8pZqAhrp3WNhHWuJ4dCScd2voh6+LkOkfvjTVJtZl3hIfwj58qdJvS5zVrFrPlFA= MIME-Version: 1.0 X-Received: by 10.66.140.79 with SMTP id re15mr20277737pab.127.1452931584652; Sat, 16 Jan 2016 00:06:24 -0800 (PST) Received: by 10.66.196.81 with HTTP; Sat, 16 Jan 2016 00:06:24 -0800 (PST) In-Reply-To: <20160115054853.GQ19531@yliu-dev.sh.intel.com> References: <1452778117-30178-1-git-send-email-sshukla@mvista.com> <1452778117-30178-7-git-send-email-sshukla@mvista.com> <20160115054853.GQ19531@yliu-dev.sh.intel.com> Date: Sat, 16 Jan 2016 13:36:24 +0530 Message-ID: From: Santosh Shukla To: Yuanhan Liu Content-Type: text/plain; charset=UTF-8 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v4 06/14] eal: pci: vfio: add rd/wr func for pci bar space X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Jan 2016 08:06:25 -0000 On Fri, Jan 15, 2016 at 11:18 AM, Yuanhan Liu wrote: > On Thu, Jan 14, 2016 at 06:58:29PM +0530, Santosh Shukla wrote: > ... >> +int rte_eal_pci_read_bar(const struct rte_pci_device *device, >> + void *buf, size_t len, off_t offset, >> + int bar_idx) >> + >> +{ >> +#ifdef VFIO_PRESENT >> + const struct rte_intr_handle *intr_handle = &device->intr_handle; >> + return pci_vfio_read_bar(intr_handle, buf, len, offset, bar_idx); >> +#else >> + /* UIO's not applicable */ >> + RTE_SET_USED(device); >> + RTE_SET_USED(buf); >> + RTE_SET_USED(len); >> + RTE_SET_USED(offset); >> + RTE_SET_USED(bar_idx); >> + return 0; >> +#endif > > Maybe you could do that like what pci_map_device() does: > > switch(dev->kdrv) { > case RTE_KDRV_NIC_VFIO: > return pci_vfio_read_bar(..); > break; > default: > RTE_LOG(.... not supported by driver: %d\n"..); > break; > } > > With that, you could get rid of those ugly RTE_SET_USED.... > Even better, Thanks! > --yliu