From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f51.google.com (mail-pa0-f51.google.com [209.85.220.51]) by dpdk.org (Postfix) with ESMTP id 4826A8E7E for ; Fri, 15 Jan 2016 13:37:32 +0100 (CET) Received: by mail-pa0-f51.google.com with SMTP id uo6so379169785pac.1 for ; Fri, 15 Jan 2016 04:37:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mvista-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=RqP2wH6oDBWAoE/TpVw2+YMfWYpqjR4TcNlBqOIb1Jw=; b=STn7P0oHjSUjPAGycusRMET3FW1aCcOox3hBV+BEflCDeV2qtkQP4pSyAiX5Jfqrge ykBpDhYSSaoytF6tPxqmJT7fZtIDAsRJ9LtU3nrsSAhgsYr0NGujMyh9dlZ4h7fvFzmE am7DGca48bOXERYslXRhP6yuIiCxb3uwPAuMPBSbuI7MUjwFJNZWWtOm+wbDU6e8sP1Q /kgx3bqa8snN8cJbwijKwREhu9TWAF3EYkewO229vyggAmpvPbFzy0iuzNz0LLY31n9q cPCm8cK4QTnICPTLZo4I4b9dXgS61b4BLHzYlS+YRpe7bWr2C+2Z0XYltXVFKnNEleb9 C14w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=RqP2wH6oDBWAoE/TpVw2+YMfWYpqjR4TcNlBqOIb1Jw=; b=S9rVBZf40aYgz/TQoH7y4Ettcc2ml55gGvjBUtzrpSbl1gmRodVQsPOsoL7k9cjdXd 4XC/13vvBKxiWJelNTuaHdITH+DWVFFnmLAHb0LOWoQEYdVFHYabkTv+u16uPMNaK940 sZhGy3pittwlJz/zbcRF/M1EgJsW/F2+skxfXVlIL8ES5pF2kopDIqSxr1Wsqn61ZpjZ Iff/s+X1tkWlnvQ3ivzgL+dHAmKDNqRJvvk4hnyZCZLBqJNy0ag98bWMlw/K4lEQZv7V 8r6lEoQuxRXYNxhIznNbms+Z7sih8cEgKBnnVIhpXGBA4JYmU7boBL/9Gz101CBddHUW 78EA== X-Gm-Message-State: ALoCoQnhKfPnMcnbM8hbNcb4josNv+bpGc3mLH6cTzua65KxcQBRZlnxo2quAjvhFLDdWxkVNLSW4kHNo82Fj+/txbNfC9OTLJd2MwvOu4Q08u9qVexJblw= MIME-Version: 1.0 X-Received: by 10.66.182.202 with SMTP id eg10mr14651003pac.50.1452861450307; Fri, 15 Jan 2016 04:37:30 -0800 (PST) Received: by 10.66.196.81 with HTTP; Fri, 15 Jan 2016 04:37:30 -0800 (PST) In-Reply-To: <20160115063536.GT19531@yliu-dev.sh.intel.com> References: <1452778117-30178-1-git-send-email-sshukla@mvista.com> <1452778117-30178-10-git-send-email-sshukla@mvista.com> <20160115063536.GT19531@yliu-dev.sh.intel.com> Date: Fri, 15 Jan 2016 18:07:30 +0530 Message-ID: From: Santosh Shukla To: Yuanhan Liu Content-Type: text/plain; charset=UTF-8 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v4 09/14] virtio: ethdev: check for vfio interface X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jan 2016 12:37:32 -0000 On Fri, Jan 15, 2016 at 12:05 PM, Yuanhan Liu wrote: > On Thu, Jan 14, 2016 at 06:58:32PM +0530, Santosh Shukla wrote: >> Introducing api to check interface type is vfio or not, if interface is vfio >> then update struct virtio_vfio_dev {}. >> >> Those two apis are: >> - virtio_chk_for_vfio >> - virtio_hw_init_by_vfio >> >> Signed-off-by: Santosh Shukla > .. >> +/* Init virtio by vfio-way */ >> +static int virtio_hw_init_by_vfio(struct virtio_hw *hw, >> + struct rte_pci_device *pci_dev) >> +{ >> + struct virtio_vfio_dev *vdev; >> + >> + vdev = &hw->dev; >> + if (virtio_chk_for_vfio(pci_dev) < 0) { >> + vdev->is_vfio = false; >> + vdev->pci_dev = NULL; >> + return -1; >> + } >> + >> + /* .. So attached interface is vfio */ >> + vdev->is_vfio = true; >> + vdev->pci_dev = pci_dev; > > Normally, I don't like the way of adding yet another "virtio_hw_init_by_xxx". > > As suggested in another reply, would pci_dev->kdrv checking be enough? > If so, do it in simple way. > No, It wont be enough, Virtio could only work for vfio for _noiommu_ mode and for that user need to preset -noiommu parameter, therefore virtio need to check that parame. pci_dev->kdrv check not enough, Hence not used. > --ylu