From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f171.google.com (mail-pf0-f171.google.com [209.85.192.171]) by dpdk.org (Postfix) with ESMTP id CB2F7293B for ; Tue, 1 Mar 2016 07:08:56 +0100 (CET) Received: by mail-pf0-f171.google.com with SMTP id 124so44901409pfg.0 for ; Mon, 29 Feb 2016 22:08:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mvista-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=7yQP6RceT7/5B2JHSraNW5wlygXc9rYbVEpvXVUaoHM=; b=R4TkhoC6IIt111rrhk36PbSPILQoRDU2lN4jwWAzRU911tp/pkMD+JzEM/in78CRtq kNY0yYks00qYp6BbdwPatGRwul3trQ4hRQZ0yfrrM/tBJhq63AvhLs/YHlIidQJN4IwN K++oxIGYMKFQJ/0jLDclDyLe+2gbQ3GdxUUO91AXsHgwEl4otnpkAIJOYTdIMSsj8zQM QY3eF3UlnHqt/bqaxBSiyms4EuILdmeZws2aE0QGdu79PTjtIhSwvhH0xBxB+Adz8Oka /dzoYRDNIP8ujU/jBaXiZbtN9ZaiDIZ1/cGPAcZykEheBGRBsjCWiyEo7JRwUadeJRYQ HYZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=7yQP6RceT7/5B2JHSraNW5wlygXc9rYbVEpvXVUaoHM=; b=nJ6LVv3dxSIaL+qXef/Gpe77ueiKZClXqXIIpnBSXdsMe0SOPP7GFq2yF3Zg1ts/XU izohuZfCS1lzh2lEmvRgiOgvLWGT4/oOqguNRodB0q0JKHIRYsV27iu2xDrM45K67Nsw R4OE56jmxL1srAF4/opV85AzZ1anTmEMLTU2Ud6qDdk2FypnQ8bSlBAKBNZKgyfT+SJp rIv0rYDyUEuQZ7fFu5UV364OmwfWahRjQodUW2dWuZSDqw1cG6w7NDBMNZcwQxRW5JZb Bzyjzw2gqIn1LF97Bp5cgqTNjvWTPmv2YFp9DRvvDSTYoiqG+I75/shoyTQcQ6PXUD2g ezCQ== X-Gm-Message-State: AD7BkJKwDhyrUmRcCRyVSiS3bWujgb3OBBWCRU+E1KJbEqOGlmgnLboTiwmqzdVF5wjE3N3EALG3awy4Bw3Avmxa MIME-Version: 1.0 X-Received: by 10.98.14.68 with SMTP id w65mr27900720pfi.144.1456812536137; Mon, 29 Feb 2016 22:08:56 -0800 (PST) Received: by 10.66.176.200 with HTTP; Mon, 29 Feb 2016 22:08:55 -0800 (PST) In-Reply-To: <20160301055911.GM14300@yliu-dev.sh.intel.com> References: <1456476662-23081-1-git-send-email-sshukla@mvista.com> <1456750690-3210-1-git-send-email-sshukla@mvista.com> <20160301055911.GM14300@yliu-dev.sh.intel.com> Date: Tue, 1 Mar 2016 11:38:55 +0530 Message-ID: From: Santosh Shukla To: Yuanhan Liu Content-Type: text/plain; charset=UTF-8 Cc: dpdk Subject: Re: [dpdk-dev] [PATCH v2] virtio: Use cpuflag for vector api X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Mar 2016 06:08:57 -0000 On Tue, Mar 1, 2016 at 11:29 AM, Yuanhan Liu wrote: > On Mon, Feb 29, 2016 at 06:28:10PM +0530, Santosh Shukla wrote: >> Check cpuflag macro before using vectored api. >> -virtio_recv_pkts_vec() uses _sse3__ simd instruction for now so added cpuflag. >> - Also wrap other vectored freind api ie.. >> 1) virtqueue_enqueue_recv_refill_simple >> 2) virtio_rxq_vec_setup >> >> - removed VIRTIO_PMD=n from armv7/v8 config. >> >> todo: >> 1) Move virtio_recv_pkts_vec() implementation to >> drivers/virtio/virtio_vec_.h file. >> 2) Remove use_simple_rxtx flag, so that virtio/virtio_vec_.h >> files to provide vectored/non-vectored rx/tx apis. >> >> Signed-off-by: Santosh Shukla >> --- >> - v2: Removed VIRTIO_PMD=n from arm v7/v8 > > Firstly, I would not suggest you to send another new version, while there > still was discussions ongoing on old version. > > And, you should not mix the ARM stuff here; this patch should only do > what the patch title tells. In generic, don't do two or more things in > one patch. > w/o v2 patch, old version wont build for armv7/v8. Clubbing both in v2, inspired from v7 virtio INC_VEC review comment/feedback [1]. [1] http://dpdk.org/dev/patchwork/patch/10429/ > --yliu