Re: [dpdk-dev] [PATCH v3 06/12] eal: pci: vfio: add rd/wr func for pci bar space

[Santosh Shukla <sshukla@mvista.com>]

On Thu, Jan 7, 2016 at 11:49 PM, Stephen Hemminger <
stephen@networkplumber.org> wrote:

> On Thu,  7 Jan 2016 22:03:03 +0530
> Santosh Shukla <sshukla@mvista.com> wrote:
>
> >
> > +int rte_eal_pci_read_bar(const struct rte_pci_device *device
> __rte_unused,
> > +                      void *buf __rte_unused,
> > +                      size_t len __rte_unused,
> > +                      off_t offset __rte_unused,
> > +                      int bar_idx __rte_unused)
> > +{
> > +#ifdef VFIO_PRESENT
> > +     const struct rte_intr_handle *intr_handle = &device->intr_handle;
> > +     return pci_vfio_read_bar(intr_handle, buf, len, offset, bar_idx);
> > +#else
> > +     return 0; /* UIO's not applicable */
> > +#endif
> > +}
>
> It seems wrong to declare all the parameters as unused but then use them.
> Maybe there is a way to have a macro for USED(x) in the #else case
>

Yes, I followed such practice in v2 series but missed on v3, Sorry for that
and  we'll take care in v4.