From: Santosh Shukla <sshukla@mvista.com>
To: David Marchand <david.marchand@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v6 08/11] eal: pci: introduce RTE_KDRV_VFIO_NOIOMMUi driver mode
Date: Thu, 21 Jan 2016 16:43:38 +0530 [thread overview]
Message-ID: <CAAyOgsZYiPjiKR6nfL8bEoyr5JnVXK3uuKCSsZYfNfDz=jU4Eg@mail.gmail.com> (raw)
In-Reply-To: <CALwxeUvpghmk11YHCiGaRjDNfowJfLMTVWCGF9vLRrOZVQ4yHg@mail.gmail.com>
On Thu, Jan 21, 2016 at 4:02 PM, David Marchand <david.marchand@6wind.com>
wrote:
> Santosh,
>
> On Tue, Jan 19, 2016 at 7:57 PM, Santosh Shukla <sshukla@mvista.com>
> wrote:
> > Adding RTE_KDRV_VFIO_NOIOMMU mode in kernel driver. Also including
> > rte_vfio_is_noiommu() helper function. This function will parse
> > /sys/bus/pci/device/<bus_addr>/ and make sure that
> > - vfio noiommu mode set in kernel driver
> > - pci device attached to vfio-noiommu driver only
> >
> > If both condition satisfies then set drv->kdrv = RTE_KDRV_VFIO_NOIOMMU
> >
> > Also did similar changes in virtio_rd/wr, Changes applicable for virtio
> spec
> > 0.95 only.
>
> This is a mode (specific to vfio), not a new kernel driver.
>
>
Yes, Specific to VFIO and this is why noiommu appended after vfio i.e..
__VFIO and __VFIO_NOIOMMU.
> How come we need to distinguish between with/without iommu modes ?
>
By default vfio framework assumes iommu i.,e., iommu present. Unless user
explicitly set "enable_unsafe_noiommu_mode" param. so in my opinion, we
care to parse vfio driver for _noiommu_ mode only.
> Should not vfio behave the same way from an api point of view ?
>
>
Yes It should. vfio gives similar file_ops i.e.. read/write/mmap/seek etc..
I am little confused on your question, do you see any issue in vfio bar
rd/wr api implementation?
> Regards,
> --
> David Marchand
>
next prev parent reply other threads:[~2016-01-21 11:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-19 18:57 Santosh Shukla
2016-01-21 10:32 ` David Marchand
2016-01-21 11:13 ` Santosh Shukla [this message]
2016-01-21 11:28 ` Thomas Monjalon
2016-01-21 12:04 ` Santosh Shukla
2016-01-21 14:46 ` Thomas Monjalon
2016-01-21 17:17 ` Santosh Shukla
2016-01-25 15:29 ` Thomas Monjalon
2016-01-26 10:26 ` Santosh Shukla
2016-01-26 13:00 ` Thomas Monjalon
2016-01-26 14:05 ` Santosh Shukla
2016-01-26 14:28 ` Thomas Monjalon
2016-01-26 16:21 ` Santosh Shukla
2016-01-27 10:41 ` Santosh Shukla
2016-01-27 15:32 ` Santosh Shukla
2016-01-27 15:39 ` Thomas Monjalon
2016-01-27 15:56 ` Santosh Shukla
2016-01-27 17:18 ` Santosh Shukla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAyOgsZYiPjiKR6nfL8bEoyr5JnVXK3uuKCSsZYfNfDz=jU4Eg@mail.gmail.com' \
--to=sshukla@mvista.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).