From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f41.google.com (mail-pa0-f41.google.com [209.85.220.41]) by dpdk.org (Postfix) with ESMTP id 05B598E7A for ; Thu, 21 Jan 2016 12:13:39 +0100 (CET) Received: by mail-pa0-f41.google.com with SMTP id yy13so21687513pab.3 for ; Thu, 21 Jan 2016 03:13:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mvista-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=kpRQqYb430hXYrFZl02W6SRme/QJCZB9cCrDqOQJpcM=; b=DEmzioKRB+d8JUe2I50GaovOxfBVr9CjmGH+MWLAabG9ATKCen5rQv42eMyFpolZR7 RX1nAr/YVpXYoYhMRJMNDN7RmUMFP8jxdSr5Z22b0Ph2RtpV90t25oZRH8r7kAJtgrIu q3e+ohpGEDiIq4dG1zMpe9KyfvbvU5oRT16jNUkxw0/ZYHzs4pa2/rpnnJQAfPqjK1RD T3fFxMVlQ3T7tZDAUtgPK+x2YvHz6ChUcNsOQFj62ztH+is3v4AD0SI9KLsQSRhIpQi6 DpEPD6+rXD+tcXM1tLCidoYGtlS43yCCeKXhD5f/T3ZGStkm5aDDAtAum/WsBtV5EJYt Bp6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=kpRQqYb430hXYrFZl02W6SRme/QJCZB9cCrDqOQJpcM=; b=hiT9Chn4YSk0oi+pOxnFMMHNpxBrNy5dETJWFJcUGQVnFIGo+nSTkbx03uKVyGGfg4 LOCGPeg0C0SEo/nMuu5T7t1ANLTMtIzxSeU+gTP6dQ8w3NS4xCRGp6xzDLwkLjYVf/vX q6SieK6/u2nF3VyCdH/T/8OX2qjOX9RJgEgJB0/F19eIPwAMHvz4m+J4KjxGHMHfhNcP QPWYhyjah0XJEu3vYUjmR7mQxArCyp6t3ajK+p+b+Kf1urgUtLG04foycfdrV0SFRFLa xZMJn72nSdTH5Nsa5+qsi+WcfLpZ9O6b1JzKLOwizvDaLQ7lUSP8nFrwDhlFn4mJVWIh 13WQ== X-Gm-Message-State: AG10YOQpEUUOgsqu7Ri5Nc4LziUHBuRpLPT5+KMwxqpBpfSkzMOaVTLZ4vT+sWOFb4VOtEr0133C3bgAKf9dQ6b3 MIME-Version: 1.0 X-Received: by 10.66.252.42 with SMTP id zp10mr13238633pac.29.1453374818396; Thu, 21 Jan 2016 03:13:38 -0800 (PST) Received: by 10.66.196.81 with HTTP; Thu, 21 Jan 2016 03:13:38 -0800 (PST) In-Reply-To: References: <1453229842-15310-1-git-send-email-sshukla@mvista.com> Date: Thu, 21 Jan 2016 16:43:38 +0530 Message-ID: From: Santosh Shukla To: David Marchand Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v6 08/11] eal: pci: introduce RTE_KDRV_VFIO_NOIOMMUi driver mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jan 2016 11:13:39 -0000 On Thu, Jan 21, 2016 at 4:02 PM, David Marchand wrote: > Santosh, > > On Tue, Jan 19, 2016 at 7:57 PM, Santosh Shukla > wrote: > > Adding RTE_KDRV_VFIO_NOIOMMU mode in kernel driver. Also including > > rte_vfio_is_noiommu() helper function. This function will parse > > /sys/bus/pci/device// and make sure that > > - vfio noiommu mode set in kernel driver > > - pci device attached to vfio-noiommu driver only > > > > If both condition satisfies then set drv->kdrv = RTE_KDRV_VFIO_NOIOMMU > > > > Also did similar changes in virtio_rd/wr, Changes applicable for virtio > spec > > 0.95 only. > > This is a mode (specific to vfio), not a new kernel driver. > > Yes, Specific to VFIO and this is why noiommu appended after vfio i.e.. __VFIO and __VFIO_NOIOMMU. > How come we need to distinguish between with/without iommu modes ? > By default vfio framework assumes iommu i.,e., iommu present. Unless user explicitly set "enable_unsafe_noiommu_mode" param. so in my opinion, we care to parse vfio driver for _noiommu_ mode only. > Should not vfio behave the same way from an api point of view ? > > Yes It should. vfio gives similar file_ops i.e.. read/write/mmap/seek etc.. I am little confused on your question, do you see any issue in vfio bar rd/wr api implementation? > Regards, > -- > David Marchand >