From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f54.google.com (mail-pa0-f54.google.com [209.85.220.54]) by dpdk.org (Postfix) with ESMTP id 045AAC50C for ; Fri, 29 Jan 2016 05:32:27 +0100 (CET) Received: by mail-pa0-f54.google.com with SMTP id ho8so34621018pac.2 for ; Thu, 28 Jan 2016 20:32:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mvista-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=VUMcXQmvn0MHSoq3TLGU5e0x879nUc3g+fkSAHrEn9A=; b=DfZaA18NGpe8dPM5uvKAQRjHZBbN0obuv4ztTkhJ/2IgD/+Fm07ZAUQVHY9VNfD8pB Ua0RIf0K3kifubBrbKUwCcsl/FRt0hGQamGZZjEOYYcPkEU9fLl5+nMZ8QbuHooZPnNo XYFjzeYjKfUEIIOFOvuRDaOZRl5KI0CnElaAY2I8xollut/0lAmQHlWNyfgyiJaQIDDz +TV7syQnGqy8u2Ij0WA03PBbEOg+QImxsXZk8hWPKqc8iffeJmu0u+djAy6XyagpdTWe ST+me76lhU9NpFFg0SMK/wrIMDgy2tne0N9+1R2NECLy9gRlX8qw6awZ897bMlThNiCG ZZsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=VUMcXQmvn0MHSoq3TLGU5e0x879nUc3g+fkSAHrEn9A=; b=YFWKkN0rs/fFZuK8nUMZvAncZWYn2DJgVK+xlOMgRYWv05SoR7vWzq/z+vPp8xwpaU LXFI0JCMXTyAUiDE8wz1kR/zJCNK6aL01v+xFQp4Gxq/PLNN9dikiZDo1qvwDMGITiDi GvZVPGX2alqSp3h/+l/Nq3JfUmEQjJCcugZyV6aMWJj3pp21W4suEtiK1AL7/y6TeroB m3yIkOv8DGaFbFovNXIZ+r0rI41d0En+SmSh2ZXHI4BCPBilbpOW7NwWXft4/UiH7aNE k8xl6s5tgbVYIbreXxEcvFGCnxS65F7GahTj4tqTUF0vY5f1GvWRLqSvVBcX/HnkmqEO sNng== X-Gm-Message-State: AG10YORHt4FPqR/pm4ntnkkFtR5kzOrCKbHqf7Hmp/IHjwJqRnpu1kspPP92/CftCyXfGX+sQeGBWEO6lMBolBaN MIME-Version: 1.0 X-Received: by 10.66.177.193 with SMTP id cs1mr10481207pac.132.1454041946387; Thu, 28 Jan 2016 20:32:26 -0800 (PST) Received: by 10.66.196.81 with HTTP; Thu, 28 Jan 2016 20:32:26 -0800 (PST) In-Reply-To: <20160127023356.GA4257@yliu-dev.sh.intel.com> References: <1453203972-24855-1-git-send-email-sshukla@mvista.com> <1453203972-24855-2-git-send-email-sshukla@mvista.com> <20160127023356.GA4257@yliu-dev.sh.intel.com> Date: Fri, 29 Jan 2016 10:02:26 +0530 Message-ID: From: Santosh Shukla To: Yuanhan Liu Content-Type: text/plain; charset=UTF-8 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v5 01/11] virtio: Introduce config RTE_VIRTIO_INC_VECTOR X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jan 2016 04:32:27 -0000 Hi Yuan, On Wed, Jan 27, 2016 at 8:03 AM, Yuanhan Liu wrote: > On Wed, Jan 27, 2016 at 07:53:21AM +0530, Santosh Shukla wrote: >> Ping? > > I was on vacation late last week. And I was quite busy till now after > the vacation. So, sorry that I still don't have time to do more detailed > reviews in 1 or 2 days. Hopefully I can make it by this Friday. > > BTW, I had a very glimpse of this patchset, overall, it looks much > better now, except the EAL changes (I'm not the maintainer) and the > virtio io port read/write stuff: Tetsuay suggested to add another > access wraps, but I have few concerns about that. Anyway, I don't > have time for deeper thoughts, and I will re-think it later. > > --yliu did you got the chance for reviewing virtio specific patches? Thanks.