From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f178.google.com (mail-pf0-f178.google.com [209.85.192.178]) by dpdk.org (Postfix) with ESMTP id 5C8C9DE6 for ; Mon, 8 Feb 2016 06:45:54 +0100 (CET) Received: by mail-pf0-f178.google.com with SMTP id q63so422746pfb.0 for ; Sun, 07 Feb 2016 21:45:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mvista-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=7F31y+Jfn23lDN8/Jxv5nrBvtVcRZ0P45no+zJ9r/r8=; b=d62DBLoMcE9VBLG38ptjrfzDnVRBBaCNuDn5nT1UYgzXKQDkfiR77suncPemna73yl RCkhPNZYJQnaS3NOeA3o7tLjvmRew4t7LGm3zZ75Mh4ke3q11qPFFA3+KRZKDClhyfh/ xuzX/9Osp4T3n0xlDBEEkYvPtc7o2XK+lGTQuHE4FWZrqS64RUyUWdVgVpGrrRyTFdGt 44JNymhsF3ftFi1U8eUo44wDx1ZqdYqPyHncXikXWt0q6w57hPHGvEJHMlCkhNttiJXs wYy7/KowYrUTiPj+Jfx7a3c9VgEHHBBgavfUk0+KHavQj3NTIPO211F1fAoRPExgnxOD HpEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=7F31y+Jfn23lDN8/Jxv5nrBvtVcRZ0P45no+zJ9r/r8=; b=lA5XaIuMn3nMb+UWHfttIuQgaVuv1AtBQnSskF1v12fy2gt/dahT0zyF+BPiojq76C u9JjWAib45qs8jcO4XYrnpUAbnWPnlooq/Q3+XAb2kwJTJBxkeUSSq0XQ9Ted4h7JLuj AGydNmj8NJPpaBLSITLuDlRBoGRSGIgcodkEsBO9Uw6sYixk9E7VcevwKifez7OZIncd sgn2ucOJ0XVkpNTbNcKSNR81Y8QEXmF/P8/rYweCu5EOs3LNgEehYFLaeCZDCyHkUzD3 Jm22J/iaJkJtozRk/kw67q82D/mzwGY6WBTzsApsis+nKGwwHXVIiiCeHRWbajD0AVlI Yyxw== X-Gm-Message-State: AG10YOQtTZZGgHy6PWhNodDYT/UceSn1/1pIywgLOIa72x9+IvxqlzVd15GAdKGX+ZMFuhOpKSdZ1qhXtymloa3A MIME-Version: 1.0 X-Received: by 10.98.0.7 with SMTP id 7mr40109246pfa.5.1454910353645; Sun, 07 Feb 2016 21:45:53 -0800 (PST) Received: by 10.66.12.132 with HTTP; Sun, 7 Feb 2016 21:45:53 -0800 (PST) In-Reply-To: <2395124.Wzh8l6ZlGf@xps13> References: <1454853068-14621-1-git-send-email-sshukla@mvista.com> <1454853068-14621-3-git-send-email-sshukla@mvista.com> <2395124.Wzh8l6ZlGf@xps13> Date: Mon, 8 Feb 2016 11:15:53 +0530 Message-ID: From: Santosh Shukla To: Thomas Monjalon Content-Type: text/plain; charset=UTF-8 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v7 2/4] virtio: Introduce config RTE_VIRTIO_INC_VECTOR X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Feb 2016 05:45:54 -0000 On Mon, Feb 8, 2016 at 2:55 AM, Thomas Monjalon wrote: > 2016-02-07 19:21, Santosh Shukla: >> - virtio_recv_pkts_vec and other virtio vector friend apis are written for >> sse/avx instructions. For arm64 in particular, virtio vector implementation >> does not exist(todo). >> >> So virtio pmd driver wont build for targets like i686, arm64. By making >> RTE_VIRTIO_INC_VECTOR=n, Driver can build for non-sse/avx targets and will work >> in non-vectored virtio mode. >> >> Disabling RTE_VIRTIO_INC_VECTOR config for : >> >> - i686 arch as i686 target config says: >> config/defconfig_i686-native-linuxapp-gcc says "Vectorized PMD is not >> supported on 32-bit". >> >> - armv7/v8 arch. > > Yes it can be useful to disable vector optimizations, but it should done > at runtime, not a compilation option. I know it is already wrongly configured > at compilation for other drivers, we should fix them. > Can't we consider this separate topic. My intent is virtio works for arm. > Here, you want to avoid SSE/AVX code on ARM. So we should just add the > appropriate ifdefs. Adding a compilation option does not prevent from enabling > it on ARM or old x86 which do not support these instructions. > By disabling VIRTIO_INC_VEC, compiler wont build virtio_recv_pkts_vec(), so wont generate SSE/AVX code. Adding ifdef for other arch example arm, is next step. Vector instruction for arm are not fully supported, Its a todolist (Pl. refer my early v1/2 cover-letter), We'll add that after virtio functionally works for arm. > Please virtio maintainers, we need to fix this code. Thanks