From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f170.google.com (mail-pf0-f170.google.com [209.85.192.170]) by dpdk.org (Postfix) with ESMTP id 884158E5E for ; Sat, 16 Jan 2016 09:53:26 +0100 (CET) Received: by mail-pf0-f170.google.com with SMTP id 65so130142823pff.2 for ; Sat, 16 Jan 2016 00:53:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mvista-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=7hxUw3CCQIsMDyCrcMAySZ3boqNN1iI86S85abS8aAU=; b=E57g2fo26F0b9eabov9YTh+6l0/eQCvAEPdplo3DGqTH1VcDI1x2VgoIFwD54T0cTG 6VaHOJWsuwa7JrHMWimBKJeLwi2vfg6AZJ6C4Vy+4XubrNlINZT2Ux4H7POoilFb5PAH 8tPheJ68eN/v9xIVoMIkUDFyRuWx7UC5PAdd49OKr4AJlIfUJntG+vLYdO24s/YapsqA 8C+r/tqxuyxR5TAIC6Vi0//F/xr6D5XWhbz+1tdkV2ApDqQ0WYZXqamWUYxpb5d6+QKx guAPtxsIjSTyhH9CGhZebPGlZhS+cZhWG9CJC/caRHAgw1jcfaEMil6zm0ISUMwp86oq bbug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=7hxUw3CCQIsMDyCrcMAySZ3boqNN1iI86S85abS8aAU=; b=S03C1rPFo7RaVybSfAvSV7pzUfuWJnGj8J8aD0W7sh0prJl3Y1VTDSZUTTCJgewL+H LcPw9MOKx0xy6pTNbr5zjINYiV7YyUi29ckryRb4pzVmyDdP4eXLyqG9QeRU6eo0+oRf ULJ0No5k6O0EcOva5H3OVzuqODE2N7hEVth0IaAVs6zG91CfQocZ6E3LxHHQb1s2aT4M 3C3ydziISxrONdTBItARD72vQIDXtur9an8wVCStT3ZT7HC0YCuqAG0MouAjdniSFGkm 0F7m4Lao1imubp1Nd5OFdOzyq3ZlfRq/mtbC3hkO9IkWjJrv5cwrqUJtkXxe7OlpDSwS xZKw== X-Gm-Message-State: ALoCoQm8BxOfi/QPdxi+ZzGxI2fvX5F9BMdBqqXd3NVVrF9cBQNy+aVMwJqkWbjbqs0JhEyQnjBovpOSOQp7jfMYqKLl/Losf6xvp1gbXfSFNunlpqy+IbE= MIME-Version: 1.0 X-Received: by 10.98.87.196 with SMTP id i65mr20826507pfj.72.1452934405703; Sat, 16 Jan 2016 00:53:25 -0800 (PST) Received: by 10.66.147.10 with HTTP; Sat, 16 Jan 2016 00:53:25 -0800 (PST) In-Reply-To: <20160115060348.GR19531@yliu-dev.sh.intel.com> References: <1452778117-30178-1-git-send-email-sshukla@mvista.com> <1452778117-30178-8-git-send-email-sshukla@mvista.com> <20160115060348.GR19531@yliu-dev.sh.intel.com> Date: Sat, 16 Jan 2016 14:23:25 +0530 Message-ID: From: Santosh Shukla To: Yuanhan Liu Content-Type: text/plain; charset=UTF-8 Cc: dev@dpdk.org, Rakesh Krishnamurthy , Rizwan Ansari Subject: Re: [dpdk-dev] [PATCH v4 07/14] virtio: vfio: add api support to rd/wr ioport bar X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Jan 2016 08:53:26 -0000 On Fri, Jan 15, 2016 at 11:33 AM, Yuanhan Liu wrote: > On Thu, Jan 14, 2016 at 06:58:30PM +0530, Santosh Shukla wrote: >> For vfio case - Use pread/pwrite api to access virtio >> ioport space. >> >> Signed-off-by: Santosh Shukla >> Signed-off-by: Rizwan Ansari >> Signed-off-by: Rakesh Krishnamurthy >> --- > ... >> +/* vfio rd/rw virtio apis */ >> +static inline void ioport_inb(const struct rte_pci_device *pci_dev, >> + uint8_t reg, uint8_t *val) > > Minor nit: dpdk perfers to seperate return type and function name in > different line: > > static inline void > ioport_inb(....) > { > ok. >> +{ >> + if (rte_eal_pci_read_bar(pci_dev, (uint8_t *)val, sizeof(uint8_t), reg, > ^^^^^^^^^^^ > > Unnecessary cast; and few more belows. > yes, > --yliu