From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f172.google.com (mail-pf0-f172.google.com [209.85.192.172]) by dpdk.org (Postfix) with ESMTP id 935B293C0 for ; Tue, 2 Feb 2016 07:02:12 +0100 (CET) Received: by mail-pf0-f172.google.com with SMTP id 65so97221559pfd.2 for ; Mon, 01 Feb 2016 22:02:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mvista-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=Zc/g0lO1T5zvzi7RALbSQEKDLEAIjNjSAAD0eOnLQPQ=; b=kk0gQwhASbnIefwe+1tFiIiAtDtaaQbmoF1ki7GTnLm16yBDZaLIF8vX1mbHw4wMsw QVmS5bAfOPPxSMCH1iSarOEgxUXtyfpgVZh6CPw7q2z28zEHRNHrT0wj7u3YWpYjJy/g Ao0asVWqbibWMR57r3EpPeLK0FrPEb4ki0G06o0htiIG7QuCnRfKprPUV5cS+y0Z/A/4 0VfFYdV8ot5GgcgRESizrufYujTrwq27Nf3DBsyfrSNn3jx7+9vszDdj92Smkp3gOlnu PKH4QOtRblQvDpqxAu15hlrhYLbs8hL98rgVMhEcynFHqWuAZNuA7j7UHbBx2i8Gyryw kgkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=Zc/g0lO1T5zvzi7RALbSQEKDLEAIjNjSAAD0eOnLQPQ=; b=YNhoMghoksjo71l2+IsPO0prB+v13DGEiWUpTOnwpFHiGZiKnhOK4XEqULNjMEptoN 2CG0IH292arXwRcCFdyzvWUHI1ow/MWkl7e/OaUTee8M633gDcVIGpz9FWGP2eWFk6if pvvAm2LJFiybHyRz+G4aj1MNf3Mb0Mo+/zGDbFvRZwl4u0vUzs8WOUXwMwYsa02nbuIT JtGyXy+EzpjbwY8G4/PWC5wBRD46tEds5fOn/tK2toNWeo7SgMz4fqA6taHpqVGzdq/M SAaUj/09PJ+YV3Yog5U+dirXOMKBvl2KsZEvWRGE4lrnJPai+UNIf0lUQ+0vNfvvXZyT fHzA== X-Gm-Message-State: AG10YOScGxLMU05fcywNjOqn6p8Rd44PgfOnBH1b1R4znXQXo/wCx40dse0+DbcUrMpuet/udUELxDvV2SIZRTYZ MIME-Version: 1.0 X-Received: by 10.98.34.198 with SMTP id p67mr35074176pfj.93.1454392932017; Mon, 01 Feb 2016 22:02:12 -0800 (PST) Received: by 10.66.12.132 with HTTP; Mon, 1 Feb 2016 22:02:11 -0800 (PST) In-Reply-To: <20160202051912.GH4257@yliu-dev.sh.intel.com> References: <1454091717-32251-1-git-send-email-sshukla@mvista.com> <1454091717-32251-6-git-send-email-sshukla@mvista.com> <20160201124845.GC4257@yliu-dev.sh.intel.com> <20160202051912.GH4257@yliu-dev.sh.intel.com> Date: Tue, 2 Feb 2016 11:32:11 +0530 Message-ID: From: Santosh Shukla To: Yuanhan Liu Content-Type: text/plain; charset=UTF-8 Cc: dev@dpdk.org, Rakesh Krishnamurthy , Rizwan Ansari Subject: Re: [dpdk-dev] [PATCH v6 6/8] virtio: add vfio api to rd/wr ioport space X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Feb 2016 06:02:13 -0000 On Tue, Feb 2, 2016 at 10:49 AM, Yuanhan Liu wrote: > On Tue, Feb 02, 2016 at 10:00:36AM +0530, Santosh Shukla wrote: >> > >> > BTW, I didn't follow the noIOMMU discussion; how did it end? Do we still >> > need that? Is this patch a full story to enable virtio on ARM? >> > >> Ok, We agreed that explicit __noiommu suffix not required, atleast for >> rte_xx_drv struct{}, as because sooner than later we'll have virtio >> working for both flavours ie... iommu/noiommu. My only worry was >> parsing for _noiommu and default vfio case, as because noiomu needed >> user to preset "enable_noiommu_" param for vfio driver to do mode >> switch. But we wont need that parsing as because if param is not set >> then binding won't happen, which Thomas rightly pointed out, therefore >> I choose to drop resource parsing for virtio-for-vfio case, now virtio >> driver to check only drv->kdrv == RTE_KDRV_VFIO so to make sure >> interface attached to vfio or not. >> >> But perhaps when we have both flavours working for virtio, then we >> should at least prompt a INFO message on console that virtio pmd >> driver attached to default vfio or noIOMMU. >> >> So we don't need explicit _noIOMMU. > > Thanks for the explanation. >> >> Yes this patch is to enable non-x86 arch to use virtio pmd driver >> (virtio 0.95 spec). After this patch merges-in, I am planning to >> - replace sys/io.h entirely > > Hmm, be more specific? Replace it with what? > Just to remove ifdef clutter in general from dpdk source and mo >> - Add raw_read/raw_writel() api for arm/arm64 {Already proposed >> similar implementation in v2} so that they could use virtio 1.0spec >> mapped memory, for both UIO/VFIO mode. > > PCI memory bar mapping works both with UIO/VFIO on ARM, without > any extra efforts, right? If so, it should just work with my > patch set and yours. > Mostl likely, That I have not tried. (todo), > --yliu