From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f173.google.com (mail-pf0-f173.google.com [209.85.192.173]) by dpdk.org (Postfix) with ESMTP id 651229ABA for ; Tue, 1 Mar 2016 11:07:23 +0100 (CET) Received: by mail-pf0-f173.google.com with SMTP id 4so31856427pfd.1 for ; Tue, 01 Mar 2016 02:07:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mvista-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=z0QXyHsn+rNCAwOrb7UM8LqcER3NdtJ8PKyeRwGz5HY=; b=kxM0ZUuiujJs2qKXg2xZBnIyv571Uz0dCspkHMoOEQPfDNqndtvbZROyG7dq6Mrs9Q 2CoihZSvqyk7Wi3ALq78rThE8slmlk875wdoA7/uRLcranfrRdamZurzXHL2x7u97w2X TTAEIg0xQ1+sCAYpTS+ryfHboeuoSZi9W9S2qSBs5l3cB3z7Vghk/dlJfmvleGh0msOP r9Er1rDVkz27Nru7xvcMQau2m23j8bv0Y0vGwF5wjJvXAqLaPknAE9NAToQBCM3IoT6U r1bJN+HYT/FNhg4xFfY+6WxiHWG/S6u81b9BZQOmwGKrKw12bkJoUwQCmQDr5lXw11Ow z67w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=z0QXyHsn+rNCAwOrb7UM8LqcER3NdtJ8PKyeRwGz5HY=; b=mMC2v8QcGtO9cPssD6mRVG0XQEnQjMzs+pAQABWAxqHiscZHIyJ9kchB4jNzK88p3+ nBRY0uvITxRUAMMzygCprcOtaqVzRGxSOgq9LZ7w0L7xMfcKDPBUWD///yqWAih7v7G5 zbqpaPGfrd4V6KzwkVjx2SBaWqP8YEg0t4QN7cGY+Afhn/P8ZKmGaFcrpN5oteKg/knF 4vUiD5EMj3D/oHkhcPmkHr6Uj/dqMUbq5S26gTeluu1gk+AmVt+fTld5T25yNxmOwnGd /NNqiV5r/DfPBINffY10wzciBhEiIDgylvsZ06xENeTsKgqlqZxy8cSZQWM1bSS9JpZE zMQQ== X-Gm-Message-State: AD7BkJKefi02XpOWIv6qdl63H8usUQr6TIAsPw4hvT0zizL0aQo7ahTBwfnSgJWdh6XMVnxG0fyBBIXVYL5JKrVP MIME-Version: 1.0 X-Received: by 10.98.0.11 with SMTP id 11mr29348431pfa.5.1456826842825; Tue, 01 Mar 2016 02:07:22 -0800 (PST) Received: by 10.66.176.200 with HTTP; Tue, 1 Mar 2016 02:07:22 -0800 (PST) In-Reply-To: <20160301063201.GP14300@yliu-dev.sh.intel.com> References: <1456476662-23081-1-git-send-email-sshukla@mvista.com> <1456750690-3210-1-git-send-email-sshukla@mvista.com> <20160301055911.GM14300@yliu-dev.sh.intel.com> <20160301063201.GP14300@yliu-dev.sh.intel.com> Date: Tue, 1 Mar 2016 15:37:22 +0530 Message-ID: From: Santosh Shukla To: Yuanhan Liu Content-Type: text/plain; charset=UTF-8 Cc: dpdk Subject: Re: [dpdk-dev] [PATCH v2] virtio: Use cpuflag for vector api X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Mar 2016 10:07:23 -0000 On Tue, Mar 1, 2016 at 12:02 PM, Yuanhan Liu wrote: > On Tue, Mar 01, 2016 at 11:38:55AM +0530, Santosh Shukla wrote: >> On Tue, Mar 1, 2016 at 11:29 AM, Yuanhan Liu >> wrote: >> > On Mon, Feb 29, 2016 at 06:28:10PM +0530, Santosh Shukla wrote: >> >> Check cpuflag macro before using vectored api. >> >> -virtio_recv_pkts_vec() uses _sse3__ simd instruction for now so added cpuflag. >> >> - Also wrap other vectored freind api ie.. >> >> 1) virtqueue_enqueue_recv_refill_simple >> >> 2) virtio_rxq_vec_setup >> >> >> >> - removed VIRTIO_PMD=n from armv7/v8 config. >> >> >> >> todo: >> >> 1) Move virtio_recv_pkts_vec() implementation to >> >> drivers/virtio/virtio_vec_.h file. >> >> 2) Remove use_simple_rxtx flag, so that virtio/virtio_vec_.h >> >> files to provide vectored/non-vectored rx/tx apis. >> >> >> >> Signed-off-by: Santosh Shukla >> >> --- >> >> - v2: Removed VIRTIO_PMD=n from arm v7/v8 >> > >> > Firstly, I would not suggest you to send another new version, while there >> > still was discussions ongoing on old version. >> > >> > And, you should not mix the ARM stuff here; this patch should only do >> > what the patch title tells. In generic, don't do two or more things in >> > one patch. >> > >> >> w/o v2 patch, old version wont build for armv7/v8. Clubbing both in >> v2, inspired from v7 virtio INC_VEC review comment/feedback [1]. > > Thinking it this way, that build won't work for ARM, with or without > this patch. And this patch just fix a build error for platforms that > doesn't has vec instructions (which could include old x86 platforms). > > So, the right way to go is to separate the ARM stuff to another > standalone patch, claiming that we now supports ARM. > > Makes sense to you? > Sent a new patch series. Incorporated comments in this thread http://dpdk.org/dev/patchwork/patch/10945/ http://dpdk.org/dev/patchwork/patch/10946/ > BTW, is this the last piece of code to make virtio for ARM work? > I maybe wrong, but I remembered you have few more patches for virtio > in old versions. (Yeah, I'm aware of that the EAL parts have been > merged) > > Anyway, here is a remind: don't forget to update release note: > > doc/guides/rel_notes/release_16_04.rst > Posted a patch just now: http://dpdk.org/dev/patchwork/patch/10947/ > --yliu >