From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sshukla@mvista.com>
Received: from mail-pa0-f48.google.com (mail-pa0-f48.google.com
 [209.85.220.48]) by dpdk.org (Postfix) with ESMTP id 3510C56A1
 for <dev@dpdk.org>; Mon, 14 Dec 2015 17:16:44 +0100 (CET)
Received: by padhk6 with SMTP id hk6so65851458pad.2
 for <dev@dpdk.org>; Mon, 14 Dec 2015 08:16:43 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=mvista-com.20150623.gappssmtp.com; s=20150623;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=Mf9/eEqb4isH1BlgoGF+s7qblZk/SXzTDWs7JLIldHc=;
 b=xQlcd5Ye10F37T5XSwuT3qih8fbqH4uO5yVUjVEXW+FidIUaM45l6FbOWaQfK7QSAX
 pohzTud+AzUTnyokR41yfMaxwFtc9bWKM1Re7f6levYL9FwW4ZncjBVv1hnAqjB40E8Z
 rxac04Tbumh5Y334sZ/3wDBI99ppo4GNRTR++j66oxMu+Bd6dg8f5bVQ9ZxjSKCro8QS
 XnvLO8GQYDycoiFB02Ev5ZVcyhozmCehd+JKBTZnn/UIw6dNqlgU9jWHQlf/IKAHLlfV
 ezU+JT7EioCBKgPH8hnwFnaGogQVIf943YBie4cgAD8Qjl53Ihu+WhljtdwyTEy6k6LN
 Jjjw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:date
 :message-id:subject:from:to:cc:content-type;
 bh=Mf9/eEqb4isH1BlgoGF+s7qblZk/SXzTDWs7JLIldHc=;
 b=CTuATrS/dTaFLia7871B4Djjy9H0QYxmLQ4FlWmNC+swaNUJZV0dG4q6vSJppLF1dd
 ccSX3BeItHIlYvkzRno49HUY6nS+9P5J2MBkQFVYTXOIbt564wPApxm63tXVBfRfBmLM
 q1nhPzXOjepqOtEV8MDimm4U/o7MMH4dB+PEApbmOTRtVt+wWSS0JR4nM+dOOBehY28m
 vv10sKA759Zk+heNXMeOaQXTyt/DeGkyrTz4Nq1vyOTF5B2nOTh4HhEUM9jarh7Be9eh
 mdHQNPE9LJsUDNc9WAPcfv30SOyh0UsbYd5kqV/+ZzMOJGunvG/LMSuyAucinfxE1wu/
 8uLg==
X-Gm-Message-State: ALoCoQl0Iffnr5j/LRs3mQdZ67+xifu/gXkAlED6hYXOeElv4bilxVwNLfzcRZChQR+KoRNjil0t5tbaalZ1Z758TNUekiyG6sLJRjFkuaPjXKkAiGDEIlw=
MIME-Version: 1.0
X-Received: by 10.66.193.73 with SMTP id hm9mr47137100pac.117.1450109803552;
 Mon, 14 Dec 2015 08:16:43 -0800 (PST)
Received: by 10.66.13.233 with HTTP; Mon, 14 Dec 2015 08:16:43 -0800 (PST)
In-Reply-To: <20151214143128.GC30309@localhost.localdomain>
References: <1450098032-21198-1-git-send-email-sshukla@mvista.com>
 <1450098032-21198-7-git-send-email-sshukla@mvista.com>
 <20151214143128.GC30309@localhost.localdomain>
Date: Mon, 14 Dec 2015 21:46:43 +0530
Message-ID: <CAAyOgsamySnnUp_9ON-64hRn5nDTu8zYA7Hm4fWNt3wA4X7V7Q@mail.gmail.com>
From: Santosh Shukla <sshukla@mvista.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Content-Type: text/plain; charset=UTF-8
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [ [PATCH v2] 06/13] config: armv7/v8: Enable
	RTE_LIBRTE_VIRTIO_PMD
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Dec 2015 16:16:44 -0000

On Mon, Dec 14, 2015 at 8:01 PM, Jerin Jacob
<jerin.jacob@caviumnetworks.com> wrote:
> On Mon, Dec 14, 2015 at 06:30:25PM +0530, Santosh Shukla wrote:
>> Enable RTE_LIBRTE_VIRTIO_PMD for armv7/v8 and setting RTE_VIRTIO_INC_VEC=n.
>> Builds successfully for armv7/v8.
>>
>> Signed-off-by: Santosh Shukla <sshukla@mvista.com>
>> ---
>>  config/defconfig_arm-armv7a-linuxapp-gcc   |    6 +++++-
>>  config/defconfig_arm64-armv8a-linuxapp-gcc |    6 +++++-
>>  2 files changed, 10 insertions(+), 2 deletions(-)
>>
>> diff --git a/config/defconfig_arm-armv7a-linuxapp-gcc b/config/defconfig_arm-armv7a-linuxapp-gcc
>> index cbebd64..d840dc2 100644
>> --- a/config/defconfig_arm-armv7a-linuxapp-gcc
>> +++ b/config/defconfig_arm-armv7a-linuxapp-gcc
>> @@ -43,6 +43,11 @@ CONFIG_RTE_FORCE_INTRINSICS=y
>>  CONFIG_RTE_TOOLCHAIN="gcc"
>>  CONFIG_RTE_TOOLCHAIN_GCC=y
>>
>> +# VIRTIO support for ARM
>> +CONFIG_RTE_LIBRTE_VIRTIO_PMD=y
>> +# Disable VIRTIO VECTOR support
>> +CONFIG_RTE_VIRTIO_INC_VECTOR=n
>> +
>
> Enable the config at last in the patch series, so that it won't
> functionally break for arm/arm64 on this patch.
>

ok, we'll keep it at top in v3. Thanks

>>  # ARM doesn't have support for vmware TSC map
>>  CONFIG_RTE_LIBRTE_EAL_VMWARE_TSC_MAP_SUPPORT=n
>>
>> @@ -70,7 +75,6 @@ CONFIG_RTE_LIBRTE_I40E_PMD=n
>>  CONFIG_RTE_LIBRTE_IXGBE_PMD=n
>>  CONFIG_RTE_LIBRTE_MLX4_PMD=n
>>  CONFIG_RTE_LIBRTE_MPIPE_PMD=n
>> -CONFIG_RTE_LIBRTE_VIRTIO_PMD=n
>>  CONFIG_RTE_LIBRTE_VMXNET3_PMD=n
>>  CONFIG_RTE_LIBRTE_PMD_XENVIRT=n
>>  CONFIG_RTE_LIBRTE_PMD_BNX2X=n
>> diff --git a/config/defconfig_arm64-armv8a-linuxapp-gcc b/config/defconfig_arm64-armv8a-linuxapp-gcc
>> index 504f3ed..b3a4b28 100644
>> --- a/config/defconfig_arm64-armv8a-linuxapp-gcc
>> +++ b/config/defconfig_arm64-armv8a-linuxapp-gcc
>> @@ -45,8 +45,12 @@ CONFIG_RTE_TOOLCHAIN_GCC=y
>>
>>  CONFIG_RTE_CACHE_LINE_SIZE=64
>>
>> +# Enable VIRTIO support for ARM
>> +CONFIG_RTE_LIBRTE_VIRTIO_PMD=y
>> +# Disable VIRTIO VECTOR support
>> +CONFIG_RTE_VIRTIO_INC_VECTOR=n
>> +
>>  CONFIG_RTE_IXGBE_INC_VECTOR=n
>> -CONFIG_RTE_LIBRTE_VIRTIO_PMD=n
>>  CONFIG_RTE_LIBRTE_IVSHMEM=n
>>  CONFIG_RTE_LIBRTE_FM10K_PMD=n
>>  CONFIG_RTE_LIBRTE_I40E_PMD=n
>> --
>> 1.7.9.5
>>