From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sshukla@mvista.com>
Received: from mail-pa0-f41.google.com (mail-pa0-f41.google.com
 [209.85.220.41]) by dpdk.org (Postfix) with ESMTP id B56963195
 for <dev@dpdk.org>; Tue,  8 Dec 2015 16:35:54 +0100 (CET)
Received: by pacdm15 with SMTP id dm15so13666098pac.3
 for <dev@dpdk.org>; Tue, 08 Dec 2015 07:35:54 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=mvista-com.20150623.gappssmtp.com; s=20150623;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=/iLQFh/o0K8tzOqFqJLIy9JySBDUu8b9lpmcasI3YWI=;
 b=etAWZ9kjZQm59f4r3ox0MeY1RyuXWfQOEiCvdGsfH38+WT6kTqKKsqHnZYuV5Qs8y1
 sJePNdotHfDg+aKcF/0k/gKr92Rv49qM9nHD5KFDGP9k0RD9x2N44VzuqOa2Hcd130sF
 gZ1B0r9FkE/nJjOVrIsLiedv4vpESSgrn3lTzuH5Etn0ftzaCZb781xTdzh58haJwqw/
 n5Tc5hlV/x939Ebx/a+bibQn32NAKeyQLi/ybrjjCC2l3kvZYN2VMnGYPmKpUlUFWwbU
 eF5CiXvZCwnGhNSSU4pl6Jmx85TMJzoadhfP1rzX8sNUO5OIY+B1Ekes38WHCFnFld4F
 QZhA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:date
 :message-id:subject:from:to:cc:content-type;
 bh=/iLQFh/o0K8tzOqFqJLIy9JySBDUu8b9lpmcasI3YWI=;
 b=AZNCEN4+152X4CrRALm8fIMnDYT5OvimJKFuhrQJnpeKHTNbWeXN6v44W/Q7XhA/2l
 GYQME+U6VCHUTi3lwHfMV1G/+9Y740ivhJA2LUyB04j9T12nfMv5+ftsSucS2ZHJ2Vf3
 vtMB8Ooe5vDkcmR+1n04YGZhCIXIe+dzsPOtQvj9di4XgW3cpR/s0+1o7Vxg0A60s28G
 DwTsLkuDODjDPxzqb5sRKkgGU2CaIvDNFmmYrmhENc2P+nuaRrtIUZSwK9oAArLnrYlL
 tnrOymB/OLfwGI4C6wuA3LIVdjZ1x109ONgquI6ZxXrhUKb01aP+BK+1kMdN0J18FVWw
 nG0Q==
X-Gm-Message-State: ALoCoQlrgAZY/go4RQ7Vh8/qC/ScirYEz79pDwF+k83elng8tRMi5h57Gxx0rFBwKYcB89trwiRpe857eqBiW7wSMM3zuGnLYDyT91RYXXkLqwnAYy3KGcQ=
MIME-Version: 1.0
X-Received: by 10.66.193.73 with SMTP id hm9mr672027pac.117.1449588954137;
 Tue, 08 Dec 2015 07:35:54 -0800 (PST)
Received: by 10.66.13.233 with HTTP; Tue, 8 Dec 2015 07:35:54 -0800 (PST)
In-Reply-To: <20151207090936.32368531@xeon-e3>
References: <1449250519-28372-1-git-send-email-sshukla@mvista.com>
 <1449250519-28372-4-git-send-email-sshukla@mvista.com>
 <20151207090936.32368531@xeon-e3>
Date: Tue, 8 Dec 2015 21:05:54 +0530
Message-ID: <CAAyOgsb3OSNWQVBr9m+s+YCN8CXTc2pMHFJ0Jhs22ucuR7h1CA@mail.gmail.com>
From: Santosh Shukla <sshukla@mvista.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 3/6] virtio: armv7/v8: Introdice api to
 emulate x86-style of PCI/ISA ioport access
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Dec 2015 15:35:55 -0000

On Mon, Dec 7, 2015 at 10:39 PM, Stephen Hemminger <
stephen@networkplumber.org> wrote:

> On Fri,  4 Dec 2015 23:05:16 +0530
> Santosh Shukla <sshukla@mvista.com> wrote:
>
> > +#if defined(RTE_ARCH_ARM64)
> > +     uint64_t    io_base;
> > +#else /* !ARM64 */
> >       uint32_t    io_base;
> > +#endif
>
> Is there a typedef that could be used instead of having #ifdef clutter?
>

I am not sure if there is any for arm. Can you pl. point me any code
snippet (perhaps arch specific) example?

BTW: I am thinking to change io_base to word_size {arch size aligned} in v2
patch revision and By doing that we don't need care for ifdefs. Currently
uin32_t hold good for io;s ranging from 0 to 65535.

Wanted to keep something like below

unsigned long io_base;

for 32 bit case - 4 byte
for 64 bit case - 8 byte.

Does that make sense?