From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f48.google.com (mail-pa0-f48.google.com [209.85.220.48]) by dpdk.org (Postfix) with ESMTP id AC99A5A71 for ; Thu, 17 Dec 2015 13:18:49 +0100 (CET) Received: by mail-pa0-f48.google.com with SMTP id wq6so41798938pac.1 for ; Thu, 17 Dec 2015 04:18:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mvista-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=w/4TLdjeyDdK3BJ8dRPfOVVhgPdS+cIqPpDTc2WW2EA=; b=GVIoAVic5HWEabOuQFyKI17A7/O/HENtEsR9vLGccSHyfMQdsHmEEfm9+gaFuLA7WS EIveiDD1elJaJLpm64xHyxMWlb8t5BiT16ZbW9WCUyW6TasG2nqy2gMIj3A/rmUTcbgG blV4QvLRNGi1e1yb3MEOU7PZskXqlULmqb3/R6LWCB72hDhnHXQCOI9hxYjt96aUFz7z hKhWjWyLnY8Ce9ZRKHq1UuRcepbph0XnGljslrVztpPZKgWicAAmQ+EwUw4aDCKh+fUR gGHFGYoAFMd10eRWP0kKnSNo1mp/80762GldEmrUKxArh1+5MG/Rn+JBz47+hLYg9Tzz j7iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=w/4TLdjeyDdK3BJ8dRPfOVVhgPdS+cIqPpDTc2WW2EA=; b=iYESOG0o3MWCajcn6FkB3Y7Szs+huDVoD2nDzrsWYI9LPtVGdlQr8lpVuezSdYJYjz W1WL58ucUZeHHcrvsggBhhbxIuazflfmdfvsgSnowKBNkhVh8V2urIfame8n0xiNhBrD AApxJJkQVrlPQo4P+OKHAwwJp8dH7pFQtcPUSig4lDrWErhGsgGpflTyR7M+b6Ar/H+H 7DexlEtaUumCS9b/6mCUGh8gVq0TcJJ4iabnwN5LQMAefR3cRqUdKeMUklj35IdSAsEI AAOR/VlKkQycky7KWNCqPrxcgfkCC3pe/DftBMXzcF///1BQtnDDa0yLNmsYKDTF4iOY nWMQ== X-Gm-Message-State: ALoCoQmVEpfaTMmvU5C90m8Ccb9teSZEQlmo9TQ/XP6VNAEV8rEtqV+30AkTSvi5cijH+HEzXGepyyWhm0vX7h1sv40ms6/pHwZ1xAT2SHD+cGgpFCrclwU= MIME-Version: 1.0 X-Received: by 10.66.193.73 with SMTP id hm9mr71738700pac.117.1450354728859; Thu, 17 Dec 2015 04:18:48 -0800 (PST) Received: by 10.66.13.233 with HTTP; Thu, 17 Dec 2015 04:18:48 -0800 (PST) In-Reply-To: <2955349.3QHN8DHquR@xps13> References: <1450098032-21198-1-git-send-email-sshukla@mvista.com> <1450098032-21198-2-git-send-email-sshukla@mvista.com> <2955349.3QHN8DHquR@xps13> Date: Thu, 17 Dec 2015 17:48:48 +0530 Message-ID: From: Santosh Shukla To: Thomas Monjalon Content-Type: text/plain; charset=UTF-8 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [ [PATCH v2] 01/13] virtio: Introduce config RTE_VIRTIO_INC_VECTOR X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Dec 2015 12:18:50 -0000 On Thu, Dec 17, 2015 at 5:33 PM, Thomas Monjalon wrote: > 2015-12-17 17:32, Santosh Shukla: >> On Mon, Dec 14, 2015 at 6:30 PM, Santosh Shukla wrote: >> > virtio_recv_pkts_vec and other virtio vector friend apis are written for sse/avx >> > instructions. For arm64 in particular, virtio vector implementation does not >> > exist(todo). >> > >> > So virtio pmd driver wont build for targets like i686, arm64. By making >> > RTE_VIRTIO_INC_VECTOR=n, Driver can build for non-sse/avx targets and will work >> > in non-vectored virtio mode. >> > >> > Signed-off-by: Santosh Shukla >> > --- >> >> Ping? >> >> any review / comment on this patch much appreciated. Thanks > > Why not check for SSE/AVX support instead of adding yet another config option? Ok, keeping a check for sse/avx across the patch wont stand true for future virtio vectored implementation lets say for arm/arm64 cases i.e.. sse2neon types. That implies user suppose to keep on appending / adding checks for see2neon for example and so forth. On other hand, motivation of including INC_VEC config was inspired from IXGBE and other pmd drivers who support vectored sse/avx _rx path and also could work w/o vectored mode. Current virtio is missing such support and arm dont have vectored sse2neon types implementation right now so its a blocker for arm case. Also keeping virtio pmd driver flexible enough to work in non-vectored mode is a requirement/ a feature.