From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f52.google.com (mail-pa0-f52.google.com [209.85.220.52]) by dpdk.org (Postfix) with ESMTP id 1321C8DB3 for ; Sat, 16 Jan 2016 07:18:40 +0100 (CET) Received: by mail-pa0-f52.google.com with SMTP id cy9so405688243pac.0 for ; Fri, 15 Jan 2016 22:18:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mvista-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=HSSwcjBIgpE2zevtV3cNhd0zrSSlGlWGIcYhPjioxUw=; b=t7lkPWqzp+vLkxdvKZ9WxljvlsKV97T/Zl6VDjzdTsIceLFJaCOGVBtwHXvizHFo1v wM0Rl7OMykcspI6YU4DZzfQh3LA/Vq/3PZbn/fXmVBIKpMchjHN1CvrP+Helm6j8oRLI AmFebg2XcCUIwUt6ym7XqqV9Oym2C1mOkYf3hIOCDt1K7b5qdikt3bajFGRaUWn0a8Jb kzpylWjKGmqn4CywReFxI9YiETqEXPoQyDDNZPII1oqNLLUoxFLgcRoX0NtMWQB+ttCz i+v6xmBaiqBiYioKpX2TvUN5r4M7YRfDg0ie97FrDMkREFXAua74CcGaReHp2ZS6UVey vrfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=HSSwcjBIgpE2zevtV3cNhd0zrSSlGlWGIcYhPjioxUw=; b=adetMs2v9n2RL86AB4Z3YKBZsFE4OnC0+b4Dv2k/kMkM2ukRhHnWlRndu6wN/Yk9oZ w36krmgIGDtZvbP3Io9M7/OcX0XmmpX/OrmX+jmumGI9145oBT+sP62hgfnRbNJ5XovD rY4jB5JSPurqYZxveB0B2xwbWafRXv7jKJKcMYDhT3xMcCW0OEvAIOk5DTvEuo0HpWqV Gj28eLSCfYFakW9utI/yhLKn72MbbGxCX/a0YPqWNMR8eKErvkaj60eKf5T0RmzB8wxw a/s8JUuwSaY+lHk5MlTvH+B/HCxmd7MUG0xcGNiSPDYmDhNB7bn409freFEUgoiuMuAW f5yw== X-Gm-Message-State: ALoCoQl+sKJz1NpqrXJuEYERiyk4H+3aysAmfc/9s7zNpH+0VWoGsiAuV0t4G4dg63OvVcBF/4eUB88MMzA2AUPevJdbkh6nWwDsKB57Tfv8ZJO5saO12O8= MIME-Version: 1.0 X-Received: by 10.67.5.228 with SMTP id cp4mr20410822pad.29.1452925119419; Fri, 15 Jan 2016 22:18:39 -0800 (PST) Received: by 10.66.196.81 with HTTP; Fri, 15 Jan 2016 22:18:39 -0800 (PST) In-Reply-To: <20160115065107.GV19531@yliu-dev.sh.intel.com> References: <1452778117-30178-1-git-send-email-sshukla@mvista.com> <1452778117-30178-2-git-send-email-sshukla@mvista.com> <20160115065107.GV19531@yliu-dev.sh.intel.com> Date: Sat, 16 Jan 2016 11:48:39 +0530 Message-ID: From: Santosh Shukla To: Yuanhan Liu Content-Type: text/plain; charset=UTF-8 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v4 01/14] virtio: Introduce config RTE_VIRTIO_INC_VECTOR X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Jan 2016 06:18:40 -0000 On Fri, Jan 15, 2016 at 12:21 PM, Yuanhan Liu wrote: > On Thu, Jan 14, 2016 at 06:58:24PM +0530, Santosh Shukla wrote: >> virtio_recv_pkts_vec and other virtio vector friend apis are written for sse/avx >> instructions. For arm64 in particular, virtio vector implementation does not >> exist(todo). >> >> So virtio pmd driver wont build for targets like i686, arm64. By making >> RTE_VIRTIO_INC_VECTOR=n, Driver can build for non-sse/avx targets and will work >> in non-vectored virtio mode. > > While revisiting this patch, I'm thinking you may squash both patch 2 > and patch 11 into this one. > Make sense!, we'll do in v5. >> >> Signed-off-by: Santosh Shukla >> --- >> config/common_linuxapp | 1 + >> drivers/net/virtio/Makefile | 2 +- >> drivers/net/virtio/virtio_rxtx.c | 7 +++++++ >> 3 files changed, 9 insertions(+), 1 deletion(-) >> >> diff --git a/config/common_linuxapp b/config/common_linuxapp >> index 74bc515..8677697 100644 >> --- a/config/common_linuxapp >> +++ b/config/common_linuxapp >> @@ -274,6 +274,7 @@ CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_RX=n >> CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_TX=n >> CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_DRIVER=n >> CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_DUMP=n >> +CONFIG_RTE_VIRTIO_INC_VECTOR=y >> >> # >> # Compile burst-oriented VMXNET3 PMD driver >> diff --git a/drivers/net/virtio/Makefile b/drivers/net/virtio/Makefile >> index 43835ba..25a842d 100644 >> --- a/drivers/net/virtio/Makefile >> +++ b/drivers/net/virtio/Makefile >> @@ -50,7 +50,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_VIRTIO_PMD) += virtqueue.c >> SRCS-$(CONFIG_RTE_LIBRTE_VIRTIO_PMD) += virtio_pci.c >> SRCS-$(CONFIG_RTE_LIBRTE_VIRTIO_PMD) += virtio_rxtx.c >> SRCS-$(CONFIG_RTE_LIBRTE_VIRTIO_PMD) += virtio_ethdev.c >> -SRCS-$(CONFIG_RTE_LIBRTE_VIRTIO_PMD) += virtio_rxtx_simple.c >> +SRCS-$(CONFIG_RTE_VIRTIO_INC_VECTOR) += virtio_rxtx_simple.c >> >> # this lib depends upon: >> DEPDIRS-$(CONFIG_RTE_LIBRTE_VIRTIO_PMD) += lib/librte_eal lib/librte_ether >> diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c >> index 74b39ef..23be1ff 100644 >> --- a/drivers/net/virtio/virtio_rxtx.c >> +++ b/drivers/net/virtio/virtio_rxtx.c >> @@ -438,7 +438,9 @@ virtio_dev_rx_queue_setup(struct rte_eth_dev *dev, >> >> dev->data->rx_queues[queue_idx] = vq; >> >> +#ifdef RTE_VIRTIO_INC_VECTOR >> virtio_rxq_vec_setup(vq); >> +#endif > > You should put such macros for the declaration in virtio_rxtx.h as well. > > > And note that you may miss one: > > > 325 /****************************************** > 326 * Enqueue allocated buffers * > 327 *******************************************/ > 328 if (use_simple_rxtx) > ==> 329 error = virtqueue_enqueue_recv_refill_simple(vq, m); > 330 else > 331 error = virtqueue_enqueue_recv_refill(vq, m); > 332 if (error) { > 333 rte_pktmbuf_free(m); > 334 break; > 335 } > > > virtqueue_enqueue_recv_refill_simple() is defined inside virtio_rxtx_simple.c, > which is built only when CONFIG_RTE_VIRTIO_INC_VECTOR is set. But I see no > such check here. > > Note that this will not break the build, as gcc just ignores it, for use_simple_rxtx > is 0 by default, thus the "if" part code is not compiled at all. Even for that, > I think it's better to put an explicit macro check here. > we'll make changes in v5, Thanks for review comment. > --yliu