From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f175.google.com (mail-pf0-f175.google.com [209.85.192.175]) by dpdk.org (Postfix) with ESMTP id 6943A567A for ; Sun, 17 Jan 2016 15:07:08 +0100 (CET) Received: by mail-pf0-f175.google.com with SMTP id q63so147530382pfb.1 for ; Sun, 17 Jan 2016 06:07:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mvista-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=beK3jLrsS4tiyljbadRNdB0jPPC8gzf1Zw3Xxba+8BA=; b=nMs7tzPTZJqwJExI4AnVNdE41O+5OeNGhdEA0VrLER1M1TPvhx1yLcGpy9jxQRC5qN LTlpNmetxU/fPAz1sFVTsgerHkX8V+Iehp2Ul80O9K5vz/xG52uLUCscY3NbnJpq5Mch 7hj1pJAQmQqVT9OC/88y6IhpteLbjLZHLqRswus22Wxil5EMZC2sjViXVxFbA6Sop7Ba pq3W16AStNEH2tlaHQeEZhPYOb8s8eseRDjjoekoaVa/5NjWWOttVHYTee90WYXVmUiF ToUmKsCgmkhT3wQmByRg7c5vdI3OEQs3B0QiyYsu92apXFGsWkh3hVP/byn7mc904ucI xqvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=beK3jLrsS4tiyljbadRNdB0jPPC8gzf1Zw3Xxba+8BA=; b=UHAH2IFiH29/QHnS4jtdbIHRWQy+o7jiQT7j2b32ZOY2aBS1y78H4sgBAGPK5R5wU6 4MJx3bdKpYD7t2LEp2n2BGMN92Q9nSgSCJpecIe1a/BZRty7igRN5PLeinRTGmrS3XG8 prBctygzWnTfjNvP8MXX8CWQhHUmfQBsoqh3KaUOugjzr5wFm6oWL3Qoe1IrUFxl9n4F 1VurBt6WwBSjGXXvUGEYVzIvcQJIodFjvWx5vHty+BFUJ0Te+BXkvkFdWkL9v/2z9LAl SmBVYLybLEm3u1uUjHZ1Ewc4g+L1sGWeOyKH1QigiLnQ2T+soiXJyrfy6nT12X6bkVOp uuIA== X-Gm-Message-State: ALoCoQmj/2Y9PiNnPsRD6j8xOcUNPtSSQI/+oLcGgxYZs/4CBFwHpxYydnCZQ77It2wgjZQqYt2M/kweqGPENR2mkTbm6sApBN5eQ1tdxY/u8vik5ZrF/bc= MIME-Version: 1.0 X-Received: by 10.98.86.8 with SMTP id k8mr28770219pfb.28.1453039627693; Sun, 17 Jan 2016 06:07:07 -0800 (PST) Received: by 10.66.196.81 with HTTP; Sun, 17 Jan 2016 06:07:07 -0800 (PST) In-Reply-To: References: <1452581944-24838-1-git-send-email-yuanhan.liu@linux.intel.com> <1452757372-686-1-git-send-email-yuanhan.liu@linux.intel.com> <1452757372-686-9-git-send-email-yuanhan.liu@linux.intel.com> Date: Sun, 17 Jan 2016 19:37:07 +0530 Message-ID: From: Santosh Shukla To: Yuanhan Liu Content-Type: text/plain; charset=UTF-8 Cc: dev@dpdk.org, "Michael S. Tsirkin" Subject: Re: [dpdk-dev] [PATCH v3 8/8] virtio: move VIRTIO_READ/WRITE_REG_X into virtio_pci.c X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Jan 2016 14:07:08 -0000 On Sat, Jan 16, 2016 at 3:38 PM, Santosh Shukla wrote: > On Thu, Jan 14, 2016 at 1:12 PM, Yuanhan Liu > wrote: >> virtio_pci.c become the only file references those macros; move them there. >> > > My patch VFIO series need virtio_rd/wr So keeping these api in > virtio_pci.h make more sense to me. Ignore my comment, I just finished reading your patch series and wont see any potential issue in moving my vfio rd/wr api to vfio_pci.c.