From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sshukla@mvista.com>
Received: from mail-pa0-f52.google.com (mail-pa0-f52.google.com
 [209.85.220.52]) by dpdk.org (Postfix) with ESMTP id E350DC576
 for <dev@dpdk.org>; Fri, 29 Jan 2016 08:22:53 +0100 (CET)
Received: by mail-pa0-f52.google.com with SMTP id ho8so37005199pac.2
 for <dev@dpdk.org>; Thu, 28 Jan 2016 23:22:53 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=mvista-com.20150623.gappssmtp.com; s=20150623;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=PhRsI99S2qank1JOMaqf2JKddh+XHT0ImU8kKZFtoBg=;
 b=pwrpf+9uTCEmMyg2I3kp6LBLHjbmI+iJQuwdUxwu8AVdGYqFh1+Ke3dgvPzePRI+KO
 nng32v79gQAa3bdifwoqMMRue4BsdheqOZ2EoW7kMyepoziNxV9kwpNYP39tv49XToKY
 LSw4YksfyiVONL7lGHwpchP40gx2wihD0cXHGlYZ6ZcY+FThGRp5l1/URDH+mGYYKnhe
 9aO+RWcRxL0B/vtY62nQgKqX5G8CHXqQF2aBPdAx/w5m42hPF9ElIDeuG95CFTGw5r07
 zbnK6SK6e/1qLkbY++ymALWNk7DIpK97heb7aJj8SVhVsW8WQDRpXQKcbMuGsNcslCVx
 M/Xw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:date
 :message-id:subject:from:to:cc:content-type;
 bh=PhRsI99S2qank1JOMaqf2JKddh+XHT0ImU8kKZFtoBg=;
 b=P59dledyb28V6HjRJkmabmjLp7Q0s/oQMw2sYLZv53Arbc7b3adv8Gi0AKBMuXrsvF
 kxzyH27/bChexSMGgtzvRrbcCgoV5AVzZvX1fbhpJ70pBcg/H5eiPQq3YTalmpW+kFGB
 p/rls4NpwFivP4aNVBCJIE1CsyBFY/sZzIJtGD7rq+Tq+quMRnHjo81ZYU+jPMq8KOIz
 YWc3J30B90Gw2th+PDg93vBNbDFsXqrm1fL4Ew0CKEPlcyVeguVTGC7zuvcrvrIdu2R2
 n2K2/H0pp9xOId57qJ4KU5FIW1aNgsVeBJnmsEbaDJWoDlw0Faz6TU3R7ZwQqAcsBLQe
 Af7Q==
X-Gm-Message-State: AG10YOQfRUeK1WDlNHLg2C1ju6nRCtsYx63c+yG73cRkec+5sTMi6bpYZ2O0kdS+M1iQYmNHEZF2Fgl+Z0Mow/2L
MIME-Version: 1.0
X-Received: by 10.66.252.42 with SMTP id zp10mr11219505pac.29.1454052173356;
 Thu, 28 Jan 2016 23:22:53 -0800 (PST)
Received: by 10.66.196.81 with HTTP; Thu, 28 Jan 2016 23:22:53 -0800 (PST)
In-Reply-To: <20160129071717.GQ4257@yliu-dev.sh.intel.com>
References: <1453203972-24855-1-git-send-email-sshukla@mvista.com>
 <1453203972-24855-10-git-send-email-sshukla@mvista.com>
 <20160129071717.GQ4257@yliu-dev.sh.intel.com>
Date: Fri, 29 Jan 2016 12:52:53 +0530
Message-ID: <CAAyOgsbW2pJxuPou61raqi2bqoOkM12-F_oZ5tS0VR7G-T_+gw@mail.gmail.com>
From: Santosh Shukla <sshukla@mvista.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Content-Type: text/plain; charset=UTF-8
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v5 09/11] virtio_pci: do not parse if
	interface is vfio-noiommu
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Jan 2016 07:22:54 -0000

On Fri, Jan 29, 2016 at 12:47 PM, Yuanhan Liu
<yuanhan.liu@linux.intel.com> wrote:
> Two minor nits.
>
> Firstly about your title, you should be consistent: sometimes you
> use virtio_pci, and sometimes you use virtio_pic.h. And for virtio
> pmd driver, "virtio: " prefix is pretty enough, no need another
> extra "vfio: " or "pci: " prefix.
>
> And the same to your EAL changes. EAL is a bigger, having more
> components, thus sometimes 2 prefixs are used. And if you are
> not sure how to add prefix, dig the git history to get the answer.
>
> On Tue, Jan 19, 2016 at 05:16:10PM +0530, Santosh Shukla wrote:
>> If virtio interface attached to vfio-noiommu driver then
>> do not parse for virtio resource. Instead exit with return 0;
>>
>> Note: Applicable for virtio spec 0.95.
>
> And this is not necessary: io port stuff is for virtio 0.95 only.
> virtio 1.0 won't use that, at all.
>

Okay,

I removed [08/11] patch from v5 series and modified this patch
accordingly [1]. So, ignore this patch and pl. review provided link.

[1] http://dpdk.org/dev/patchwork/patch/10143/

>         --yliu