From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f43.google.com (mail-pa0-f43.google.com [209.85.220.43]) by dpdk.org (Postfix) with ESMTP id E0E1D9599 for ; Wed, 27 Jan 2016 11:37:37 +0100 (CET) Received: by mail-pa0-f43.google.com with SMTP id cy9so2910658pac.0 for ; Wed, 27 Jan 2016 02:37:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mvista-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=fMcjZXrckcq7FRERPrKEs9vgYnWM8C38u1gthbYT6CE=; b=L3lRYjd1RpimSwZiHLg9v58ZL6inAgwcavMrzZoQurrdNMBniCcsjBDjZtXsJp6IuV v9jQr23ShUoM3DspORiYSyr+epjDqXA1g7MNOemvXno0z6LrS9EOZtHm7BPcL/dZv/86 x6bJQyypVWlm5aKH8Pq9tcZZns1GlOcIhy/lAc9jXN/HdSjfaALxIrOrlcglzYV7JIrO 43r+RzOUiphdxmF0GXyYKeYBSPlUxB5c8/iXgV9uzOHPyEQaYHmF6gSmTG/3d6Yi127I ENcxrYrw+Re4F8Zn8DSYse+fP5B3rtJNE4b2/QX0DvEqb7sE66ChSOGUQVi60DmiOyxh v0JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=fMcjZXrckcq7FRERPrKEs9vgYnWM8C38u1gthbYT6CE=; b=Qc3AP1Xy3fD0vOZF44JV8Yg4Y+xHeaQQF49ysOW0i3DhpHxNQUJVBbgiHP0VW7ffQy IyhG/uMWjwAz7ED3Jjh6sl68ZpvORNDATys8hHzsfuLYnKh3gQACrG31RBRrixE2po5a PqVJaVqR7HeN4OEqZkyrlu/AwsaAl36qfLQrjZZJGb/pIJnyCCHgexQi/2jhMqOP83AN I3kSn4EMIwzdDMBgEBU+EdCvJPW5IGr896+Won+9M/hf18qZk4L7MJBxWS5GAyjgZCcc MQ6zKg8mv9beGP4gcYe+xDB8ArHxxaLdnUnSUnHbHga2ANQMgAKtTChEOX0HQclhXkNu GbOA== X-Gm-Message-State: AG10YOQJnOremgUr55O+LAfsEj1xR6DCketCI7Nghv2mIO/KkbWUU/tw3KmR4FFTVGkuVyzqKR3LRV12cj65idro MIME-Version: 1.0 X-Received: by 10.66.252.42 with SMTP id zp10mr41382871pac.29.1453891057322; Wed, 27 Jan 2016 02:37:37 -0800 (PST) Received: by 10.66.196.81 with HTTP; Wed, 27 Jan 2016 02:37:37 -0800 (PST) In-Reply-To: <1453203972-24855-11-git-send-email-sshukla@mvista.com> References: <1453203972-24855-1-git-send-email-sshukla@mvista.com> <1453203972-24855-11-git-send-email-sshukla@mvista.com> Date: Wed, 27 Jan 2016 16:07:37 +0530 Message-ID: From: Santosh Shukla To: dev@dpdk.org Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH v5 10/11] virtio: pci: add dummy func definition for in/outb for non-x86 arch X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jan 2016 10:37:38 -0000 Ping? On Tue, Jan 19, 2016 at 5:16 PM, Santosh Shukla wrote: > For non-x86 arch, Compiler will throw build error for in/out apis. Including > dummy api function so to pass build. > > Note that: For virtio to work for non-x86 arch - RTE_EAL_VFIO is the only > supported method. RTE_EAL_IGB_UIO is not supported for non-x86 arch. > > So, Virtio support for arch and supported interface by that arch: > > ARCH IGB_UIO VFIO > x86 Y Y > ARM64 N/A Y > PPC_64 N/A Y (Not tested but likely should work, as vfio is > arch independent) > > Note: Applicable for virtio spec 0.95 > > Signed-off-by: Santosh Shukla > --- > drivers/net/virtio/virtio_pci.h | 46 +++++++++++++++++++++++++++++++++++++++ > 1 file changed, 46 insertions(+) > > diff --git a/drivers/net/virtio/virtio_pci.h b/drivers/net/virtio/virtio_pci.h > index f550d22..b88f9ec 100644 > --- a/drivers/net/virtio/virtio_pci.h > +++ b/drivers/net/virtio/virtio_pci.h > @@ -46,6 +46,7 @@ > #endif > > #include > +#include "virtio_logs.h" > > struct virtqueue; > > @@ -320,6 +321,51 @@ outl_p(unsigned int data, unsigned int port) > } > #endif > > +#if !defined(RTE_ARCH_X86_64) && !defined(RTE_ARCH_I686) && \ > + defined(RTE_EXEC_ENV_LINUXAPP) > +static inline uint8_t > +inb(unsigned long addr __rte_unused) > +{ > + PMD_INIT_LOG(ERR, "inb() not supported for this RTE_ARCH\n"); > + return 0; > +} > + > +static inline uint16_t > +inw(unsigned long addr __rte_unused) > +{ > + PMD_INIT_LOG(ERR, "inw() not supported for this RTE_ARCH\n"); > + return 0; > +} > + > +static inline uint32_t > +inl(unsigned long addr __rte_unused) > +{ > + PMD_INIT_LOG(ERR, "in() not supported for this RTE_ARCH\n"); > + return 0; > +} > + > +static inline void > +outb_p(unsigned char data __rte_unused, unsigned int port __rte_unused) > +{ > + PMD_INIT_LOG(ERR, "outb_p() not supported for this RTE_ARCH\n"); > + return; > +} > + > +static inline void > +outw_p(unsigned short data __rte_unused, unsigned int port __rte_unused) > +{ > + PMD_INIT_LOG(ERR, "outw_p() not supported for this RTE_ARCH\n"); > + return; > +} > + > +static inline void > +outl_p(unsigned int data __rte_unused, unsigned int port __rte_unused) > +{ > + PMD_INIT_LOG(ERR, "outl_p() not supported for this RTE_ARCH\n"); > + return; > +} > +#endif > + > static inline int > vtpci_with_feature(struct virtio_hw *hw, uint64_t bit) > { > -- > 1.7.9.5 >