From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f178.google.com (mail-pf0-f178.google.com [209.85.192.178]) by dpdk.org (Postfix) with ESMTP id 2157EBE12 for ; Thu, 18 Feb 2016 06:25:11 +0100 (CET) Received: by mail-pf0-f178.google.com with SMTP id e127so24656903pfe.3 for ; Wed, 17 Feb 2016 21:25:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mvista-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=IVXhvT1c39uG1+gEWPSqT02KmGhwzkB53LZKJTOxzwM=; b=fGX9Dv8dViERH4OHTovl88wMLzdp2iCM5gkJ8lO+fT1lYeULfuF9WZKbU8BauRHZ89 MkETXhNqRFmP57cbvd4p0zkn6qobBpF4LMaH7jNtDurlv98m/BsrqwbSzHnaatBdsg19 585p0VtCdKuhFjYgMFaF7A0q22NL2Rr7N0SJ3bXHlXHoX+g+vR6jKLn7zw0+Nu21Ue8z H43OvmmFaj9tY/89VxL/CFfCH4RlmyH6bJP6saKWF5diBU5p6ANZzimofILKIbBSm7M9 nxdJNGt9LYs2xAilg1DJTef1J8mWtBX+lbB3X5GciNVoGTqUva/33q7gyj2MvJrtLING RTtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=IVXhvT1c39uG1+gEWPSqT02KmGhwzkB53LZKJTOxzwM=; b=S4rJtfg3koTS4gGmDKMvcOlYdzRrkSIOyYOv5+aie5GEw2vP65Tnj/FRRmmV9DYqpi dRF5OaaiRGBkjqnvN0DdBOdVKbC9iHyDuznEBONoG/ZbyOBaa/+UQQcxMx3KkWswSvRk YOWetvNsDm1dOaiKF+LcSbi/DRb0RYazkQ4Z/bLv9Dv4xuBWiqqDku+FaTfMFweJLvAt c1PodMilQ5M8BGVlNeUFq8g8OjDSw5QVXQujnW89fVtHdD02UC0XyhMPHTjnYDvv6tzB Wsg8rg/Y/Grlp6DOwfZ2d1f5oIfvljCKva+MUN6xhoLTgN1Z2jiZfJrgU2IxBvxey59t wlFA== X-Gm-Message-State: AG10YOSbj9LPmkjTgFqjBW3dwqYbDe7Mh1W2hRHXPsWuRp4EBOCzE1RdJTpNBsN/R1VBrtd1SNxAl2/a7BRQbMmp MIME-Version: 1.0 X-Received: by 10.98.14.68 with SMTP id w65mr7550879pfi.144.1455773110529; Wed, 17 Feb 2016 21:25:10 -0800 (PST) Received: by 10.66.12.132 with HTTP; Wed, 17 Feb 2016 21:25:10 -0800 (PST) In-Reply-To: References: <1454925815-14292-1-git-send-email-sshukla@mvista.com> <1454925815-14292-2-git-send-email-sshukla@mvista.com> Date: Thu, 18 Feb 2016 10:55:10 +0530 Message-ID: From: Santosh Shukla To: David Marchand Content-Type: text/plain; charset=UTF-8 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v8 4/4] eal/linux: vfio: add pci ioport support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Feb 2016 05:25:12 -0000 On Tue, Feb 9, 2016 at 2:34 PM, David Marchand wrote: > On Mon, Feb 8, 2016 at 3:13 PM, Burakov, Anatoly > wrote: >>> Include vfio map/rd/wr support for pci ioport. >>> >>> Signed-off-by: Santosh Shukla >>> --- >>> v7->v8: >>> - Remove rte_pci_ioport malloc and rte_free()/unmap() func from v7. >>> - removed umap from git header. >>> >>> lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 36 ++++++++++++++++++------- >>> --- >>> 1 file changed, 24 insertions(+), 12 deletions(-) >>> >>> diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c >>> b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c >>> index 4832313..9571ed8 100644 >>> --- a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c >>> +++ b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c >>> @@ -74,6 +74,7 @@ EAL_REGISTER_TAILQ(rte_vfio_tailq) >>> #define VFIO_GROUP_FMT "/dev/vfio/%u" >>> #define VFIO_NOIOMMU_GROUP_FMT "/dev/vfio/noiommu-%u" >>> #define VFIO_GET_REGION_ADDR(x) ((uint64_t) x << 40ULL) >>> +#define VFIO_GET_REGION_IDX(x) (x >> 40) >>> >>> /* per-process VFIO config */ >>> static struct vfio_config vfio_cfg; >>> @@ -999,30 +1000,41 @@ int >>> pci_vfio_ioport_map(struct rte_pci_device *dev, int bar, >>> struct rte_pci_ioport *p) >>> { >>> - RTE_SET_USED(dev); >>> - RTE_SET_USED(bar); >>> - RTE_SET_USED(p); >>> - return -1; >>> + if (bar < VFIO_PCI_BAR0_REGION_INDEX || >>> + bar > VFIO_PCI_BAR5_REGION_INDEX) { >>> + RTE_LOG(ERR, EAL, "invalid bar (%d)!\n", bar); >>> + return -1; >>> + } >>> + >>> + p->dev = dev; >>> + p->offset = VFIO_GET_REGION_ADDR(bar); >>> + return 0; >>> } >>> > > I still think we don't need this p->dev = dev. > But that's not important. > > >> Acked-by: Anatoly Burakov > > Acked-by: David Marchand > Thomas, Can you pl. merge this patch? > > -- > David Marchand