From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <davidjoshuaevans@gmail.com>
Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com
 [209.85.210.180]) by dpdk.org (Postfix) with ESMTP id 97CE8F11
 for <dev@dpdk.org>; Wed, 29 Aug 2018 23:58:07 +0200 (CEST)
Received: by mail-pf1-f180.google.com with SMTP id s13-v6so2877177pfi.7
 for <dev@dpdk.org>; Wed, 29 Aug 2018 14:58:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:from:date:message-id:subject:to;
 bh=rihoy1T+uVrnlSoGI3fud+LAiU0ifkLHzxCRfj/lHDQ=;
 b=Ft3X7iNXxR3fI8SM7FloP8ErAqcATY3kozxfQQndLM6mQwJ0rw6oIVM3ASP2PwZKob
 Baj97bnq43blzsGfzv1ph8BGji2SaTheJApJlnV2/em3fiOVJhvgd4PjMwJDG+uf1N3i
 d3/KhIC2DMNj7KhhCT+ZzCc7k9LBsbeHaCf4QYxqTloaDfHlihrcfd7iMjuEmQSnZu1f
 kqjUOPyatw3vITz63GmEmanFICwaDRJSSkuFPd9yRb5rDnmQ/Wb3X0C0/nRcjwcvc4i+
 Lvr+JJiM8UE1f4LBDiXxptVDqItwj9KTbHcEDW48VbXfFK0k6oZLY604t1kUYAJ938pm
 b2UA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:from:date:message-id:subject:to;
 bh=rihoy1T+uVrnlSoGI3fud+LAiU0ifkLHzxCRfj/lHDQ=;
 b=S0LSu3KQEybX6PE8n/e5babfK7pIil5TETToryAm7hRmFq4W37zdVXi2/LxvZxDiNb
 UtwWOr91z1iM3e2voOuB6ydi3Ak20hgsmSbUKPpB5GznAnQBf/fvl36bTKchy8evfVV+
 pdNBgNh51VqfGJAES1XafSdocwkhHj5vRrnLfjttFjyVqxopolUplJJsPVTT7RRaUO6P
 n60v616C6x2QF9VF+u1TGZ1V0uc51hcH2JLUbIpTom4wyxTejWhkbvrEU0iOvY1v96k+
 JvPkSA9IapDdIsYl0FIWfKx9Eca9ipbYfl0C+D/csckjINbmfLlLHU6BEXCNY4a8zDEJ
 EMaQ==
X-Gm-Message-State: APzg51BZtpPLjP8GJMxVxxCitRJBH5UkNUzibID5DEZXVC1oywmEGMmc
 BQCe7Ba6LEIZsBNkhkxodKgncMrUqwVY+P6Gk+c=
X-Google-Smtp-Source: ANB0VdZ/Zb4Y4wvhV7g1LC8PUff9JHmUm3NBkP5WToFfqfDekP0W0fZRIfVf/bDdvRDEupyzuscmUDOyftTIwqIXb7Q=
X-Received: by 2002:a62:4add:: with SMTP id
 c90-v6mr7659142pfj.65.1535579886733; 
 Wed, 29 Aug 2018 14:58:06 -0700 (PDT)
MIME-Version: 1.0
From: David Evans <davidjoshuaevans@gmail.com>
Date: Wed, 29 Aug 2018 16:57:55 -0500
Message-ID: <CAB8HAh6nJmVn2SbssnyxwhvYqRvcjqYKaVaDxYHt2YDJ46TzYg@mail.gmail.com>
To: qiming.yang@intel.com, dev@dpdk.org
X-Mailman-Approved-At: Fri, 31 Aug 2018 16:08:18 +0200
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: [dpdk-dev] to wait or not to wait.. DPDK & OVS ixgbe with fibre
	disconnected
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Aug 2018 21:58:07 -0000

Hi!

We have a thread running on ovs discuss. - Can you contribute?

regarding ixgbe_ethdev.c

  ixgbe_dev_link_update() doesn't honour wait_to_complete flag always.

Basically, where you have 'wait_to_complete' set to 0, we are still having
to wait sometimes
Dpdk is always attempting setup if intr->flags & IXGBE_FLAG_NEED_LINK_CONFIG
Which happens if you unplug fibre, or don't plug it in.

is there a better way to handle this? It is causing OVS to get stuck
busy... on the thread that calls this.

eg:
 in line 4000  -  ixgbe_setup_link(hw,speed,true)

        if ((intr->flags & IXGBE_FLAG_NEED_LINK_CONFIG) &&
                ixgbe_get_media_type(hw) == ixgbe_media_type_fiber) {
                speed = hw->phy.autoneg_advertised;
                if (!speed)
                        ixgbe_get_link_capabilities(hw, &speed, &autoneg);
                ixgbe_setup_link(hw, speed, true);
        }


or also...

#0  rte_delay_us_block (us=100000) at
/usr/src/debug/dpdk-17.11.3/lib/librte_eal/common/eal_common_timer.c:59
#1  0x00007f548f79ceec in ixgbe_setup_mac_link_multispeed_fiber
(hw=0x7f543fc2f680, speed=128, autoneg_wait_to_complete=0) at
/usr/src/debug/dpdk-17.11.3/drivers/net/ixgbe/base/ixgbe_common.c:5155
#2  0x00007f548f7c2cb2 in ixgbe_dev_link_update_share (vf=0,
wait_to_complete=0, dev=0x7f549492d480 <rte_eth_devices+82560>) at
/usr/src/debug/dpdk-17.11.3/drivers/net/ixgbe/ixgbe_ethdev.c:4000
#3  ixgbe_dev_link_update (dev=0x7f549492d480 <rte_eth_devices+82560>,
wait_to_complete=0) at
/usr/src/debug/dpdk-17.11.3/drivers/net/ixgbe/ixgbe_ethdev.c:4070

Thanks so much

Dave.