From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B1F4A45B96; Tue, 22 Oct 2024 00:39:03 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9E4F840652; Tue, 22 Oct 2024 00:39:03 +0200 (CEST) Received: from mail-yb1-f180.google.com (mail-yb1-f180.google.com [209.85.219.180]) by mails.dpdk.org (Postfix) with ESMTP id 5C4094027E for <dev@dpdk.org>; Tue, 22 Oct 2024 00:39:02 +0200 (CEST) Received: by mail-yb1-f180.google.com with SMTP id 3f1490d57ef6-e29047bec8fso4649736276.0 for <dev@dpdk.org>; Mon, 21 Oct 2024 15:39:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1729550342; x=1730155142; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=CCvREeRvhpsnrdcWS+oWlIBt8PSPjZhO2q7AZwzgjUs=; b=HDysFVgY83cvpXVb4EMH9Ep5QAjocB1En+G2ThluE+27w8dQxZzZ0VTapdV55md46Z Z2gcuZeNLtwFJH9Ki2RW7xwjoOLlEbujXSnusUO9gJfFS54WlSzslC+t/8Q0sxDjsvNW snqSEUU2uT2UxjPaItX06xCYlFfX8td4mEj5U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729550342; x=1730155142; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CCvREeRvhpsnrdcWS+oWlIBt8PSPjZhO2q7AZwzgjUs=; b=QB629XkFiaTzYalO6o+vpgno42bOqk5RkKG92WYigKr4jj0Bl+c/qdMKQh5eVF3SHJ Q9olpM3dqqDkU4qKr5skZLt080cDQhu6aaeksMKSJzz+bcNv3NwYCsjSJLNVSuamakkY RnDjC+krJMiS8R2qaOjaHglhI4zW6aF83jrkFPgo245thWR1GuyDOLWxsefhygGY9bjC 3NGS63Ed51JbIR/g0baRd7xxEM/QJVO3M1trOXi0SOZchSGmqesRbdd0sALAkgBw9Kq6 ZeHKbfh2LAD07fHFSA1GqTdnTa7XcerEz+0oZ0GqsZlhNZNkT9emM2r6cdIK8z2fjSTs FDIA== X-Gm-Message-State: AOJu0Yw9HG4rzN+oactU/CY7F+2q72NZtpO6w2A6x94RFIAf/ha84Hwp dB0lCGaA5szeia1sz3OnSWZzByLF3wfyAZhXyEkZWhxUH0HH2UjfM0Kz6jm16F38IzwB2qEUQh3 FqfRHkxBsFXPx8Crx+6SBCxUyozFF2zKsTeweF2SEuDFKvXvre48= X-Google-Smtp-Source: AGHT+IGXp0lQfJI0JaY+2sKLPlQBd7cI/xbNoyqkRSVOdk3b9ONKuKDhJQUgmCaKLWXZzJLlB+NdKd3SlaZE83xQ8OA= X-Received: by 2002:a05:6902:2e87:b0:e1a:90ef:3b6d with SMTP id 3f1490d57ef6-e2e2456e30cmr1212074276.7.1729550341634; Mon, 21 Oct 2024 15:39:01 -0700 (PDT) MIME-Version: 1.0 References: <20240930160204.19582-1-tomas.durovec@pantheon.tech> <20241021134935.1210500-1-luca.vizzarro@arm.com> In-Reply-To: <20241021134935.1210500-1-luca.vizzarro@arm.com> From: Dean Marx <dmarx@iol.unh.edu> Date: Mon, 21 Oct 2024 18:39:17 -0400 Message-ID: <CABD7UXO-VcDHiCQGroEwVqG7H3Gk4ioTFzi3KWRGR3tfVu+HmA@mail.gmail.com> Subject: Re: [PATCH v2 0/7] DTS external DPDK build To: Luca Vizzarro <luca.vizzarro@arm.com> Cc: dev@dpdk.org, Paul Szczepanek <paul.szczepanek@arm.com>, Patrick Robb <probb@iol.unh.edu> Content-Type: multipart/alternative; boundary="000000000000bc1f19062504516c" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org --000000000000bc1f19062504516c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Luca, I noticed in the new version of this series the "improve statistics" patch was taken out, was there any reason for this? I believe Juraj wanted to create a feature that wrote all of the test suite/case summaries in a JSON/text output file, is this going to be implemented later or in a different format? https://patches.dpdk.org/project/dpdk/patch/20240906132656.21729-13-juraj.l= inkes@pantheon.tech/ On Mon, Oct 21, 2024 at 9:49=E2=80=AFAM Luca Vizzarro <luca.vizzarro@arm.co= m> wrote: > Hello, > > taking over this patchset from Tom=C3=A1=C5=A1, who no longer contributes= to > DTS. Please find in this cover letter the changes I've made. > > v2: > - rebased on top of dts-next and resolved conflicts > - fixed bugs > - rephrased some docstrings > - improved settings naming for less ambiguity > - improved commit subjects and bodies > > Kind regards, > Luca > > Tom=C3=A1=C5=A1 =C4=8Eurovec (7): > dts: rename build target to DPDK build > dts: enforce one dpdk build per test run > dts: fix remote session file transfer vars > dts: enable copying directories to and from nodes > dts: add support for externally compiled DPDK > doc: update argument options for external DPDK build > dts: remove git ref option > > doc/guides/tools/dts.rst | 82 ++-- > dts/conf.yaml | 18 +- > dts/framework/config/__init__.py | 142 ++++++- > dts/framework/config/conf_yaml_schema.json | 72 +++- > dts/framework/config/types.py | 19 +- > dts/framework/exception.py | 4 +- > dts/framework/logger.py | 4 - > dts/framework/remote_session/dpdk_shell.py | 2 +- > .../remote_session/remote_session.py | 24 +- > dts/framework/remote_session/ssh_session.py | 18 +- > dts/framework/runner.py | 139 ++----- > dts/framework/settings.py | 202 +++++++--- > dts/framework/test_result.py | 124 ++---- > dts/framework/test_suite.py | 2 +- > dts/framework/testbed_model/node.py | 22 +- > dts/framework/testbed_model/os_session.py | 209 ++++++++-- > dts/framework/testbed_model/posix_session.py | 141 ++++++- > dts/framework/testbed_model/sut_node.py | 376 ++++++++++++------ > dts/framework/utils.py | 164 +++----- > dts/tests/TestSuite_smoke_tests.py | 2 +- > 20 files changed, 1130 insertions(+), 636 deletions(-) > > -- > 2.43.0 > > --000000000000bc1f19062504516c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr">Hi Luca,<div><br></div><div>I noticed in the new version o= f this series the "improve statistics" patch was taken out, was t= here any reason for this? I believe Juraj wanted to create a feature that w= rote all of the test suite/case summaries in a JSON/text output file, is th= is going to be implemented later or in a different=C2=A0format?</div><div><= a href=3D"https://patches.dpdk.org/project/dpdk/patch/20240906132656.21729-= 13-juraj.linkes@pantheon.tech/">https://patches.dpdk.org/project/dpdk/patch= /20240906132656.21729-13-juraj.linkes@pantheon.tech/</a></div></div><br><di= v class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Mon, Oct 2= 1, 2024 at 9:49=E2=80=AFAM Luca Vizzarro <<a href=3D"mailto:luca.vizzarr= o@arm.com">luca.vizzarro@arm.com</a>> wrote:<br></div><blockquote class= =3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rg= b(204,204,204);padding-left:1ex">Hello,<br> <br> taking over this patchset from Tom=C3=A1=C5=A1, who no longer contributes t= o<br> DTS. Please find in this cover letter the changes I've made.<br> <br> v2:<br> - rebased on top of dts-next and resolved conflicts<br> - fixed bugs<br> - rephrased some docstrings<br> - improved settings naming for less ambiguity<br> - improved commit subjects and bodies<br> <br> Kind regards,<br> Luca<br> <br> Tom=C3=A1=C5=A1 =C4=8Eurovec (7):<br> =C2=A0 dts: rename build target to DPDK build<br> =C2=A0 dts: enforce one dpdk build per test run<br> =C2=A0 dts: fix remote session file transfer vars<br> =C2=A0 dts: enable copying directories to and from nodes<br> =C2=A0 dts: add support for externally compiled DPDK<br> =C2=A0 doc: update argument options for external DPDK build<br> =C2=A0 dts: remove git ref option<br> <br> =C2=A0doc/guides/tools/dts.rst=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 82 ++--<br> =C2=A0dts/conf.yaml=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 18 +-= <br> =C2=A0dts/framework/config/__init__.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 | 142 ++++++-<br> =C2=A0dts/framework/config/conf_yaml_schema.json=C2=A0 =C2=A0 |=C2=A0 72 ++= +-<br> =C2=A0dts/framework/config/types.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 19 +-<br> =C2=A0dts/framework/exception.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A04 +-<br> =C2=A0dts/framework/logger.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A04 -<br> =C2=A0dts/framework/remote_session/dpdk_shell.py=C2=A0 =C2=A0 |=C2=A0 =C2= =A02 +-<br> =C2=A0.../remote_session/remote_session.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 |=C2=A0 24 +-<br> =C2=A0dts/framework/remote_session/ssh_session.py=C2=A0 =C2=A0|=C2=A0 18 +-= <br> =C2=A0dts/framework/runner.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| 139 ++-----<br> =C2=A0dts/framework/settings.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| 202 +++++++---<br> =C2=A0dts/framework/test_result.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 | 124 ++----<br> =C2=A0dts/framework/test_suite.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A02 +-<br> =C2=A0dts/framework/testbed_model/node.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0|=C2=A0 22 +-<br> =C2=A0dts/framework/testbed_model/os_session.py=C2=A0 =C2=A0 =C2=A0| 209 ++= ++++++--<br> =C2=A0dts/framework/testbed_model/posix_session.py=C2=A0 | 141 ++++++-<br> =C2=A0dts/framework/testbed_model/sut_node.py=C2=A0 =C2=A0 =C2=A0 =C2=A0| 3= 76 ++++++++++++------<br> =C2=A0dts/framework/utils.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 164 +++-----<br> =C2=A0dts/tests/TestSuite_smoke_tests.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 |=C2=A0 =C2=A02 +-<br> =C2=A020 files changed, 1130 insertions(+), 636 deletions(-)<br> <br> -- <br> 2.43.0<br> <br> </blockquote></div> --000000000000bc1f19062504516c--