From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B33EA458F4; Tue, 3 Sep 2024 18:03:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3CE774042C; Tue, 3 Sep 2024 18:03:36 +0200 (CEST) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by mails.dpdk.org (Postfix) with ESMTP id 9AC6A402D0 for ; Tue, 3 Sep 2024 18:03:35 +0200 (CEST) Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1fc47abc040so43919165ad.0 for ; Tue, 03 Sep 2024 09:03:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1725379414; x=1725984214; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=4XHXV3O2HcxvL7t6NmfiZFPiZYbOoVDtRSm4YhSzNZY=; b=bKoMbXkCiC65QUVmKc6Hz2r6xmR+Kj8ApR2NHzNx49KE6ZtntIjIBoHS4B4xqfYyen GPkVtiOmUHf+kc1aWVRTln+aTse6wVz0z5Nkb6EIX7oFMZa6PmxH9mXM7T7qqJI/mG0M EiCAkqryX0Dm6MjuqRZNym8irZG2iIDDf90DI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725379414; x=1725984214; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4XHXV3O2HcxvL7t6NmfiZFPiZYbOoVDtRSm4YhSzNZY=; b=gXBmQwl7+zMQx17KAAS0nSKXh1hLZnwNBahoZRym4tpNyyvQEGrM67q+yS2UswC0m7 oxx3euTjwi18f7ak9ABq6j+Kzo03C2rexUSzF7eLirfkRPZV2msmMZaZS8/F9X8zVRMn tIb1Jd7hHHXBMVcrZpU7839HT9lB+pVbbp6dq8h8Wp2hhRMJn78KK0ICnxkxjaNIxfsA /MNppW/E8B5FCfBVBI5A0s7gEPwPhjMi61paq3mMKukdtz+2q2gg6CgWU/k6WeKqkmG5 /1WdmtnR+whnZw2zyBTuNWCieGBrZMFa+4nchzPzYMzPQb+VjbybimAn6qQ6UnUnC8Qk PkbQ== X-Forwarded-Encrypted: i=1; AJvYcCUYggTP2Tl24tcCrcJo5JFlh+1cu480ZUDB8nbEOU8fK0dOXmoL4EX/6YYOQ4Z7ou9C2wo=@dpdk.org X-Gm-Message-State: AOJu0YxI4T4J4YPZ08Du510wIS+zWbFSU5M3lXgrbLzYZ/8VcfsizxSB cHYDn1x3Y3J/VmThq6+o0T3AVHT2LkBSG7/eZ66kpeYrlSEviITBvIFXSJLOmXj5UnG8Hqmm6Ca sTAXW5VpdSvbw7n6PdEUY353SzLGYtD/aHv2Tzw== X-Google-Smtp-Source: AGHT+IG9m3DV2zNpoptcOo6uQjCKEAPP9I94ARmZF4qOJ+Uai3pmkYCXO0Yils5q5EFT9r91HtMaQYkHv5jlW4bnyf8= X-Received: by 2002:a17:902:d2cd:b0:205:5f54:75a2 with SMTP id d9443c01a7336-2055f5478femr110576835ad.51.1725379414362; Tue, 03 Sep 2024 09:03:34 -0700 (PDT) MIME-Version: 1.0 References: <20240301155416.96960-1-juraj.linkes@pantheon.tech> <20240821145315.97974-1-juraj.linkes@pantheon.tech> <20240821145315.97974-7-juraj.linkes@pantheon.tech> In-Reply-To: <20240821145315.97974-7-juraj.linkes@pantheon.tech> From: Dean Marx Date: Tue, 3 Sep 2024 12:03:45 -0400 Message-ID: Subject: Re: [PATCH v3 06/12] dst: add basic capability support To: =?UTF-8?Q?Juraj_Linke=C5=A1?= Cc: thomas@monjalon.net, Honnappa.Nagarahalli@arm.com, jspewock@iol.unh.edu, probb@iol.unh.edu, paul.szczepanek@arm.com, Luca.Vizzarro@arm.com, npratte@iol.unh.edu, alex.chapman@arm.com, dev@dpdk.org Content-Type: multipart/alternative; boundary="00000000000018a64a06213933c1" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --00000000000018a64a06213933c1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Aug 21, 2024 at 10:53=E2=80=AFAM Juraj Linke=C5=A1 wrote: > A test case or suite may require certain capabilities to be present in > the tested environment. Add the basic infrastructure for checking the > support status of capabilities: > * The Capability ABC defining the common capability API > * Extension of the TestProtocol with required capabilities (each test > suite or case stores the capabilities it requires) > * Integration with the runner which calls the new APIs to get which > capabilities are supported. > > Signed-off-by: Juraj Linke=C5=A1 > Looks all good to me, it was interesting to see how you've used abstract methods in the Capability class. The only thing I noticed was it seems like you wrote "dst" instead of "dts" in the commit message, otherwise: Reviewed-by: Dean Marx --00000000000018a64a06213933c1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Aug 21, 2024 at 10:53=E2=80=AFAM = Juraj Linke=C5=A1 <juraj.linkes@pantheon.tech> wrote:
A te= st case or suite may require certain capabilities to be present in
the tested environment. Add the basic infrastructure for checking the
support status of capabilities:
* The Capability ABC defining the common capability API
* Extension of the TestProtocol with required capabilities (each test
=C2=A0 suite or case stores the capabilities it requires)
* Integration with the runner which calls the new APIs to get which
=C2=A0 capabilities are supported.

Signed-off-by: Juraj Linke=C5=A1 <juraj.linkes@pantheon.tech>

Looks all good to me, it was interesting to se= e how you've used abstract methods in the Capability class. The only th= ing I noticed was it seems like you wrote "dst" instead of "= dts" in the commit message, otherwise:

Review= ed-by: Dean Marx <dmarx@iol.unh.edu= >
--00000000000018a64a06213933c1--