Re: [RFC PATCH 1/7] dts: add port topology configuration

[Dean Marx <dmarx@iol.unh.edu>]

On Mon, Feb 3, 2025 at 10:17 AM Luca Vizzarro <luca.vizzarro@arm.com> wrote:
>
> The current configuration makes the user re-specify the port links for
> each port in an unintuitive and repetitive way. Moreover, this design
> does not give the user to opportunity to map the port topology as
> desired.
>
> This change adds a port_topology field in the test runs, so that the
> user can use map topologies for each run as required. Moreover it
> simplies the process to link ports by defining a user friendly notation.
>
> Bugzilla ID: 1478
>
> Signed-off-by: Luca Vizzarro <luca.vizzarro@arm.com>
<snip>

>    system_under_test_node: "SUT 1"
>    # Traffic generator node to use for this execution environment
>    traffic_generator_node: "TG 1"
> +  port_topology:
> +    - sut.Port 0 <-> tg.Port 0  # explicit link
> +    - Port 1 <-> Port 1         # implicit link, left side is always SUT, right side is always TG.

Looks good to me, one small thing I think might be helpful to the user
is adding a section in the explicit link comment explaining that "sut"
and "tg" are the only options for the port_topology nodes, unlike the
port name which can be changed in the nodes.yaml file. This way the
user doesn't have to learn this through the framework, or trial and
error (especially since the ports have a name section as well.)

Reviewed-by: Dean Marx <dmarx@iol.unh.edu>