DPDK patches and discussions
 help / color / mirror / Atom feed
From: Dean Marx <dmarx@iol.unh.edu>
To: Thomas Wilks <thomas.wilks@arm.com>
Cc: dev@dpdk.org, Paul Szczepanek <paul.szczepanek@arm.com>,
	 Luca Vizzarro <luca.vizzarro@arm.com>,
	Patrick Robb <probb@iol.unh.edu>
Subject: Re: [PATCH 1/2] dts: add packet capture test suite
Date: Thu, 10 Apr 2025 13:04:55 -0400	[thread overview]
Message-ID: <CABD7UXOvafW16tvnz4oKX7u2LCCfyDebcPxZDcvYqoa2s5K=YQ@mail.gmail.com> (raw)
In-Reply-To: <20250331155800.449823-2-thomas.wilks@arm.com>

On Mon, Mar 31, 2025 at 11:58 AM Thomas Wilks <thomas.wilks@arm.com> wrote:
>
> Add a test suite that tests the packet capture framework
> through the use of dpdk-pdump.
>
> Signed-off-by: Thomas Wilks <thomas.wilks@arm.com>
> Reviewed-by: Luca Vizzarro <luca.vizzarro@arm.com>
> ---
>  .../dts/tests.TestSuite_packet_capture.rst    |   8 +
>  dts/tests/TestSuite_packet_capture.py         | 358 ++++++++++++++++++
>  2 files changed, 366 insertions(+)
>  create mode 100644 doc/api/dts/tests.TestSuite_packet_capture.rst
>  create mode 100644 dts/tests/TestSuite_packet_capture.py

<snip>

> +    device_id: str | None = None
> +    port: int | None = None
> +    queue: Union[int, Literal["*"]] = "*"
> +    tx_dev: PurePath | str | None = None
> +    rx_dev: PurePath | str | None = None
> +    ring_size: int | None = None
> +    mbuf_size: int | None = None
> +    total_num_mbufs: int | None = None

One small thing I noticed here is that you're using Union for the
queue and pipes for the rest of the declarations. queue: int |
Literal["*"] = "*" would be the same thing functionally, and it would
save you an import.

Reviewed-by: Dean Marx <dmarx@iol.unh.edu>

  reply	other threads:[~2025-04-10 17:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-31 15:57 [PATCH 0/2] " Thomas Wilks
2025-03-31 15:57 ` [PATCH 1/2] " Thomas Wilks
2025-04-10 17:04   ` Dean Marx [this message]
2025-04-10 22:46   ` Stephen Hemminger
2025-03-31 15:58 ` [PATCH 2/2] dts: import lldp package in scapy Thomas Wilks
2025-04-10 17:06   ` Dean Marx

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABD7UXOvafW16tvnz4oKX7u2LCCfyDebcPxZDcvYqoa2s5K=YQ@mail.gmail.com' \
    --to=dmarx@iol.unh.edu \
    --cc=dev@dpdk.org \
    --cc=luca.vizzarro@arm.com \
    --cc=paul.szczepanek@arm.com \
    --cc=probb@iol.unh.edu \
    --cc=thomas.wilks@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).