From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B3DD745A7E; Tue, 1 Oct 2024 19:11:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 854F54027E; Tue, 1 Oct 2024 19:11:56 +0200 (CEST) Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) by mails.dpdk.org (Postfix) with ESMTP id C4C2F40273 for ; Tue, 1 Oct 2024 19:11:54 +0200 (CEST) Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-6db4b602e38so46570717b3.1 for ; Tue, 01 Oct 2024 10:11:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1727802714; x=1728407514; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=pA+Tn8lS2UtiEiSqsbkqHhhnepWNcDrsmqDbCfRkeDM=; b=jiz9/EFpHk/Yn4sIZjNFIW+6UMot7Hn0A9nfRna637co0/GjWY1pPjQ2s8sOF3ko54 lHQ9+wxHtTx790RtxDXJFIU6peeLBvsa7RV6yEL5nc3i20XrPQ5SzTRV0j0baGOELb1c UZA6fQpyLdurcKl3vbTHd96wgsvagOSYA7ap8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727802714; x=1728407514; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pA+Tn8lS2UtiEiSqsbkqHhhnepWNcDrsmqDbCfRkeDM=; b=rmCNGkP1Jzy/piLO+sK3ddCcO9QePFZL8jd9DW4b+nJdYk1pSD7pYVaHtbW6DLAMLx WkR8TtJ3VBxf4tEEmmvaOfwNN84ZUf8mSnYBj95IBrmtY1s7R7oywB+dg0PkAbNwPyG7 JD731lthor9yuJb34Rwq7a/bbzpWXenfX+EOpTjo8S9KFHDpiuy08lLgGEfdPZ68YPCr /mHrR+KfSL9DYpGIH3CnK0MDUq7yu0cVp4JgutNNwZWz+uM8HETKoxvb+x35ZcRDt1qj g1rMBL8Y0d6JOGlJ8uFGf4YJAJMaUj0GOisz+NCYnl4/EjuopwDry7Xp4L5uc6qs3B0N khBQ== X-Gm-Message-State: AOJu0YzRCiVnmfMsM0y6baLk/fhAsFmOjeWTN40+KE8WGsdEYIghrUeY ShH3FlAE4Xj29EI080HJxVYgN5zBjhrGUSHT0TRS1BrCWxFBFrlTq2UeVTwPlwgXSNaAcmuWmMd 8Vv5RYND+5peXxcn26J6wVeSX1A5rZITAeCoW2qGNvlb9Q2fa X-Google-Smtp-Source: AGHT+IGGFolQC1ASkADtGUQsVbpOOR6LQtd/x2IP25fe5iQYqNXZ6sQhxwNIEpoYMPRd6i+lVwukErCouOG5rXZMZI0= X-Received: by 2002:a05:690c:550a:b0:6dd:bcfd:f168 with SMTP id 00721157ae682-6e2a2dbe917mr4839527b3.18.1727802714154; Tue, 01 Oct 2024 10:11:54 -0700 (PDT) MIME-Version: 1.0 References: <20240822163941.1390326-1-luca.vizzarro@arm.com> <20240822163941.1390326-5-luca.vizzarro@arm.com> In-Reply-To: <20240822163941.1390326-5-luca.vizzarro@arm.com> From: Dean Marx Date: Tue, 1 Oct 2024 13:12:12 -0400 Message-ID: Subject: Re: [PATCH 4/5] dts: use TestSuiteSpec class imports To: Luca Vizzarro Cc: dev@dpdk.org, Honnappa Nagarahalli , =?UTF-8?Q?Juraj_Linke=C5=A1?= , Paul Szczepanek Content-Type: multipart/alternative; boundary="00000000000005059a06236d6bef" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --00000000000005059a06236d6bef Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Aug 22, 2024 at 12:40=E2=80=AFPM Luca Vizzarro wrote: > The introduction of TestSuiteSpec adds auto-discovery of test suites, > which are also automatically imported. This causes double imports as the > runner loads the test suites. This changes the behaviour of the runner > to load the imported classes from TestSuiteSpec instead of importing > them again. > > Signed-off-by: Luca Vizzarro > Reviewed-by: Paul Szczepanek > > + filtered_test_cases: list[TestCase] =3D [ > + test_case > + for test_case in test_suite_spec.test_cases > + if not test_suite_config.test_cases_names > + or test_case.name in test_suite_config.test_cases_names > + ] > > Just wondering, what's the plan with the filtered test cases? I'm assuming they're stored here so we can report which cases were skipped after runtime= ? Reviewed-by: Dean Marx --00000000000005059a06236d6bef Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Thu, Aug 22, 2024 at 12:40=E2=80=AFPM = Luca Vizzarro <luca.vizzarro@ar= m.com> wrote:
The introduction of TestSuiteSpec adds aut= o-discovery of test suites,
which are also automatically imported. This causes double imports as the runner loads the test suites. This changes the behaviour of the runner
to load the imported classes from TestSuiteSpec instead of importing
them again.

Signed-off-by: Luca Vizzarro <luca.vizzarro@arm.com>
Reviewed-by: Paul Szczepanek <paul.szczepanek@arm.com>
=C2= =A0
<snip>=C2=A0
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 filtered_test_cases: list[TestCa= se] =3D [
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 test_case
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 for test_case in t= est_suite_spec.test_cases
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if not test_suite_= config.test_cases_names
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 or test_case.name = in test_suite_config.test_cases_names
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ]


Just wondering, what's the plan wi= th the filtered test cases? I'm assuming they're stored here so we = can report which cases were skipped after runtime?

Reviewed-by: Dean Marx <dmarx@iol.= unh.edu>
=C2=A0

--00000000000005059a06236d6bef--