From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 9E72745BCC;
	Fri, 25 Oct 2024 20:30:44 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 89F9740264;
	Fri, 25 Oct 2024 20:30:44 +0200 (CEST)
Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com
 [209.85.128.182])
 by mails.dpdk.org (Postfix) with ESMTP id 2B7AB4021F
 for <dev@dpdk.org>; Fri, 25 Oct 2024 20:30:43 +0200 (CEST)
Received: by mail-yw1-f182.google.com with SMTP id
 00721157ae682-6e3d7e6f832so22719347b3.0
 for <dev@dpdk.org>; Fri, 25 Oct 2024 11:30:43 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=iol.unh.edu; s=unh-iol; t=1729881042; x=1730485842; darn=dpdk.org;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:from:to:cc:subject:date:message-id:reply-to;
 bh=tB1/rye4X0LyC6VvtiiQnXPp5BEpdckIDwMZvi8DKOo=;
 b=KRjydYM59A/NBebTmC66na26C0ma15WHneKGaUHjGaCYooZBIdZZVXSV6qQcfLk7pE
 ybTXNMhSzAMc3qh9oo+VutOvxuc2imrXbZ+eLVSiunMw37B3QLVuAWxyZ7QPDyQKkv4+
 MSY4ysvM1Sb1NdmZTLaHsExoSgNohupEQED7c=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1729881042; x=1730485842;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=tB1/rye4X0LyC6VvtiiQnXPp5BEpdckIDwMZvi8DKOo=;
 b=YxjSybtwQEfSz00S6LIpZQdQ6/OXgAo6h25bNKe0LLQJIulxnxPVdfytMFcmvVgLtd
 0W+u5Z+6sUSE0A7bdqbpp9aOG5GM/pb/LVHpDXiQS6SV7YWA+/rfF8b8ZTdQkzMy5IhW
 Q8aoGZZ6n0vEpG99/Ei26K5+TvUwEfgDkwK6+PLP+W858LeXr52lBmKI9B87im6U3H44
 xjVpaFXUojusyib/8XWMPyxcs3rZIVPgVY12D220CCPglv9FA/WHFgFUQ/08+drt6PcW
 QtSy1ewx5j7Go0ZqXVAI/LWsf0xvIgeLXAhWFktNtI4BHYh+iSpvJjl6/zPW0KDPJOkS
 oZ0w==
X-Gm-Message-State: AOJu0YwWHaLgEZI8C/WXTcf5rdulYfmiz+Ng2gKcrDIi4pdG1DOrtH4z
 /CeD1GkIbZmKt02T7S3lvKMz4P0UPrYkD8q6fuCak+dQhfls7Xdvjad/mTRGyj/XFi08YhMk5ea
 2yWRQygaGgbC/REk9dIia4SPnlYIFXLtc3Oq8Mg==
X-Google-Smtp-Source: AGHT+IFAgDgsTGgOzo+/FgliDjw/N/fE/25Mde5oIi1EB9IQ2zdTwqb7LyteLwtf1p28mqt9F2YFIS6eemUJ0MiuqEs=
X-Received: by 2002:a05:690c:a:b0:6e2:b537:3085 with SMTP id
 00721157ae682-6e9d8aa410bmr5685297b3.34.1729881042468; Fri, 25 Oct 2024
 11:30:42 -0700 (PDT)
MIME-Version: 1.0
References: <20240930160204.19582-1-tomas.durovec@pantheon.tech>
 <20241021134935.1210500-1-luca.vizzarro@arm.com>
 <20241021134935.1210500-7-luca.vizzarro@arm.com>
In-Reply-To: <20241021134935.1210500-7-luca.vizzarro@arm.com>
From: Dean Marx <dmarx@iol.unh.edu>
Date: Fri, 25 Oct 2024 14:30:57 -0400
Message-ID: <CABD7UXPq15-f++1bXiRAO6+1f-hHc26M1-DcZsWsv5A+wCz3Cw@mail.gmail.com>
Subject: Re: [PATCH v2 6/7] doc: update argument options for external DPDK
 build
To: Luca Vizzarro <luca.vizzarro@arm.com>
Cc: dev@dpdk.org, Paul Szczepanek <paul.szczepanek@arm.com>,
 Patrick Robb <probb@iol.unh.edu>, 
 =?UTF-8?B?VG9tw6HFoSDEjnVyb3ZlYw==?= <tomas.durovec@pantheon.tech>
Content-Type: multipart/alternative; boundary="0000000000000a672006255151d2"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

--0000000000000a672006255151d2
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Oct 21, 2024 at 9:50=E2=80=AFAM Luca Vizzarro <luca.vizzarro@arm.co=
m> wrote:

> From: Tom=C3=A1=C5=A1 =C4=8Eurovec <tomas.durovec@pantheon.tech>
>
> By adding support for external build, we extend the
> argument documentation for supported options.
>
> Signed-off-by: Tom=C3=A1=C5=A1 =C4=8Eurovec <tomas.durovec@pantheon.tech>
> Signed-off-by: Luca Vizzarro <luca.vizzarro@arm.com>
>

Other than the comments I brought up on the previous patch:

Reviewed-by: Dean Marx <dmarx@iol.unh.edu>

--0000000000000a672006255151d2
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Mon, Oct 21, 2024 at 9:50=E2=80=AFAM L=
uca Vizzarro &lt;<a href=3D"mailto:luca.vizzarro@arm.com">luca.vizzarro@arm=
.com</a>&gt; wrote:<br></div><div class=3D"gmail_quote"><blockquote class=
=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rg=
b(204,204,204);padding-left:1ex">From: Tom=C3=A1=C5=A1 =C4=8Eurovec &lt;tom=
as.durovec@pantheon.tech&gt;<br>
<br>
By adding support for external build, we extend the<br>
argument documentation for supported options.<br>
<br>
Signed-off-by: Tom=C3=A1=C5=A1 =C4=8Eurovec &lt;tomas.durovec@pantheon.tech=
&gt;<br>
Signed-off-by: Luca Vizzarro &lt;<a href=3D"mailto:luca.vizzarro@arm.com" t=
arget=3D"_blank">luca.vizzarro@arm.com</a>&gt;<br></blockquote><div><br></d=
iv><div>Other than the comments I brought up on the previous patch:</div><d=
iv><br></div><div>Reviewed-by: Dean Marx &lt;<a href=3D"mailto:dmarx@iol.un=
h.edu">dmarx@iol.unh.edu</a>&gt;=C2=A0</div></div></div>

--0000000000000a672006255151d2--