Re: [EXTERNAL] [PATCH v4 2/2] crypto/uadk: use async mode to replace sync mode

[Zhangfei Gao <zhangfei.gao@linaro.org>]

On Wed, 9 Jul 2025 at 03:33, Akhil Goyal <gakhil@marvell.com> wrote:
>
> > To get better performance, using async mode to replace sync mode
> >
> > However, case UADK_CHAIN_CIPHER_AUTH and UADK_CHAIN_AUTH_CIPHER
> > still use sync mode for the first operation and async mode for
> > the second operation since the dependence.
> >
> > Also RTE_CRYPTO_AUTH_OP_VERIFY will hold the generated auth in
> > qp->temp_digest[idx % BURST_MAX] to verify later.
> >
> > Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
> > ---
> >  doc/guides/cryptodevs/uadk.rst                |  15 +
> >  doc/guides/rel_notes/release_25_07.rst        |   5 +
> >  drivers/crypto/uadk/meson.build               |   4 +-
> >  drivers/crypto/uadk/uadk_crypto_pmd.c         | 297 ++++++++++++------
> >  drivers/crypto/uadk/uadk_crypto_pmd_private.h |   8 +-
> >  5 files changed, 234 insertions(+), 95 deletions(-)
> >
> > diff --git a/doc/guides/cryptodevs/uadk.rst b/doc/guides/cryptodevs/uadk.rst
> > index d38dffbcd9..7591c0e94b 100644
> > --- a/doc/guides/cryptodevs/uadk.rst
> > +++ b/doc/guides/cryptodevs/uadk.rst
> > @@ -112,6 +112,21 @@ Test steps
> >        RTE>>quit
> >
> >
> > +As a reference, the following table shows a mapping between the past DPDK
> > versions
> > +and the UADK library version supported by them:
> > +
> > +.. _table_uadk_crypto_pmd_versions:
> > +
> > +.. table:: DPDK and external UADK library version compatibility
> > +
> > +   ==============  ============================
> > +   DPDK version    UADK library version
> > +   ==============  ============================
> > +   22.11 - 25.03   2.4  - 2.8
> > +   25.07+          2.9.1
> > +   ==============  ============================
> > +
> > +
> >  Initialization
> >  --------------
> >
> > diff --git a/doc/guides/rel_notes/release_25_07.rst
> > b/doc/guides/rel_notes/release_25_07.rst
> > index e57cf546c2..5e8cb0e512 100644
> > --- a/doc/guides/rel_notes/release_25_07.rst
> > +++ b/doc/guides/rel_notes/release_25_07.rst
> > @@ -98,6 +98,11 @@ New Features
> >
> >    * Added support for AMD Solarflare X45xx adapters.
> >
> > +* **Updated UADK crypto & compress driver.**
> > +
> > +  * Update to init2 interface which requires v2.9 of the UADK library.
> > +  * Update to asynchronous mode for better performance.
>
>
> This shall be v2.9.1. Right?
>
> > +
> >  * **Updated virtio driver.**
> >
> >    * Added support for Rx and Tx burst mode query.
> > diff --git a/drivers/crypto/uadk/meson.build b/drivers/crypto/uadk/meson.build
> > index e46abd21e5..00cd7d1c44 100644
> > --- a/drivers/crypto/uadk/meson.build
> > +++ b/drivers/crypto/uadk/meson.build
> > @@ -13,7 +13,7 @@ sources = files(
> >  )
> >
> >  deps += 'bus_vdev'
> > -dep = dependency('libwd_crypto', required: false, method: 'pkg-config')
> > +dep = dependency('libwd_crypto', version: '>=2.9', required: false, method: 'pkg-
> > config')
> >  if not dep.found()
> >      build = false
> >      reason = 'missing dependency, "libwd_crypto"'
> > @@ -21,7 +21,7 @@ else
> >      ext_deps += dep
> >  endif
> >
> > -dep = dependency('libwd', required: false, method: 'pkg-config')
> > +dep = dependency('libwd', version: '>=2.9', required: false, method: 'pkg-config')
>
> Here and in your compress patch also, the dependency version should be >=2.9.1. Right?
> Please fix these mismatches as soon as possible. We are closing RC3 tomorrow.
> If it is not merged in RC3, will be deferred to next release.

Have updated.

Made a uadk 2.9.1 release as well for this.

Thanks for your patience.

Thanks