From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 36736A0542; Wed, 26 Oct 2022 11:54:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2384A40F17; Wed, 26 Oct 2022 11:53:59 +0200 (CEST) Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) by mails.dpdk.org (Postfix) with ESMTP id 586A840041 for ; Wed, 26 Oct 2022 11:53:57 +0200 (CEST) Received: by mail-ej1-f52.google.com with SMTP id 13so19795724ejn.3 for ; Wed, 26 Oct 2022 02:53:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=zlyN8TPYq0ZN4uBV7hucrpytk1czes4ucOJOOgYSP1w=; b=HkutLSO0Z+BvqPd8a5YpuGEYXtp1Kaxt7tYa2J6zrGkZHBLlSSB8wA+NIOZK2NDNEz DWINjTGssCamD0ZBsu12ZNONnr7k8DPMQa8vZ/SkIelnXJSWP6lPJpLZaIeNOWEtsiKe UEZFroDjV6SuwKY+guWKT4vX6JXwQmwo3RRw6Ad/jOYw6i7d/5JVbbJP6RGikBiolfFz FG/71MhMmTOr4fyaErzybDcCvVAGH6AAlR7Qv0oZneITzHHn0XmggisInNR0jjK73Kvk vLdl8lLr9H4DSXfi8Z2G8QG/YBn28oll+b2/qKUW53LmTB4tkoV4I/V/9ws8dyLW70No 26jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zlyN8TPYq0ZN4uBV7hucrpytk1czes4ucOJOOgYSP1w=; b=i7sT9CTq3uhxS4EiIbuaKZEAIfeiRLIFZJ/+zMUm6526EguSj25gQ97nUbvV/DUjs0 jHsl7wwuVfxkFPEm423iUXu7IRGGdtiMaXw/hHAz9gBtqW7/n4GsstIvm3TWO1xYZ9Al WfRRXpLU9H08TdQRGyb+c1kFgEIREfGlEWvxA6A8jJ9kNBywtJQHzdI8eWgDi9z+HBgK if7rQquY3xmbsq5K3g/J9u8sAGqyHo8JtYD6k67NqJTc5kcCvMKtSB1Uio7+1Ii2F3LI 3e2rZSfZkHq77HJy3QY0ftYhPlvFhKSTpbPME+20VIgJV3OrI0ZKZxl1ZsVnozAJ703Q uW0g== X-Gm-Message-State: ACrzQf0JuySJQibQ9Ti5dATjuv5KyT59Zj9OXcGRX2xrxP5Avvm0VQzK C2Eh2CtvWo/rw+8X5QIqkJ5wFhP47ub5eClnFy04eY63q71Xiw== X-Google-Smtp-Source: AMsMyM64oZcjPrzk8b/116+pZvqgkwlLFjtaQQBJ7ft3RXLAQ2AP520WpRaeNpBTHtjGy6oYbUqwFITU7dU21HQKogo= X-Received: by 2002:a17:906:5daa:b0:78d:fa76:f837 with SMTP id n10-20020a1709065daa00b0078dfa76f837mr35511905ejv.239.1666778037042; Wed, 26 Oct 2022 02:53:57 -0700 (PDT) MIME-Version: 1.0 References: <20221024134409.1896776-1-zhangfei.gao@linaro.org> In-Reply-To: From: Zhangfei Gao Date: Wed, 26 Oct 2022 17:53:39 +0800 Message-ID: Subject: Re: [EXT] [PATCH resend v5 0/6] crypto/uadk: introduce uadk crypto driver To: Akhil Goyal Cc: Declan Doherty , Fan Zhang , Ashish Gupta , Ray Kinsella , "thomas@monjalon.net" , "dev@dpdk.org" , "acc@openeuler.org" Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, Akhil Thanks for your guidance. On Tue, 25 Oct 2022 at 23:02, Akhil Goyal wrote: > > > > Introduce a new crypto PMD for hardware accelerators based on UADK [1]. > > > > UADK is a framework for user applications to access hardware accelerators. > > UADK relies on IOMMU SVA (Shared Virtual Address) feature, which share > > the same page table between IOMMU and MMU. > > Thereby user application can directly use virtual address for device dma, > > which enhances the performance as well as easy usability. > > > > [1] https://github.com/Linaro/uadk > > > > Test: > > sudo dpdk-test --vdev=crypto_uadk (--log-level=6) > > RTE>>cryptodev_uadk_autotest > > RTE>>quit > > > > resend: > > fix uadk lib, still use > > There is nothing called as resend in DPDK ML. > Please simply increment version number each time you send the set. > > > Also add release notes update in the patch > where the driver implementation is complete. > > Compilation issues are all done now. > Have sent some other comments on the patches. Please send the v6 ASAP. > We need to close RC2 in a couple of days. > Got it, have addressed the comments and updated to v6 https://github.com/Linaro/dpdk/commits/next-9.11-v6 Will send tonight. Some uncertainty 1. The updated uadk.rst https://github.com/Linaro/dpdk/blob/next-9.11-v6/doc/guides/cryptodevs/uadk.rst 2. About the release notes change, Do I add a new patch in the last: 07 https://github.com/Linaro/dpdk/commit/f2294300662def012e00d5a3c5466bbf8436904b Or merge it to the first patch 01. 3. I update uadk.rst and test in the same patch, is that OK. https://github.com/Linaro/dpdk/commit/4be993e9995def1061dcfdd7863a7f2ba6d5da6c Thanks