From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua0-f196.google.com (mail-ua0-f196.google.com [209.85.217.196]) by dpdk.org (Postfix) with ESMTP id 7A3211D8E for ; Tue, 12 Dec 2017 07:34:15 +0100 (CET) Received: by mail-ua0-f196.google.com with SMTP id i4so13684601uab.5 for ; Mon, 11 Dec 2017 22:34:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=BghCTFXb1vY7ICGDOh3z9cidonxoDsJHvgwDI5OfRpI=; b=qc4Ox0EMkA+kjoglRpjWnB5hmETHhn0AIfd7ESrrciIAbEM9RqzoJaEzd0BA5Jt/CW rfR91dSXJPKuyxd5ZI/k72jD9zV1ou4ibtYiFwwS7C2Td7+kQIkTNIpjxBzI8FgTUh1G RYRtM9IbZVAM4SGMuM3gc1weyjnQQfjZa6okilrsw6D6zxCiMZmK1ABBUav//v96ZHtI 31enFZo8aBf/QyAKKpV1G69ZZxS2ziwhgAgTwOTaT1vMKQQ06+XwDD/1hRRsUXDU1/DQ T00NfXh7A0vIVLi8HPMPKCaobEZfcpftVph2oMQAabfzAXMXSIqtiODC63wRljQQJwMg S8zA== X-Gm-Message-State: AKGB3mL/fZA8BmeGbQkIv+0JNV1jcOk2IvbPFeTqWKpo9Mq0N8r5eqZb 2TfVhcRGHPK22zzaO9WVEFkT6DuW8lCYh/ugdCBjFQ== X-Google-Smtp-Source: ACJfBosJZikF8ChJRWfiTAh5tbvud8uYwoEcwBiVSXt7UmUNOstgQ7LWzDO4NME8agCBFIwGZpoxo+mTGieduAWlQ/E= X-Received: by 10.159.51.221 with SMTP id y29mr3144476uab.143.1513060454681; Mon, 11 Dec 2017 22:34:14 -0800 (PST) MIME-Version: 1.0 Received: by 10.103.52.199 with HTTP; Mon, 11 Dec 2017 22:34:14 -0800 (PST) In-Reply-To: <20171211151503.19195-1-maxime.coquelin@redhat.com> References: <20171211151503.19195-1-maxime.coquelin@redhat.com> From: Ladi Prosek Date: Tue, 12 Dec 2017 07:34:14 +0100 Message-ID: To: Maxime Coquelin Cc: dev@dpdk.org, yliu@fridaylinux.org, tiwei.bie@intel.com, jianfeng.tan@intel.com, Laszlo Ersek Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4 0/4] Vhost: fix mq=on but VIRTIO_NET_F_MQ not negotiated X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Dec 2017 06:34:15 -0000 On Mon, Dec 11, 2017 at 4:14 PM, Maxime Coquelin wrote: > Hi, > > This fourth revision fixes patch 1 by not returning early in > SET_FEATURE handling if new features bitfield is same as previous > one. Indeed, as reported by Tiwei, in case negotiated features is 0, > it would return early whereas it should set the Vnet header len. > The change consists in returning early when features are equal only > when the device is un running state. > I did not applied Laszlo's Acked-by and Ladi's Tested-by because of > this change. This new iteration has been tested locally using iPXE. > > Having QEMU started with mq=on but guest driver not negotiating > VIRTIO_NET_F_MQ feature ends up in the vhost device to never > start. Indeed, more queues are created in the vhost backend than > configured. > > Guest drivers known to not advertise the VIRTIO_NET_F_MQ feature are > iPXE and OVMF Virtio-net drivers. > > Queues are created because before starting the guest, QEMU sends > VHOST_USER_SET_VRING_CALL requests for all queues declared in QEMU > command line. Also, once Virtio features negotiated, QEMU sends > VHOST_USER_SET_VRING_ENABLE requests to disable all but the first > queue pair. > > This series fixes this by destroying all but first queue pair in > the backend if VIRTIO_NET_F_MQ isn't negotiated. First patches > makes sure that VHOST_USER_SET_FEATURES request doesn't change > Virtio features while the device is running, which should never > happen as per the Virtio spec. This helps to make sure vitqueues > aren't destroyed while being processed, but also protect from > other illegal features changes (e.g. VIRTIO_NET_F_MRG_RXBUF). > > Changes since v3: > ================= > - Fix Virtio features = 0 case (Tiwei) > Changes since v2: > ================= > - Patch 2: Rework & fix VQs destruction loop (Laszlo) > Changes since v1: > ================= > - Patch 1: shift bits in the right direction (Ladi) > > Maxime Coquelin (4): > vhost: prevent features to be changed while device is running > vhost: propagate VHOST_USER_SET_FEATURES handling error > vhost: extract virtqueue cleaning and freeing functions > vhost: destroy unused virtqueues when multiqueue not negotiated > > lib/librte_vhost/vhost.c | 22 ++++++++++++---------- > lib/librte_vhost/vhost.h | 3 +++ > lib/librte_vhost/vhost_user.c | 39 +++++++++++++++++++++++++++++++++++++-- > 3 files changed, 52 insertions(+), 12 deletions(-) Tested v4 with iPXE and confirming that it still works fine. Tested-by: Ladi Prosek Thank you! Ladi