From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa0-x22b.google.com (mail-oa0-x22b.google.com [IPv6:2607:f8b0:4003:c02::22b]) by dpdk.org (Postfix) with ESMTP id 768235323 for ; Mon, 27 Jan 2014 20:03:38 +0100 (CET) Received: by mail-oa0-f43.google.com with SMTP id h16so7171878oag.2 for ; Mon, 27 Jan 2014 11:04:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=66LPpuxksxG0LLErFUaNRBLMAwoR9sA4K0qERv0MZRA=; b=ile2lMhzVqmwjQXnTLlwQvXoRbLpzL94oqzQuOrB0e5ySEHRg1EeT0kEFPpbbSdmI/ FMvJDNrjZ21/Q5PC0hDRnK2Zdt779MOy/Pyd0pSite1qTiKMUaksIEPLfUg78bMP1yEW G32SHJtnBq8pD+zgGnUIAACFlLxRI0zh0xGvpVSn3YDl5ZW4J17ti6OK6toET2uI31jm xs/AvXSMk401z6FEqs2eMK/XGAvFozGeZ/WZS8FpZwJSMVJmvFo03qatd6C8qNxS3R8I vr8XuvO02pAizg/oCC4aW3i4FZMs7bIybCX5LH+BHsWZlYEMZ9aZhfG/imK409ze2M7f 8cIA== X-Received: by 10.60.157.130 with SMTP id wm2mr15165264oeb.31.1390849496157; Mon, 27 Jan 2014 11:04:56 -0800 (PST) MIME-Version: 1.0 Received: by 10.182.191.104 with HTTP; Mon, 27 Jan 2014 11:04:36 -0800 (PST) In-Reply-To: <7B58AC42-4409-4448-A748-BADA7F37E32C@windriver.com> References: <4FE91E82-8097-451E-A36D-2F1254573A89@windriver.com> <7B58AC42-4409-4448-A748-BADA7F37E32C@windriver.com> From: Banashankar KV Date: Mon, 27 Jan 2014 11:04:36 -0800 Message-ID: To: "Wiles, Roger Keith" Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "" Subject: Re: [dpdk-dev] pktgen offload checksum flag not able to make it work with pacp packets. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jan 2014 19:03:38 -0000 Hi, In pktgen.c, tx_conf have a flag txq_flags which is set to IXGBE_SIMPLE_FLAGS which inturn has value ETH_TXQ_FLAGS_NOOFFLOADS which is defined in rte_ethdev.h and has values which disables all kind of chksum offloads. So once I commented off that particular flag, offload started working. Yea I was also thinking same about the tcp checksum. Thanks Banashankar On Sat, Jan 25, 2014 at 6:46 PM, Wiles, Roger Keith < keith.wiles@windriver.com> wrote: > Hi Banashankar, > > The tx_conf is used in the pktgen_config_ports() with the > rte_eth_tx_queue_setup() and I am not sure why it matters that tx_conf is > disable. The values are mostly zero, but some type of interaction must be > going on. It may be the txq_flags being set to IXGBE_SIMPLE_FLAGS and it > is overriding the the per packet flag later. You will need to look at the > driver to determine the real reason. > > The checksum should not be wrong unless the hardware registers are not > setup correctly, but I would not think that is the case. You may want to > verify the checksum is correct another way, because I can not see the > hardware doing the checksum wrong. > > Thanks > ++Keith > > > *Keith Wiles*, Principal Technologist for Networking member of the CTO > office, *Wind River* > mobile 940.213.5533 > [image: Powering 30 Years of Innovation] > > On Jan 25, 2014, at 4:53 PM, Banashankar KV wrote: > > Hi, > Thanks a lot for the reply ! > Yes I have checked those examples and had set all those flags. But IP > checksum started working after commenting off the txq_flags from > the pktgen.c file's tx_conf . > > And I added the following flag to calculate the tcp checksum. > > m->ol_flags |= PKT_TX_TCP_CKSUM > > its calculating the TCP checksum but turning out to be wrong checksum. > > Thanks > Banashankar > > > > On Fri, Jan 24, 2014 at 11:44 AM, Wiles, Roger Keith < > keith.wiles@windriver.com> wrote: > >> I have not enabled that feature myself, but I would expect it to work as >> long as the hardware does. What does the docs say about enabling hardware >> offload support? Did you look at the following files: >> >> ip_reassembly/ipv4_rsmbl.h: m->ol_flags |= PKT_TX_IP_CKSUM; >> ipv4_frag/rte_ipv4_frag.h: out_pkt->ol_flags |= >> PKT_TX_IP_CKSUM; >> >> Thanks >> ++Keith >> >> *Keith Wiles*, Principal Technologist for Networking member of the >> CTO office, *Wind River* >> mobile 940.213.5533 >> [image: Powering 30 Years of Innovation] >> >> On Jan 24, 2014, at 12:54 PM, Banashankar KV >> wrote: >> >> I was modifying a packet in pktgen_pcap_mbuf_ctor() >> and after modifying I wanted to offload the checksum calculation to h/w >> so I am setting these flags in pktgen_pcap_mbuf_ctor function. >> >> m->pkt.vlan_macip.f.l2_len = sizeof(struct ether_hdr); >> m->pkt.vlan_macip.f.l3_len = sizeof(struct ipv4_hdr); >> >> m->ol_flags = PKT_TX_IP_CKSUM >> >> >> I even tried with setting .txq_flags = 0 in rte_eth_txconf struct in >> pktgen.c. >> >> But still not able to get the h/w checksum. Am I missing anything ? >> >> >> >> Thanks >> Banashankar >> >> >> > >