From: Sarosh Arif <sarosh.arif@emumba.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] doc: replace testpmd with ./<build_dir>/app/dpdk-testpmd in all commands
Date: Thu, 11 Feb 2021 12:06:43 +0500 [thread overview]
Message-ID: <CABoZmYNGMo4X+O-HNJsfJJ2EMNCk39892+M6zi4Q5ob56DtG9w@mail.gmail.com> (raw)
In-Reply-To: <1c18a75e-6a0e-d3ca-aa08-0c4baf875113@intel.com>
Yes, I think we can drop the relative path. I'll make this change in
the next version.
On Wed, Feb 10, 2021 at 5:54 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> On 2/10/2021 11:56 AM, Sarosh Arif wrote:
> > replace testpmd with ./<build_dir>/app/dpdk-testpmd in all commands
> > because on compilation through meson, dpdk-testpmd is the default
> > application name.
> >
> > Signed-off-by: Sarosh Arif <sarosh.arif@emumba.com>
> > ---
> > doc/guides/nics/bnxt.rst | 8 ++++----
> > doc/guides/nics/e1000em.rst | 2 +-
> > doc/guides/nics/kni.rst | 4 ++--
> > doc/guides/nics/mlx4.rst | 2 +-
> > doc/guides/nics/mlx5.rst | 2 +-
> > doc/guides/nics/qede.rst | 2 +-
> > doc/guides/nics/virtio.rst | 2 +-
> > 7 files changed, 11 insertions(+), 11 deletions(-)
> >
> > diff --git a/doc/guides/nics/bnxt.rst b/doc/guides/nics/bnxt.rst
> > index 801ec3ca5..1e2f78a2e 100644
> > --- a/doc/guides/nics/bnxt.rst
> > +++ b/doc/guides/nics/bnxt.rst
> > @@ -361,7 +361,7 @@ The application enables multiple TX and RX queues when it is started.
> >
> > .. code-block:: console
> >
> > - testpmd -l 1,3,5 --main-lcore 1 --txq=2 –rxq=2 --nb-cores=2
> > + ./<build_dir>/app/dpdk-testpmd -l 1,3,5 --main-lcore 1 --txq=2 –rxq=2 --nb-cores=2
> >
>
> Ok to replace 'testpmd' -> 'dpdk-testpmd', but do we really need to add the
> relative path?
> Users can be calling the application from installed folder, and this additional
> information brings additional maintenance cost with a small to none benefit,
> what do you think to drop the folder path?
next prev parent reply other threads:[~2021-02-11 7:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 11:56 Sarosh Arif
2021-02-10 12:54 ` Ferruh Yigit
2021-02-11 7:06 ` Sarosh Arif [this message]
2021-02-11 7:19 ` [dpdk-dev] [v2 PATCH] doc: replace testpmd with dpdk-testpmd " Sarosh Arif
2021-02-11 9:31 ` Bruce Richardson
2021-02-11 16:12 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABoZmYNGMo4X+O-HNJsfJJ2EMNCk39892+M6zi4Q5ob56DtG9w@mail.gmail.com \
--to=sarosh.arif@emumba.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).