From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 6A088A04AF;
Mon, 28 Sep 2020 11:56:03 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 4DBC91D6F8;
Mon, 28 Sep 2020 11:55:47 +0200 (CEST)
Received: from mail-ot1-f68.google.com (mail-ot1-f68.google.com
[209.85.210.68]) by dpdk.org (Postfix) with ESMTP id 387551D6F8
for <dev@dpdk.org>; Mon, 28 Sep 2020 11:55:44 +0200 (CEST)
Received: by mail-ot1-f68.google.com with SMTP id n61so294913ota.10
for <dev@dpdk.org>; Mon, 28 Sep 2020 02:55:44 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=emumba-com.20150623.gappssmtp.com; s=20150623;
h=mime-version:references:in-reply-to:from:date:message-id:subject:to
:cc; bh=HiNBInMFx8lRzqvqI7vsWIlK1/gQk5Tlu99PoK2imQc=;
b=cCZSemJmxz46UWh7/ZOBXmVnZEo5v+0n3/DSvtHrhRfHIxGy3q54R8/sXAeMzhnpDi
hMhnrUh6VyzWL43Pm51btR6UmlP+8SzDE58Ga4I83K9/gHBp7sbwdDDzH7SBAjhWScxg
igUAInAfzGM8VDZdwNyEAoGMdTDZ9YsFiki6ELlh2mvtuFSJCmf4lUN8o85JIhrOwhrN
gpnq7XpOO7gbieSMxHqbNzMDAw1zOLWGXoWmZZDibidBsAe8lSTcnVcUjnQDpHI55U+c
n1Oko8hS3XXypGyjbTeEg7y6zPpXGEZ8WO//vSBlBr/jSE+E7bsMcLGOHpRNCZoBSS/+
V/OQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=HiNBInMFx8lRzqvqI7vsWIlK1/gQk5Tlu99PoK2imQc=;
b=j4OEUt4dtUqVbnLkDKWv1Wt6vhSP/HYDnuFhpDNiZNRE+uBjre/YXwP9rQ3qA7r15s
ao6nqtM2NliRUcwRG2eWLqIdi9kh69tiwjE66IfUVHDzjDz/OkvHLu0gxZ3pe/JofKV7
JDraIQk4VaN79l/Nxu84JbRSKCnpOJXoPmvE4mnnrNll69Tu8oPPgZKFxC2sSPHfb1L4
OvGS0b14xpa92TY0wkw84lwnHTVU5XT+o8WVdDGXLhmgUOUmZL5Cu9WRIwtr1aDqpaR3
22j2T5DIUaSRWyOTrWjtWe9SJbk5n6YHWq4tdJG6d5DuKv9mZ+4wLsRFkCeTsBDE12DK
Dz4w==
X-Gm-Message-State: AOAM530xPY/BdSC/3hzFYDXLg4Ivm6ZPg6zXdyHN9auCysxpesPpCbC5
eY04eF9YYHkblxskPbdn2MB34jlUcJ5rhtRAA7dpCg==
X-Google-Smtp-Source: ABdhPJzGwo/cZZ8JsL7ydLmIaafOfEZpGIiqc7azNo2qEzx6K85/+HIQ6Nr7FDXYz22i4TrqM70fqAxLPoT2nmj+jNY=
X-Received: by 2002:a9d:7459:: with SMTP id p25mr373588otk.234.1601286942443;
Mon, 28 Sep 2020 02:55:42 -0700 (PDT)
MIME-Version: 1.0
References: <20200415064238.24012-1-sarosh.arif@emumba.com>
<20200908102204.727240-1-sarosh.arif@emumba.com>
<CAJFAV8zU-4ZWx4Q0vOWja6KNfubZ0ow+1_UtUSrihd+FQffqSg@mail.gmail.com>
In-Reply-To: <CAJFAV8zU-4ZWx4Q0vOWja6KNfubZ0ow+1_UtUSrihd+FQffqSg@mail.gmail.com>
From: Sarosh Arif <sarosh.arif@emumba.com>
Date: Mon, 28 Sep 2020 14:55:06 +0500
Message-ID: <CABoZmYNHaOZVBTi11nNeva-=hU91MbgEq_6ukssUSx1o9T9zMA@mail.gmail.com>
To: David Marchand <david.marchand@redhat.com>
Cc: David Hunt <david.hunt@intel.com>,
Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>, dev <dev@dpdk.org>
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [v3 PATCH] test_distributor: prevent memory leakages
from the pool
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On Fri, Sep 25, 2020 at 7:22 PM David Marchand <david.marchand@redhat.com>
wrote:
> On Tue, Sep 8, 2020 at 12:22 PM Sarosh Arif <sarosh.arif@emumba.com>
> wrote:
> >
> > rte_mempool_get_bulk is used to get bufs/many_bufs from the pool,
> > but at some locations when test fails the bufs/many_bufs are
> > not returned back to the pool.
> > Due to this, multiple executions of distributor_autotest gives the
> > following error message: Error getting mbufs from pool.
> > To resolve this issue rte_mempool_put_bulk is used whenever the test
> > fails and returns.
> >
> > Signed-off-by: Sarosh Arif <sarosh.arif@emumba.com>
>
> It deserves a Fixes: line.
>
Fixes: c3eabff124e6 ("distributor: add unit tests")
Should I submit another version of this patch to add fixes?
>
> I can see a ack from Lukasz.
> David, review please?
>
>
> --
> David Marchand
>
>