DPDK patches and discussions
 help / color / mirror / Atom feed
From: Sarosh Arif <sarosh.arif@emumba.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: rsanford@akamai.com, erik.g.carrillo@intel.com, dev@dpdk.org,
	 stable@dpdk.org, h.mikita89@gmail.com
Subject: Re: [dpdk-dev] [PATCH v2] lib/librte_timer:fix corruption with reset
Date: Thu, 9 Jul 2020 12:02:17 +0500
Message-ID: <CABoZmYOk-i767efePF5UMTbX9ta9MFxhsRbZb-TMa_EmZm6nNw@mail.gmail.com> (raw)
In-Reply-To: <20200708080848.569e8dcd@hermes.lan>

On Wed, Jul 8, 2020 at 8:08 PM Stephen Hemminger <stephen@networkplumber.org>
wrote:

> On Wed,  8 Jul 2020 10:06:26 +0500
> Sarosh Arif <sarosh.arif@emumba.com> wrote:
>
> >  rte_timer_stop_sync(struct rte_timer *tim)
> >  {
> > +     struct rte_timer_data *timer_data;
> > +     TIMER_DATA_VALID_GET_OR_ERR_RET(default_data_id, timer_data,
> -EINVAL);
> > +     unsigned int lcore_id = rte_lcore_id();
>
> This mixing code and declarations. since the macro has a return statement.
>
> Maybe:
>
>         struct rte_timer_data *timer_data;
>         unsigned int lcore_id = rte_lcore_id();
>
>         TIMER_DATA_VALID_GET_OR_ERR_RET(default_data_id, timer_data,
> -EINVAL);
>
I will fix this in the next version.

  reply	other threads:[~2020-07-09  7:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-07  9:03 [dpdk-dev] [PATCH] " Sarosh Arif
2020-07-07 16:09 ` Stephen Hemminger
2020-07-08  5:06 ` [dpdk-dev] [PATCH v2] " Sarosh Arif
2020-07-08 15:07   ` Stephen Hemminger
2020-07-09  7:05     ` Sarosh Arif
2020-07-08 15:08   ` Stephen Hemminger
2020-07-09  7:02     ` Sarosh Arif [this message]
2020-07-10  6:59 ` [dpdk-dev] [PATCH v3] " Sarosh Arif
2020-07-10 15:19   ` Stephen Hemminger
2020-07-28 19:04   ` Carrillo, Erik G

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABoZmYOk-i767efePF5UMTbX9ta9MFxhsRbZb-TMa_EmZm6nNw@mail.gmail.com \
    --to=sarosh.arif@emumba.com \
    --cc=dev@dpdk.org \
    --cc=erik.g.carrillo@intel.com \
    --cc=h.mikita89@gmail.com \
    --cc=rsanford@akamai.com \
    --cc=stable@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git