From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E9859A0526; Thu, 9 Jul 2020 09:02:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C2FA21DBF2; Thu, 9 Jul 2020 09:02:55 +0200 (CEST) Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by dpdk.org (Postfix) with ESMTP id 957321DBB4 for ; Thu, 9 Jul 2020 09:02:53 +0200 (CEST) Received: by mail-io1-f67.google.com with SMTP id e64so1200510iof.12 for ; Thu, 09 Jul 2020 00:02:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=emumba-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bxFgSYliSO4SJk14Xecm+sfoue16dOt2NddnOU7V548=; b=EoyCF86a623jBsNzon3pe5larYfZuuRTVUv1JFoJWfSMFOvG0OOOX1Ing1S0C2bROZ 00dhBe9NsFiayvyjxS23mjlsrObFMWfvaFbzf4Nt2deKr4kjtEPMOMZiQp95w4N4sa7+ n3VFHX9ZCgWKA8REF5hgb9mpL6CMbM2EMcAP4lSkQ9C4MaaoO92pPbDTSrgNtg7b4lbq /j+W+qhr+y5vxzMWSAo0md1K8w1qL0zk6Rlnnvt3LljHYm4SMSlFr/rYhDyAgro0Gwog 0vkNvpACiuA7HGrihLlu0VmGEVtngZlZiE+/ZrQDo9j+VsCmCboV0ekDAK064Gp/rDqq gbUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bxFgSYliSO4SJk14Xecm+sfoue16dOt2NddnOU7V548=; b=lhtMgCMqvpmbsMzAABmNcr1vIek+VbVcUD6yR/6bPaLYPuganuwtfnq00mD+DLGXlX 9+mRhK+2UDiqr6kvZ2SSaEQ6R/08R+3NTKm3E4v0wLBvawKzbvJBGIANJzn0Y1cKLB+d IGpwHtWYkPyKyCOTUSlZ7UKX8x1HoDCYwfzGU3stOIENG1X+8iIJOBWTCXj+MPGSodPV FVjYNkI0hL0Z4lorXkzvA493DVx7/wUm6nla3p1ruBiKPxYa160f8xQbNRZuaeZcU6vW BnTop3EEvc/huxrQ8XObe4eD9M5FcjRhu8H1DLMqtDgNf5ZmQPVYvMg13G409fAR+Kpg fdew== X-Gm-Message-State: AOAM532TbORp+13uwlcVyVe4IBXsMJz5nx7hwx6axoFF1T67ivVSX03U Bkch+OSwiYx+FYqRTvxFP5+6Z3hwdJPP9sRy0s+eDA== X-Google-Smtp-Source: ABdhPJzrq5hDcYZX6sKKiRWGFEoLUurFRxa0BIaIleprxu1vyu5ZqC1nBdB52uMMLI9w6hQSGCSH0bogVlo7QkJ7ggo= X-Received: by 2002:a02:601c:: with SMTP id i28mr71970135jac.22.1594278172836; Thu, 09 Jul 2020 00:02:52 -0700 (PDT) MIME-Version: 1.0 References: <20200707090320.2463-1-sarosh.arif@emumba.com> <20200708050626.23512-1-sarosh.arif@emumba.com> <20200708080848.569e8dcd@hermes.lan> In-Reply-To: <20200708080848.569e8dcd@hermes.lan> From: Sarosh Arif Date: Thu, 9 Jul 2020 12:02:17 +0500 Message-ID: To: Stephen Hemminger Cc: rsanford@akamai.com, erik.g.carrillo@intel.com, dev@dpdk.org, stable@dpdk.org, h.mikita89@gmail.com Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2] lib/librte_timer:fix corruption with reset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jul 8, 2020 at 8:08 PM Stephen Hemminger wrote: > On Wed, 8 Jul 2020 10:06:26 +0500 > Sarosh Arif wrote: > > > rte_timer_stop_sync(struct rte_timer *tim) > > { > > + struct rte_timer_data *timer_data; > > + TIMER_DATA_VALID_GET_OR_ERR_RET(default_data_id, timer_data, > -EINVAL); > > + unsigned int lcore_id = rte_lcore_id(); > > This mixing code and declarations. since the macro has a return statement. > > Maybe: > > struct rte_timer_data *timer_data; > unsigned int lcore_id = rte_lcore_id(); > > TIMER_DATA_VALID_GET_OR_ERR_RET(default_data_id, timer_data, > -EINVAL); > I will fix this in the next version.