From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 24699454F1; Tue, 25 Jun 2024 13:53:03 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F00E7433F2; Tue, 25 Jun 2024 13:52:53 +0200 (CEST) Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) by mails.dpdk.org (Postfix) with ESMTP id EE16E42793 for ; Tue, 25 Jun 2024 13:49:41 +0200 (CEST) Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-a6f8ebbd268so1060807566b.0 for ; Tue, 25 Jun 2024 04:49:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netgate.com; s=google; t=1719316181; x=1719920981; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=MszXa6on3PhBhQj6A9TTm2Sn+thR/1knwxPNQ8swZdo=; b=EMBsisvLU6Z6sR9ORwLvCHB3ZySfyuqlaleQfZ4a0s4anORyH5nW5qOkIshnLRqLgi vxUaoF9aWzDa/6UW1278BxLDLeLM4cVxfsmtWsDsVmoAm5VnAQJhF/wNxwZ2kwUh93Ro puqVJxs2kyifOUsdxrzP3PMGnKSTrHWZaADOE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719316181; x=1719920981; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MszXa6on3PhBhQj6A9TTm2Sn+thR/1knwxPNQ8swZdo=; b=YHpdpWp10qG/aiUzPPxKbc0UbSonQ30jM/rjMcFJcrvN1zcgNpByR7Twc1R5XPXTfL OlbGpr5Xp6o3SiebiEZQdo7zTWj7IJzr3/zjEJzEBB+b+UwzXQqq2ftzf1Km36pLur81 AR9x0x/NKFuZ4uNEemv8n1kGPS5t2YXuEbEMOGVV/ks/Qda1ydESGV6S2X6Gt9HfRDcd ZO8luh3JxaV1II83eFQfkexqDyol5YZVljuzi4+opwrJAG8XYCI+P7u4VStvybvVmu2H mfJikNkIlFycerskpJlxSkoeKa/7zSPL3Cwd0PNblbtXasb+Ph7KOvBSgwwFYZn+i4ln aAZg== X-Forwarded-Encrypted: i=1; AJvYcCVkbsWE0ra7LP80iKS4DinWx+S1dz5u+gWNTOxaVX3UHB9nXmmRBxADQoUj9/UgBU7f1dGJrEFDRWx+fwk= X-Gm-Message-State: AOJu0YxkOjbX+SDgJELjMMJm2EG/qhBWkaWZR1cWMddlfYUWEOQ2rL/H ixxlBFXchOgABqkANPI6lQlA/1XqtnNknAQFyBU3I8JKULPEgezGYhDhlfY4ESs2GFyQ5FhNRU5 DuOCrooX+Zwc3m09LWTury4HV7IeF9HRYfThi X-Google-Smtp-Source: AGHT+IEHM4uybzO5zOZ8wB+Wy5YwYr27NkJBt8FNRbup+idmGwL0sEWK5oRUOpuF4kksL1u7Rne2Mhu/WBu8XYWKY2Y= X-Received: by 2002:a17:907:7216:b0:a72:62e0:6636 with SMTP id a640c23a62f3a-a727fc73787mr4625866b.24.1719316181518; Tue, 25 Jun 2024 04:49:41 -0700 (PDT) MIME-Version: 1.0 References: <20240624110415.3230-1-vratnikov@netgate.com> <20240624111521.3253-1-vratnikov@netgate.com> <20240624170234.50f1e213@hermes.local> In-Reply-To: <20240624170234.50f1e213@hermes.local> From: Vladimir Ratnikov Date: Tue, 25 Jun 2024 13:49:31 +0200 Message-ID: Subject: Re: [PATCH v2] bus/vmbus: add device_order field to rte_vmbus_dev To: Stephen Hemminger Cc: longli@microsoft.com, dev@dpdk.org Content-Type: multipart/alternative; boundary="000000000000419f7e061bb57ea3" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --000000000000419f7e061bb57ea3 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks for review! Regarding to > The patch only has the device_order field, but it is set but not used > anywhere in the DPDK. Unfortunately, It's not for DPDK usage, it's for DPDK based applications. After some time of testing, if nothing's changed in the host OS(no new devices, no removed devices) - the device list is always the same with the same order. On Tue, Jun 25, 2024 at 2:02=E2=80=AFAM Stephen Hemminger < stephen@networkplumber.org> wrote: > On Mon, 24 Jun 2024 11:15:21 +0000 > Vladimir Ratnikov wrote: > > > Field can be used to have static interface naming > > in DPDK based applications instead of uuid. > > RTE_FOREACH_DEV won't return the correct order of > > such devices due to vmbus_ignore_device in case of > > blocklisting/allowlisting. So device_order field > > will be helpful in that case. > > > > Signed-off-by: Vladimir Ratnikov > > --- > > Not sure the order of device discovery is predictable. > The order of devices on vmbus is when they were reported by the host OS. > That is why Linux driver use other ways to have persistent naming. > --000000000000419f7e061bb57ea3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks for review!

Regarding to=C2=A0
The patch only has the device_order field, but it is set but not used anyw= here in the DPDK.=C2=A0
Unfortunately, It's not= for DPDK usage, it's for DPDK based applications.
After some time o= f testing, if nothing's changed in the host OS(no new devices, no remov= ed devices) - the device list is always the same with the same order.
=

= On Tue, Jun 25, 2024 at 2:02=E2=80=AFAM Stephen Hemminger <stephen@networkplumber.org> wrote:<= br>
On Mon, 24 Jun 2= 024 11:15:21 +0000
Vladimir Ratnikov <vratnikov@netgate.com> wrote:

> Field can be used to have static interface naming
> in DPDK based applications instead of uuid.
> RTE_FOREACH_DEV won't return the correct order of
> such devices due to vmbus_ignore_device in case of
> blocklisting/allowlisting. So device_order field
> will be helpful in that case.
>
> Signed-off-by: Vladimir Ratnikov <vratnikov@netgate.com>
> ---

Not sure the order of device discovery is predictable.
The order of devices on vmbus is when they were reported by the host OS. That is why Linux driver use other ways to have persistent naming.
--000000000000419f7e061bb57ea3--