From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 12B5AA00E6
	for <public@inbox.dpdk.org>; Thu,  8 Aug 2019 15:08:02 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id A67781BE3E;
	Thu,  8 Aug 2019 15:08:01 +0200 (CEST)
Received: from mail-ot1-f65.google.com (mail-ot1-f65.google.com
 [209.85.210.65]) by dpdk.org (Postfix) with ESMTP id 1061C1BE3A
 for <dev@dpdk.org>; Thu,  8 Aug 2019 15:08:00 +0200 (CEST)
Received: by mail-ot1-f65.google.com with SMTP id r6so118222286oti.3
 for <dev@dpdk.org>; Thu, 08 Aug 2019 06:08:00 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=RYei1IFE3szk2gp9ZwoPUE8382FjFEnyMnv9MUG3+AE=;
 b=TUIHt9OIjM7wSwQ6WU/qlQT0BYVAawrQSAb10nHabOqWFsamSjsXuXP2SWkrj+VVfK
 8aRVGYk77CDWHuEtbzNCefmfSE3Y3OLoWlzGDtlUTpMQO9/MazHa9XDnJANgw8VUhWij
 HmswswnZqlBjn3SHWWmqSA6ZxO4yxD33BwEAGmQgtxO4I32msNv+A2IGvh2YF9E9DXLN
 Q2opRRuSzoX3Q69NPsRBFe+qJZk/zod7/HKLh736dTuOAEH4wqplGHHm7CLJpoXNgRTW
 VSyAktyMFygOjsyn4QQ0gR9lxkvOeAICgPsXF5tKius4S/0Cd102nZC/DwrhnxrrX2v3
 jA8Q==
X-Gm-Message-State: APjAAAWIiZ+27V/Ds0dEGuIHiiUl514wvRvhJwRr7LyxHAlJJdyB+aSx
 PaDOo0YUnmRWqM98XcQ5BpiBZ+hoLqAKF+DSqLH66g==
X-Google-Smtp-Source: APXvYqyPYnAl12UKfIbBg276xrBjl+trj9YiuQQc/w8pwJ8veGEey5Y9jaW8bQW2vNKcSvaEz0ZGXxTfMKcAjsB9pkE=
X-Received: by 2002:a02:1087:: with SMTP id 129mr16942035jay.131.1565269679455; 
 Thu, 08 Aug 2019 06:07:59 -0700 (PDT)
MIME-Version: 1.0
References: <1565266937-8159-1-git-send-email-david.marchand@redhat.com>
In-Reply-To: <1565266937-8159-1-git-send-email-david.marchand@redhat.com>
From: Michael Santana Francisco <msantana@redhat.com>
Date: Thu, 8 Aug 2019 09:07:47 -0400
Message-ID: <CABzctQ-41Z8X1QypAH+_qhhDZT2Ud=NFJTkRbi8fYcPNUgN-ig@mail.gmail.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, Aaron Conole <aconole@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH] ci: exit setup on any error
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Aug 8, 2019 at 8:22 AM David Marchand <david.marchand@redhat.com> wrote:
>
> -e is preferrable so that we can catch errors in the middle of this
> script.
> An example is this Travis job [1] that should have errored at the meson
> install step rather than go to the build step.
>
> Adding debug mode as it can help post-mortem.
>
> 1: https://travis-ci.com/DPDK/dpdk/jobs/223511683
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Michael Santana <msantana@redhat.com>
> ---
>  .ci/linux-setup.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.ci/linux-setup.sh b/.ci/linux-setup.sh
> index a40e62e..dfb9d4a 100755
> --- a/.ci/linux-setup.sh
> +++ b/.ci/linux-setup.sh
> @@ -1,4 +1,4 @@
> -#!/bin/sh
> +#!/bin/sh -xe
>
>  # need to install as 'root' since some of the unit tests won't run without it
>  sudo python3 -m pip install --upgrade meson
> --
> 1.8.3.1
>