From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AA7C4A10DA for ; Wed, 31 Jul 2019 22:55:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C34811BF12; Wed, 31 Jul 2019 22:54:59 +0200 (CEST) Received: from mail-io1-f65.google.com (mail-io1-f65.google.com [209.85.166.65]) by dpdk.org (Postfix) with ESMTP id 0DFF61BEC0 for ; Wed, 31 Jul 2019 22:54:58 +0200 (CEST) Received: by mail-io1-f65.google.com with SMTP id z3so20518490iog.0 for ; Wed, 31 Jul 2019 13:54:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/eGJ4yqDMydae3yRYn9pWqiZX3VgNaC5kjUxt8kkqYs=; b=gncl2s0hBy3KOu4eB73yHQ7y3VQ/kMOXE8HWQ4fZCqFugXK+TZ2iZn5dRk0JdvuXJZ i0knyJ1PgDJnrBljIkyKYHvI906AAsmsrlyMaKjc+wjHM9Nl7LyJKykr40C10Og2Rk4x OsnsxtlE6rNiMuY47YRFk4Jgk/kwb/i3oOiTN8+D/UJPBLQwXE0A7XnmtV6fQpij52uk 5dhaHi0QyCtztfASaIQUiymAQady1Fsqe4q+YSI4yRYbUtx26Q8HqOrjatm3jClvYeuF /qg5J1emdh8p8rgibC48N6l0PS/hfsgHZiOtzksNvIpIGpuwwM3WfDzpwaAnlaUxlNdj rWJg== X-Gm-Message-State: APjAAAU3Yh/QHSjkIbUt6N2xUv2IzR9dM6oD5MuQuB4rebREx22l9zh9 iO7AqQg2TOSaCS9rkzShKfoLUSJef4uSfTqp7cX/IQ== X-Google-Smtp-Source: APXvYqzi6Snl0BI5ffb8JGPw4luWFuuzzdNdjchMD6XQR751rnZFYmeM7OwZI8FQ7thgjgjjHzejyIY8tLA1jaJ4P1M= X-Received: by 2002:a6b:621a:: with SMTP id f26mr104457412iog.127.1564606497387; Wed, 31 Jul 2019 13:54:57 -0700 (PDT) MIME-Version: 1.0 References: <20190731145030.19956-1-aconole@redhat.com> <20190731145030.19956-3-aconole@redhat.com> In-Reply-To: <20190731145030.19956-3-aconole@redhat.com> From: Michael Santana Francisco Date: Wed, 31 Jul 2019 16:54:46 -0400 Message-ID: To: Aaron Conole Cc: dev , David Marchand , Bruce Richardson , Ferruh Yigit , Luca Boccassi Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 2/2] ci: enable unit tests under travis-ci X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jul 31, 2019 at 10:50 AM Aaron Conole wrote: > > When building under Travis (or another linux CI service), enable running the > fast-tests for selected builds. Only the shared builds are enabled at this > point, since they are the ones passing. Builds that are statically linked > still show some issues in some of the eal_flags tests. Additionally, > the command to invoke fast tests includes a timeout multiplier, since > some CI environments don't have enough resources to complete the tests in > the default 10s timeout period. > > Signed-off-by: Aaron Conole > --- > .ci/linux-build.sh | 8 ++++++++ > .ci/linux-setup.sh | 8 +++++++- > .travis.yml | 9 ++++++++- > 3 files changed, 23 insertions(+), 2 deletions(-) > > diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh > index d5783c1a4..75f740648 100755 > --- a/.ci/linux-build.sh > +++ b/.ci/linux-build.sh > @@ -22,3 +22,11 @@ fi > OPTS="$OPTS --default-library=$DEF_LIB" > meson build --werror -Dexamples=all $OPTS > ninja -C build > + > +if [ "$RUN_TESTS" = "1" ]; then > + # On the test build, also build the documentation, since it's expensive > + # and we shouldn't need to build so much of it. > + ninja -C build doc > + > + sudo meson test -C build --suite fast-tests -t 3 > +fi > diff --git a/.ci/linux-setup.sh b/.ci/linux-setup.sh > index acdf9f370..a40e62eaa 100755 > --- a/.ci/linux-setup.sh > +++ b/.ci/linux-setup.sh > @@ -1,3 +1,9 @@ > #!/bin/sh > > -python3 -m pip install --upgrade meson --user > +# need to install as 'root' since some of the unit tests won't run without it > +sudo python3 -m pip install --upgrade meson > + > +# setup hugepages > +cat /proc/meminfo > +sudo sh -c 'echo 1024 > /proc/sys/vm/nr_hugepages' > +cat /proc/meminfo Can we drop cat /proc/meminfo? > diff --git a/.travis.yml b/.travis.yml > index 7b167fa64..c0c27bb7f 100644 > --- a/.travis.yml > +++ b/.travis.yml > @@ -30,6 +30,7 @@ env: > - DEF_LIB="shared" > - DEF_LIB="static" OPTS="-Denable_kmods=false" > - DEF_LIB="shared" OPTS="-Denable_kmods=false" > + - DEF_LIB="shared" RUN_TESTS=1 I don't agree with this. This is redundant. Why not put RUN_TESTS=1 on an already exiting builds instead of adding two new builds like you are doing here? A build without the tests takes ~7 minutes, with the tests it increases to ~9 minutes. These two new builds add ~18 minutes of build time to the entire travis build time. We could use this ~18 minutes instead to run the tests on 6 to 9 already existing builds since they take 2 to 3 extra minutes on each one. > > matrix: > include: > @@ -51,7 +52,7 @@ matrix: > apt: > packages: > - *extra_packages > - - env: DEF_LIB="shared" EXTRA_PACKAGES=1 > + - env: DEF_LIB="shared" EXTRA_PACKAGES=1 RUN_TESTS=1 > compiler: gcc > addons: > apt: > @@ -81,6 +82,12 @@ matrix: > apt: > packages: > - *extra_packages > + - env: DEF_LIB="shared" EXTRA_PACKAGES=1 RUN_TESTS=1 > + compiler: clang > + addons: > + apt: > + packages: > + - *extra_packages > - env: DEF_LIB="static" OPTS="-Denable_kmods=false" EXTRA_PACKAGES=1 > compiler: clang > addons: > -- > 2.21.0 >