From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 75B1AA10DA
	for <public@inbox.dpdk.org>; Fri,  2 Aug 2019 15:40:24 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id D639C1C29C;
	Fri,  2 Aug 2019 15:40:23 +0200 (CEST)
Received: from mail-io1-f66.google.com (mail-io1-f66.google.com
 [209.85.166.66]) by dpdk.org (Postfix) with ESMTP id 0CDD61C298
 for <dev@dpdk.org>; Fri,  2 Aug 2019 15:40:21 +0200 (CEST)
Received: by mail-io1-f66.google.com with SMTP id k8so152280023iot.1
 for <dev@dpdk.org>; Fri, 02 Aug 2019 06:40:21 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=N4Nj1tREr0EPREL6FV2UOpFqMhmjD0NMhDXtKOFSgbg=;
 b=C0WiO7T0fOchAvI04Y1F5VyiUs0zjDyYGyX6Pm2qiUJgjWw0Hm88qPmme80vk9xb5p
 oob7cxeVN3WkPtzUkuQiNk1OYPM137wKP3cT+ltDNgp4EW92Mt93yS6IPBtzOEYUD74K
 s+rGMVT4aR1122B68wUw17IbYWV6gmMS729I/1j3CSY87wsN1/d9KYt93W3D8f1ne4qL
 zBKNqJ8YTa2uJUK8xWjk8TD4OE+10yU51Kn5Zmq7A4y/ruywRzeOcwOWTkyWV8Zl/0T4
 BEAVvatC/ezA4CRrGI76nHt4Kxp1JA9ZuUDHqNZYrM2RFn8qIKF+fnv9v5H/Ruwbcwip
 61XA==
X-Gm-Message-State: APjAAAUmSTjI+/V834cMSlTK8cYTgvKfhnzbs6XzX1FOARZc1Shzo9la
 Ww2kfGXgFc6zPNqOdeBUFP0CvUREDXGZrD6dUxIqIA==
X-Google-Smtp-Source: APXvYqzT5/yAEq+JWbe2Oul1l2eMyaegugKaRCPhjaGlmHvK8PP2hnsGLPBE4gWVotGT/JW/DemJWeuu72eITEAtO2A=
X-Received: by 2002:a6b:6409:: with SMTP id t9mr58757750iog.270.1564753221314; 
 Fri, 02 Aug 2019 06:40:21 -0700 (PDT)
MIME-Version: 1.0
References: <20190731145030.19956-1-aconole@redhat.com>
 <20190731145030.19956-3-aconole@redhat.com>
 <CABzctQ9i9xrG-w4nKefoqbPvOhiO+CWAuHs6njSph-EhwixU4w@mail.gmail.com>
 <f7ta7cr7ksp.fsf@dhcp-25.97.bos.redhat.com>
In-Reply-To: <f7ta7cr7ksp.fsf@dhcp-25.97.bos.redhat.com>
From: Michael Santana Francisco <msantana@redhat.com>
Date: Fri, 2 Aug 2019 09:40:10 -0400
Message-ID: <CABzctQ_QUHkUsivZsDWcEr-Wxp=4Fz=fSEb2e+yVpFgYWjb1jA@mail.gmail.com>
To: Aaron Conole <aconole@redhat.com>
Cc: dev <dev@dpdk.org>, David Marchand <dmarchan@redhat.com>, 
 Bruce Richardson <bruce.richardson@intel.com>,
 Ferruh Yigit <ferruh.yigit@intel.com>, Luca Boccassi <bluca@debian.org>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH 2/2] ci: enable unit tests under travis-ci
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Aug 2, 2019 at 9:34 AM Aaron Conole <aconole@redhat.com> wrote:
>
> Michael Santana Francisco <msantana@redhat.com> writes:
>
> > On Wed, Jul 31, 2019 at 10:50 AM Aaron Conole <aconole@redhat.com> wrote:
> >>
> >> When building under Travis (or another linux CI service), enable running the
> >> fast-tests for selected builds.  Only the shared builds are enabled at this
> >> point, since they are the ones passing.  Builds that are statically linked
> >> still show some issues in some of the eal_flags tests.  Additionally,
> >> the command to invoke fast tests includes a timeout multiplier, since
> >> some CI environments don't have enough resources to complete the tests in
> >> the default 10s timeout period.
> >>
> >> Signed-off-by: Aaron Conole <aconole@redhat.com>
> >> ---
> >>  .ci/linux-build.sh | 8 ++++++++
> >>  .ci/linux-setup.sh | 8 +++++++-
> >>  .travis.yml        | 9 ++++++++-
> >>  3 files changed, 23 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh
> >> index d5783c1a4..75f740648 100755
> >> --- a/.ci/linux-build.sh
> >> +++ b/.ci/linux-build.sh
> >> @@ -22,3 +22,11 @@ fi
> >>  OPTS="$OPTS --default-library=$DEF_LIB"
> >>  meson build --werror -Dexamples=all $OPTS
> >>  ninja -C build
> >> +
> >> +if [ "$RUN_TESTS" = "1" ]; then
> >> +    # On the test build, also build the documentation, since it's expensive
> >> +    # and we shouldn't need to build so much of it.
> >> +    ninja -C build doc
> >> +
> >> +    sudo meson test -C build --suite fast-tests -t 3
> >> +fi
> >> diff --git a/.ci/linux-setup.sh b/.ci/linux-setup.sh
> >> index acdf9f370..a40e62eaa 100755
> >> --- a/.ci/linux-setup.sh
> >> +++ b/.ci/linux-setup.sh
> >> @@ -1,3 +1,9 @@
> >>  #!/bin/sh
> >>
> >> -python3 -m pip install --upgrade meson --user
> >> +# need to install as 'root' since some of the unit tests won't run without it
> >> +sudo python3 -m pip install --upgrade meson
> >> +
> >> +# setup hugepages
> >> +cat /proc/meminfo
> >> +sudo sh -c 'echo 1024 > /proc/sys/vm/nr_hugepages'
> >> +cat /proc/meminfo
> > Can we drop cat /proc/meminfo?
> >> diff --git a/.travis.yml b/.travis.yml
> >> index 7b167fa64..c0c27bb7f 100644
> >> --- a/.travis.yml
> >> +++ b/.travis.yml
> >> @@ -30,6 +30,7 @@ env:
> >>    - DEF_LIB="shared"
> >>    - DEF_LIB="static" OPTS="-Denable_kmods=false"
> >>    - DEF_LIB="shared" OPTS="-Denable_kmods=false"
> >> +  - DEF_LIB="shared" RUN_TESTS=1
> > I don't agree with this. This is redundant. Why not put RUN_TESTS=1 on
> > an already exiting builds instead of adding two new builds like you
> > are doing here?
> > A build without the tests takes ~7 minutes, with the tests it
> > increases to ~9 minutes. These two new builds add ~18 minutes of build
> > time to the entire travis build time. We could use this ~18 minutes
> > instead to run the tests on 6 to 9 already existing builds since they
> > take 2 to 3 extra minutes on each one.
>
> Hi Michael,
>
> The ovsrobot was off for a bit due to an internal issue.  Now that it's
> back, a new build was generated.  Please have a look.  The time delta is
> about 8-12 minutes (because builds are in parallel) for a complete run
> (that's with all of the various jobs which make up a build).
>
> Do you think it's unreasonable?
This is reasonable. I didn't take parallelism into account. This looks
better now

Acked-by: Michael Santana <msantana@redhat.com>
>
> -Aaron