From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 29F04A0C47; Tue, 26 Oct 2021 08:04:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DEF2740A4B; Tue, 26 Oct 2021 08:04:39 +0200 (CEST) Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) by mails.dpdk.org (Postfix) with ESMTP id B1B5B4003E for ; Tue, 26 Oct 2021 08:04:38 +0200 (CEST) Received: by mail-lj1-f177.google.com with SMTP id q16so13800374ljg.3 for ; Mon, 25 Oct 2021 23:04:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LBUYqI3EpuSVswjHuMC+2WRt8HoqGQqJRvxGBifKrJQ=; b=YMWKO7RQsSuWTWCNB8dsih4fQpQWN3yU87WDXniGicmzMFyZBSmWDmyun01lq1GHit TdBbcQhW9TNo96Sf8PwocKXe/bnAI9p3wln/KR2X9doGCmqEJVTHeX07aANHk+bqB0lJ 9u/oFt9YYMM9iz/n2/b/skzq/rMON4p3evskAWNegAyBWOUj+noqbirya/oZHkc8ZDEl N44Fe3Mw3jurKyxwBTInhUpDZvJ6lm5tQBNXvtxHQfvthJBSUEhm0DT9MamJtGLfd95L +IA55vEkQWbxnYpF3fNIeFJGCnOrqX2vYGW5idoEJ0CdyxG2RN1Jzk+l98VcfYHB7PRI ybmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LBUYqI3EpuSVswjHuMC+2WRt8HoqGQqJRvxGBifKrJQ=; b=QXxR9V76N+8zOuozbfCsS9hv0cnmIucx3o+aMncqJDth1TSha7raNe3QOusZfYVZdR UfyHAxIRFiAce8K18p3c7btd0BYpB6wzxUDH2A4BVxmC3BSZW0CVPRkKA5zDZikam6vW P69Vtr90+tlrLi3vOoiiiczzUq1toO7JIF1PBJLhC9eNgTWWHrq4r2eTIqZTi8RSfEwv TskPXYK+24qI9e3ywGndZOI1YWqVUaOWEd9EO/S7a6GtNYuV8XTAhyUJFT9E4tLmgIz0 8Y1fC8WtVczWI2z02O3cdeJ0kYIcK4U+lDpQeYSqxlcleOfqDHKpyVL94gUUSxM+TGZV gbWA== X-Gm-Message-State: AOAM531m/hkaCZaHloq8bDFQzGHnjy1Z5MzeiuhEYrUbaUwTP/cV/LgJ GkN9pTdPWOyyMhZm2CjUfsuoxsl3lifKLeJcEB0= X-Google-Smtp-Source: ABdhPJwGqWy+Cf7FmoCoGSCek7/7edSAEQgxXWDVhcBVAFXADEntfBAWqrNE61VC/mCbxm2TXBxQU27oDoU+Cz8giSE= X-Received: by 2002:a05:651c:c5:: with SMTP id 5mr23707545ljr.48.1635228278183; Mon, 25 Oct 2021 23:04:38 -0700 (PDT) MIME-Version: 1.0 References: <20211020065944.19617-1-david.marchand@redhat.com> <20211021125938.52401-1-fengchengwen@huawei.com> <84c65bb4-d4f6-8d3b-c6c2-145f37e872f5@intel.com> In-Reply-To: <84c65bb4-d4f6-8d3b-c6c2-145f37e872f5@intel.com> From: Radha Mohan Date: Mon, 25 Oct 2021 23:04:26 -0700 Message-ID: To: Kevin Laatz Cc: Chengwen Feng , dpdk-dev , David Marchand , mdr@ashroe.eu, conor.walsh@intel.com, bruce.richardson@intel.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 1/3] dmadev: hide devices array X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Oct 21, 2021 at 7:04 AM Kevin Laatz wrote: > > On 21/10/2021 13:59, Chengwen Feng wrote: > > From: David Marchand > > > > No need to expose rte_dma_devices out of the dmadev library. > > Existing helpers should be enough, and inlines make use of > > rte_dma_fp_objs. I asked this earlier and was asked to use rte_dma_devices[] array by Kevin. Now that it has been made static is there a different way to get the fp_obj->private_data from a PMD .remove function ? I need the private data for DMA queue state cleanup. > > > > Signed-off-by: David Marchand > > Reviewed-by: Chengwen Feng > > Tested-by: Conor Walsh > > --- > > app/test/test_dmadev.c | 5 +++-- > > lib/dmadev/rte_dmadev.c | 2 +- > > lib/dmadev/rte_dmadev_pmd.h | 2 -- > > lib/dmadev/version.map | 1 - > > 4 files changed, 4 insertions(+), 6 deletions(-) > > > > Acked-by: Kevin Laatz