DPDK patches and discussions
 help / color / mirror / Atom feed
From: Radha Mohan <mohun106@gmail.com>
To: Radha Mohan Chintakuntla <radhac@marvell.com>
Cc: Veerasenareddy Burru <vburru@marvell.com>,
	Thomas Monjalon <thomas@monjalon.net>, dpdk-dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] raw/octeontx2_dma: fix unavailable PCI device in dpivf
Date: Fri, 9 Apr 2021 13:37:13 +0530	[thread overview]
Message-ID: <CAC8NTUUsB6gQR961dQT0dAHy=CuMScJRfnkaLv-pLt-9R+OPVg@mail.gmail.com> (raw)
In-Reply-To: <20210409075922.122787-1-radhac@marvell.com>

On Fri, Apr 9, 2021 at 1:29 PM Radha Mohan Chintakuntla
<radhac@marvell.com> wrote:
>
> The PCI device address is being used for sending mailbox which was
> introduced in previous commit which replaced the macros so that
> multiple DPI blocks in the hardware can be supported.
>
> This patch fixes a NULL pointer access by assigning the PCI device
> structure to dpivf.
>
> Fixes: 4495bd887d38 ("raw/octeontx2_dma: support multiple DPI blocks")
>
> Signed-off-by: Radha Mohan Chintakuntla <radhac@marvell.com>
> ---
>  drivers/raw/octeontx2_dma/otx2_dpi_rawdev.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/raw/octeontx2_dma/otx2_dpi_rawdev.c b/drivers/raw/octeontx2_dma/otx2_dpi_rawdev.c
> index efdba2779b..8c01f25ec7 100644
> --- a/drivers/raw/octeontx2_dma/otx2_dpi_rawdev.c
> +++ b/drivers/raw/octeontx2_dma/otx2_dpi_rawdev.c
> @@ -389,6 +389,7 @@ otx2_dpi_rawdev_probe(struct rte_pci_driver *pci_drv __rte_unused,
>         vf_id = ((pci_dev->addr.devid & 0x1F) << 3) |
>                  (pci_dev->addr.function & 0x7);
>         vf_id -= 1;
> +       dpivf->dev = pci_dev;
>         dpivf->state = DPI_QUEUE_START;
>         dpivf->vf_id = vf_id;
>         dpivf->vf_bar0 = (uintptr_t)pci_dev->mem_resource[0].addr;
> --
> 2.24.1

I sent another with proper subject patch version. Please ignore this.

  reply	other threads:[~2021-04-09  8:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-09  7:59 Radha Mohan Chintakuntla
2021-04-09  8:07 ` Radha Mohan [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-03-22 15:21 Radha Mohan Chintakuntla
2021-04-09  6:43 ` Jerin Jacob
2021-04-09  8:01   ` Radha Mohan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAC8NTUUsB6gQR961dQT0dAHy=CuMScJRfnkaLv-pLt-9R+OPVg@mail.gmail.com' \
    --to=mohun106@gmail.com \
    --cc=dev@dpdk.org \
    --cc=radhac@marvell.com \
    --cc=thomas@monjalon.net \
    --cc=vburru@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).