From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DF0FAA0579; Fri, 9 Apr 2021 10:07:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CB7A3141395; Fri, 9 Apr 2021 10:07:26 +0200 (CEST) Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com [209.85.219.52]) by mails.dpdk.org (Postfix) with ESMTP id 0099C141394 for ; Fri, 9 Apr 2021 10:07:25 +0200 (CEST) Received: by mail-qv1-f52.google.com with SMTP id j1so2218154qvp.6 for ; Fri, 09 Apr 2021 01:07:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yETfACGCACPw3M36dRdoMMl5vit5awTFMs2UPUUhkAo=; b=W1gZJUdNTSWP+9BbvHk1G+AjqxvP8K2wJ8eeoNTmLJjvlkqqqDGSokbRkLbBh2Frf0 /5AJvvC+NthMLXfxJ1PTsLlKXs4jab9hADlZbvBnOQFVOxStXd5Ec73Qg1/QLNwkziaa YH0FLtDDsQb+VbXp4pS+DJV9iTPLNtTW6DgRAk5Zx4MDwt+r2O0Rt1quo4a6aWKct2fU e/GGXrqDsTPH/EGd9Imtp9AuIKQP1eYfWXiSBft7nmr5HFztuh5z2cI/iJKPVCUEkzN+ 3SB2b3uBuKHoouo50sSpuwKp2dOy4Wt79VihlV30QxR0x3LIpVYn6cN+7pb1r5tZ+Daf OdqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yETfACGCACPw3M36dRdoMMl5vit5awTFMs2UPUUhkAo=; b=s6KzeFn22ROOPz6oTGIzSO7McJCFUrmIRkPBgB4v8s7RwEwl1piXJ7PxNZJkPfpXj/ usM0jj7ZYNpmXCWQvqrcnvVWqXD+/sKh7kkWd0s8y1NSeurBsx4l7s0JmN7z57Rhrlw6 iqTjOBeWW/da7SAlW4yx1gjHCSrz3Ep1xBH4ze14Pp7dBfVxXEP+0sP0cHb0pwzEoks2 UCU6LlL2aBoCxjdFHBRkXVljZcU64d13/T/acSDOZmUUaaBcbE1+M80+yp4XM0wzfg7E iClgkf7Ahw5DlUb7NMr5v3FaNrmOR8h1MNtLSzHmNdo8cf15ZRTH3vCFtfKCfkowvH8f PMEg== X-Gm-Message-State: AOAM533ygSo8MiDKveIi5M0oyMd3SmXET43LKXl6dPgZQADVMyhlv34W 8vcxRU866w7Sg5htDkc7F42jhxZWB0NAG3qd1nevPXdjWQM= X-Google-Smtp-Source: ABdhPJyXcsv4o55DIu4JYnzwKr9aUiJqdQuKSEr+HYZS1/oWqxuKZ0luHEoLDtltIgvqxgD/lDE3XRy9eU/8VJdbRPk= X-Received: by 2002:a05:6214:2689:: with SMTP id gm9mr12795267qvb.42.1617955645331; Fri, 09 Apr 2021 01:07:25 -0700 (PDT) MIME-Version: 1.0 References: <20210409075922.122787-1-radhac@marvell.com> In-Reply-To: <20210409075922.122787-1-radhac@marvell.com> From: Radha Mohan Date: Fri, 9 Apr 2021 13:37:13 +0530 Message-ID: To: Radha Mohan Chintakuntla Cc: Veerasenareddy Burru , Thomas Monjalon , dpdk-dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] raw/octeontx2_dma: fix unavailable PCI device in dpivf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Apr 9, 2021 at 1:29 PM Radha Mohan Chintakuntla wrote: > > The PCI device address is being used for sending mailbox which was > introduced in previous commit which replaced the macros so that > multiple DPI blocks in the hardware can be supported. > > This patch fixes a NULL pointer access by assigning the PCI device > structure to dpivf. > > Fixes: 4495bd887d38 ("raw/octeontx2_dma: support multiple DPI blocks") > > Signed-off-by: Radha Mohan Chintakuntla > --- > drivers/raw/octeontx2_dma/otx2_dpi_rawdev.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/raw/octeontx2_dma/otx2_dpi_rawdev.c b/drivers/raw/octeontx2_dma/otx2_dpi_rawdev.c > index efdba2779b..8c01f25ec7 100644 > --- a/drivers/raw/octeontx2_dma/otx2_dpi_rawdev.c > +++ b/drivers/raw/octeontx2_dma/otx2_dpi_rawdev.c > @@ -389,6 +389,7 @@ otx2_dpi_rawdev_probe(struct rte_pci_driver *pci_drv __rte_unused, > vf_id = ((pci_dev->addr.devid & 0x1F) << 3) | > (pci_dev->addr.function & 0x7); > vf_id -= 1; > + dpivf->dev = pci_dev; > dpivf->state = DPI_QUEUE_START; > dpivf->vf_id = vf_id; > dpivf->vf_bar0 = (uintptr_t)pci_dev->mem_resource[0].addr; > -- > 2.24.1 I sent another with proper subject patch version. Please ignore this.