DPDK patches and discussions
 help / color / mirror / Atom feed
From: Radha Mohan <mohun106@gmail.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
	Mahipal Challa <mchalla@marvell.com>,
	 Radha Chintakuntla <radhac@marvell.com>,
	Satha Koteswara Rao Kottidi <skoteshwar@marvell.com>,
	 "dev@dpdk.org" <dev@dpdk.org>,
	Veerasenareddy Burru <vburru@marvell.com>,
	Satananda Burla <sburla@marvell.com>,
	 David Marchand <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [EXT] Re: [PATCH] maintainers: Update for OcteonTx2 DMA and EP
Date: Wed, 18 Nov 2020 13:31:15 -0800
Message-ID: <CAC8NTUVNETSsKU4kUnowm6nS_8WDDYZW5PGbBb47ryvM-xd4aA@mail.gmail.com> (raw)
In-Reply-To: <4090240.s8fMJe6Fhk@thomas>

On Wed, Nov 18, 2020 at 1:15 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 18/11/2020 05:15, Radha Mohan:
> > On Mon, Nov 16, 2020 at 12:28 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> > > 16/11/2020 19:28, Radha Mohan:
> > > > On Fri, Nov 13, 2020 at 2:39 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> > > > > 13/11/2020 20:18, Radha Mohan:
> > > > > > On Tue, Nov 10, 2020 at 11:57 PM Mahipal Challa <mchalla@marvell.com> wrote:
> > > > > > From: Radha Mohan <mohun106@gmail.com>
> > > > > > Sent: Tuesday, November 10, 2020 11:44 PM
> > > > > > > On Mon, Nov 9, 2020 at 4:20 PM Radha Mohan Chintakuntla <radhac@marvell.com> wrote:
> > > > > > > >
> > > > > > > > Replace the maintainers for OcteonTx2 DMA and EP drivers.
> > > > > > > >
> > > > > > > > Signed-off-by: Radha Mohan Chintakuntla <radhac@marvell.com>
> > > > > [...]
> > > > > > > >Adding previous maintainers to ack.
> > > > > > > Acked-by: Mahipal Challa <mchalla@marvell.com
> > > > > > >
> > > > > > > Thanks,
> > > > > > > Mahipal
> > > > > >
> > > > > > Hi Thomas,
> > > > > > Could you please pick this patch ?
> > > > >
> > > > > This low-priority patch has been sent 4 days ago,
> > > > > and was acked by only 1 maintainer 3 days ago.
> > > > >
> > > >
> > > > It was acked by both the old maintainers Satha Koteshwar and Mahipal
> > > > Challa. Maybe both of those emails didn't come on top of each other.
> > >
> > > I missed one.
> > >
> > > > > Why pushing? What is your fear exactly?
> > > >
> > > > Just want to make the transfer of ownership official in the mainline.
> > > > There's no fear I just normally wanted to send a reminder to you to
> > > > pick as it might be missed inclusion. If there's a guarantee that all
> > > > ack'ed patches will go automatically then I won't be sending any
> > > > reminder emails in future.
> > >
> > > It's OK to send reminder, but please wait at least a week.
> > >
> > > > > Why the new maintainers candidates have 0 and 2 contributions
> > > > > in git history?
> > > > >
> > > > These drivers requires some maintenance and likely expanded to support
> > > > future chips from Marvell. So you will not see contributions right
> > > > away.
> > > > So to become a maintainer one has to have prior contributions ?
> > >
> > > Yes: http://doc.dpdk.org/guides/contributing/patches.html#maintainers-and-sub-trees
> > > "
> > > Maintainers should have demonstrated a reasonable level of contributions or reviews to the component area. The maintainer should be confirmed by an ack from an established contributor.
> > > "
> >
> > How was this done without prior contributions?
> > http://git.dpdk.org/dpdk/commit/MAINTAINERS?id=238e3167ca869abf44fa50ead022d7fc3b99605b
>
> I asked a confirmation:
> http://inbox.dpdk.org/dev/1985242.AXpOyGb66D@thomas/

Right. But in this case I got different.

>
>
> > The commit log says that he is a "new developer". So am I technically
> > to the community.
> >
> > Also the thing that puzzles me most is its a driver specific to
> > Marvell and both the previous maintainers are ok with the transfer but
> > a strange rule that probably applies to generic things of dpdk code
> > (which really makes sense there) comes as a blocker.
>
> Did I say it is a blocker?

Maybe I got that impression from your comments.

>
> > And how does new driver go?
>
> For new drivers, the new maintainers arrive by contributing new code.
>
> > Lets say if either myself or veerasena have pushed a new driver now
> > who has to ack it for inclusion ? Isn't that like a chicken and egg
> > problem.
>
> Nobody has to ack for a new driver.
>
> > I am looking for clarifications as things are different in other open
> > source communities.
> >
> > > > Kind of makes odd sense as these drivers are specific to our chip and we
> > > > are changing ownership for maintaining them.
> > > > I do not understand why you have an issue here?
> > > > You don't like reminding then I understand.
> > >
> > > I don't like how you push new unconfirmed maintainers.
> >
> > Could you please explain above commit made into new maintainer?
>
> Listen: I say I don't like how pushy you are, that's all.
> In general it's very good to have new contributors.
> But please think how you can help instead of just requesting.
> We have a lot more important things to care at the moment
> to close the big release 20.11. If you want to help, you are welcome.
>

ok fair enough. For my defence i wasn't being pushy. So hopefully this
updation can be taken once you are able to do after 20.11.

>

  reply	other threads:[~2020-11-18 21:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-10  0:19 [dpdk-dev] " Radha Mohan Chintakuntla
2020-11-10 18:13 ` Radha Mohan
2020-11-10 18:18   ` [dpdk-dev] [EXT] " Satha Koteswara Rao Kottidi
2020-11-11  7:56   ` Mahipal Challa
2020-11-13 19:18     ` Radha Mohan
2020-11-13 22:38       ` Thomas Monjalon
2020-11-16 18:28         ` Radha Mohan
2020-11-16 20:28           ` Thomas Monjalon
2020-11-18  4:15             ` Radha Mohan
2020-11-18  9:15               ` Thomas Monjalon
2020-11-18 21:31                 ` Radha Mohan [this message]
2020-11-22 11:28     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAC8NTUVNETSsKU4kUnowm6nS_8WDDYZW5PGbBb47ryvM-xd4aA@mail.gmail.com \
    --to=mohun106@gmail.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=mchalla@marvell.com \
    --cc=radhac@marvell.com \
    --cc=sburla@marvell.com \
    --cc=skoteshwar@marvell.com \
    --cc=thomas@monjalon.net \
    --cc=vburru@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git